SwiftUI - Camera Frame messes up with Orientation - ios

Question

I am a swift/swiftUI newbie and I have a CameraService that is used in CameraView which is also used in CustomCameraView where I change the orientation and there is a button for taking photos.
I also have a ContentView which is the main page of the app. There is a button for taking photos which opens up the CustomCameraView.
When the user changes the orientation of the device in CustomCameraView the CameraView still stays in the Portrait Orientation (I think). So this causes the camera to look like this:
I did try some updates but they did not work. To summarize the flow goes like CameraService -> CameraView -> CustomCameraView -> ContentView -> CameraApp
import Foundation
import AVFoundation
class CameraService {
var session: AVCaptureSession?
var delegate: AVCapturePhotoCaptureDelegate?
let output = AVCapturePhotoOutput()
let previewLayer = AVCaptureVideoPreviewLayer()
func start(delegate : AVCapturePhotoCaptureDelegate,
completion: #escaping (Error?) -> ()) {
self.delegate = delegate
checkPermission(completion: completion)
}
private func checkPermission(completion: #escaping (Error?) -> ()) {
switch AVCaptureDevice.authorizationStatus(for: .video) {
case .notDetermined:
AVCaptureDevice.requestAccess(for: .video) { [weak self] granted in
guard granted else { return }
DispatchQueue.main.async {
self?.setupCamera(completion: completion)
}
}
case .restricted:
break
case .denied:
break
case .authorized:
setupCamera(completion: completion)
#unknown default:
break
}
}
private func setupCamera(completion: #escaping (Error?) -> ()) {
let session = AVCaptureSession()
previewLayer.connection?.videoOrientation = AVCaptureVideoOrientation.landscapeLeft
if let device = AVCaptureDevice.default(for: .video){
do {
let input = try AVCaptureDeviceInput(device: device)
if session.canAddInput(input){
session.addInput(input)
}
if session.canAddOutput(output){
session.addOutput(output)
}
previewLayer.connection?.videoOrientation = AVCaptureVideoOrientation.landscapeLeft
previewLayer.videoGravity = .resizeAspectFill
previewLayer.session = session
session.startRunning()
self.session = session
} catch {
completion(error)
}
}
}
func capturePhoto(with settings: AVCapturePhotoSettings = AVCapturePhotoSettings()) {
output.capturePhoto(with: settings, delegate: delegate!)
}
func captureVideo(){
// TODO
}
func ViewUpdated(){
previewLayer.videoGravity = .resizeAspectFill
previewLayer.session = session
}
}
Camera View:
import SwiftUI
import AVFoundation
struct CameraView : UIViewControllerRepresentable {
func makeCoordinator() -> Coordinator {
Coordinator(self, didFinishProcessingPhoto: didFinishProcessingPhoto)
}
typealias UIViewControllerType = UIViewController
let cameraService : CameraService
let didFinishProcessingPhoto: (Result<AVCapturePhoto, Error>) -> ()
func makeUIViewController(context: Context) -> UIViewController {
cameraService.start(delegate: context.coordinator) { err in
if let err = err {
didFinishProcessingPhoto(.failure(err))
return
}
}
let viewController = UIViewController()
viewController.view.backgroundColor = .black
viewController.view.layer.addSublayer(cameraService.previewLayer)
cameraService.previewLayer.connection?.videoOrientation = AVCaptureVideoOrientation.landscapeLeft
cameraService.previewLayer.frame = UIViewController().view.bounds
cameraService.previewLayer.videoGravity = .resizeAspectFill
return viewController
}
func updateUIViewController(_ uiViewController: UIViewController, context: Context) {
cameraService.previewLayer.videoGravity = .resizeAspectFill
cameraService.previewLayer.frame = UIViewController().view.bounds
}
class Coordinator: NSObject, AVCapturePhotoCaptureDelegate {
let parent: CameraView
private var didFinishProcessingPhoto: (Result<AVCapturePhoto, Error>) -> ()
init(_ parent : CameraView,
didFinishProcessingPhoto: #escaping (Result<AVCapturePhoto, Error>) -> ())
{
self.parent = parent
self.didFinishProcessingPhoto = didFinishProcessingPhoto
}
func photoOutput(_ output: AVCapturePhotoOutput, didFinishProcessingPhoto photo: AVCapturePhoto, error: Error?) {
if let error = error {
didFinishProcessingPhoto(.failure(error))
return
}
didFinishProcessingPhoto(.success(photo))
}
}
}
CustomCameraView:
import SwiftUI
struct CustomCameraView : View {
let cameraService = CameraService()
#Binding var capturedImage : UIImage?
#Environment(\.presentationMode) private var presentationMode
var body : some View{
ZStack {
CameraView(cameraService: cameraService) {result in
switch result {
case .success(let photo):
if let data = photo.fileDataRepresentation(){
capturedImage = UIImage(data: data)
presentationMode.wrappedValue.dismiss()
}
else {
print("Error: NO IMAGE DATA FOUND")
}
case .failure(let err):
print(err.localizedDescription)
}
}
VStack{
Image(systemName: "ellipsis.message").font(.system(size: 72))
Spacer()
Button(action: {
cameraService.capturePhoto()
}, label: {
Image(systemName: "circle").font(.system(size: 72))
.foregroundColor(.blue)
})
.padding(.bottom)
}
}.onAppear{
// Forcing the orientation
UIDevice.current.setValue(UIInterfaceOrientation.landscapeLeft.rawValue, forKey: "orientation")
// Locking Orientation
AppDelegate.orientationLock = .landscapeLeft
cameraService.ViewUpdated()
}.onDisappear{
// Unlocking Orientation
AppDelegate.orientationLock = .all
}
}
}
As you can see I have tried some orientation lock with the class below which is defined in app:
#UIApplicationDelegateAdaptor (AppDelegate.self) var appDelegate
// Added for locking/unlocking the orientation
class AppDelegate : NSObject, UIApplicationDelegate {
static var orientationLock = UIInterfaceOrientationMask.all // By default you want all your views to rotate freely
func application(_ application: UIApplication, supportedInterfaceOrientationsFor window : UIWindow?) -> UIInterfaceOrientationMask {
return AppDelegate.orientationLock
}
}
The lock actually works for CustomCameraView(inherits View) but It doesn't do anything for CameraView(inherits UIViewControllerRepresentable). I have seen some answers to similar questions in UIKit but I don't use it. I need a SwiftUI answer specifically. Thanks in advance!