End game if entire team is dead [Roblox Lua] - lua

Question

I am working on a game where a player is randomly selected to be the beast and has to kill the entire investigator team.
But I am having issues with the game recognizing that the entire investigator team is dead.
I've inserted my code below;
function playerAlive()
local activePlayers = game.Workspace.ImportantBlock:GetAttribute("numPlayers")
local inGame = game.Workspace.ImportantBlock:GetAttribute("inGame")
local playerTeam = game.Players.LocalPlayer.Team:GetAttribute()
if playerTeam(Investigator)==0 then
game.Workspace.ImportantBlock:SetAttribute("inGame", false)
end
wait(1)
playerAlive()
end
(I connected important values to costume attributes within a block I named "ImportantBlock" because I am having issues with global variables, so far it caused no problems.)

Answer 1

There are two lines which are problematic:
local playerTeam = game.Players.LocalPlayer.Team:GetAttribute()
if playerTeam(Investigator)==0 then
What you seem to want to do is to check how many players are in the "Investigator" team. However, you're trying to call the playerTeam variable (as a function) with an argument, called Investigator, and comparing that.
playerTeam will never be a function (attributes can't be functions). Besides, a GetAttribute call without arguments will error.
The way to count the players in a team is the following:
-- this should probably be at the top of your file, but it works anywhere
local Teams = game:GetService("Teams")
local Players = game:GetService("Players")
local InvestigatorTeam = Teams["Investigator"]
-- in your function:
local count = 0
for _, player in ipairs(Players:GetPlayers()) do
if player.Team == InvestigatorTeam then
count += 1
end
end
if count == 0 then
--no players left
end
P.S. You're setting yourself up with a nice stack overflow error here. You keep calling the playerAlive function in itself until there are no players. If you keep doing this long enough, the stack will get filled up and your script will crash.
Your can avoid this like so:
function countPlayers()
local count = 0
for _, player in ipairs(Players:GetPlayers()) do
if player.Team == InvestigatorTeam then
count += 1
end
end
return count
end
function checkGameEnded()
while true do
if countPlayers() == 0 then
game.Workspace.ImportantBlock:SetAttribute("inGame", false)
end
task.wait(1)
end
end
One final note: don't use wait(), use task.wait(). The former is old, poorly implemented, inconsistent and most importantly, deprecated. The newer version uses heartbeats to count time.
One more final note: use workspace instead of game.Workspace.