in VS code review
I'm trying to add "overall comments" and add "file comment" from reviewer.
but these option are disabled (marked in grey)
See images below.
What is the reason for this?
Thanks.
Add overall comments button disabled
Add file comment button disabled
This code review is supposed to be closed by the requestor. You can check your code review to see whether it is closed as the screenshot shows:
Related
Below is the scenario
1) I got code review suggestion
2) I worked on those suggestions.
3) I closed the Code review request to send a new code review request.
4) But I Did NOT sent any Code review Request. As I remember I forgot to add one Nuget Package. So I tried to add it, but it did nt worked as expected, so I uninstalled some dependent packages as well :|
Can I get the code at stage 3 ? I can not see the Request in Code reviews to unshelve as its closed.
Can someone guide me here ?
You could select Recently finished in your Code Reviews, find the code review that you need, open the code review and click View Shelveset. Check the screenshot below:
I made some changes and then requested Code Review in TFS, then realized I had made the changes to the wrong branch. So I tried to delete the work item to show that I no longer needed code review (at least in this branch). However, when I tried to do that, I got the beautiful red error:
Failed to delete work item: 1061. Error Details: VS402838: The work item 1061 cannot be deleted. Code Review Request work items cannot be deleted.
For now, I'll just have everybody complete the code review where it sits, and then I'll make the exact same changes in the correct branch. But I'm wondering what you are supposed to do in this case if they insist you can't delete Code Review Request work items.
This can be accomplished by creating a query that includes the desired work item, then editing it from within the query.
Create a new query, then specify criteria such as Created By (yourself) that will find the work item. ID doesn't work so well if the work item was already assigned out, as each reviewer has their own work item.
Right-Click the work item you want to edit.
Select edit from the context menu.
Steps 1-3:
In the window that comes up, enter "State" for Field and "Closed" for Value:
Enter some notes about the manual change and then close the dialog with the "OK" button, and then don't forget to save your changes with this button:
I think The Right Thing to do in TFS-land is to Abandon the Code Review, since you can't delete it from TFS.
The previous answers have two means of doing that. Here's a third, from within Visual Studio, since that seemed like a convenient alternative.
Open My Work in the Team Explorer window.
Find the Code Reviews section of My Work.
Right-click the Code Review you want to Abandon.
Select Open.
In the Code Review UI, select Close Review for the reason Abandon
Profit.
You can cancel a code review required by using excel
Please try this workaround: create a work query to get all that user’s Code Review Request work items which in Requested state, save this work item query and open this query in Excel, then edit them work items in Excel to change the state to Closed, then click Publish button to publish the updates to TFS Server.
See this URL https://social.msdn.microsoft.com/Forums/vstudio/en-US/83d96317-cdd7-436c-8415-fda54d1ce752/cancel-a-code-review-request?forum=tfsworkitemtracking
Is there a way to remove "Related Work Items" from a Code Review Request that was mistakenly added? (TFS2012, update2)
How about for another user?
Thanks!
No, it's impossible. Since the work item is related during the "pending changes" page. After the code review request created, there is no way to edit the related work item.
If you want to remove the wrong work item. So you may need to abandon this code request first. And in the "pending changes" page, right click the work item to remove work item. Create a code review request then.
I created a workflow successfully, suddenly I came to know that I missed a status in it. I added the status "Patch Sent" but there's no option with it to Add Transitions. Whereas I added another status after is "Development Completed" and it has the option to add transitions. It is so confusing, and I have tried by every mean.
I edited using the edit button but it just gave the option to rename the status. Same is the case with View Property button, it does not do anything for me.
Take a look at https://confluence.atlassian.com/display/JIRA/Configuring+Workflow and "Active versus inactive workflows". You'll need to deactivate or copy that workflow to make that change
Not able to add comments on Gerrit. It rather gets added as Draft. What am I doing wrong? Others in my team are able to add comments though.
Comments are published when you make them part of a review. Post a review and the comments will be published with it. (You can score the commit as +0 if you don't have any opinion either way.)
Click on the Reply button in the header. Then Post it.
For those who has happened to be stumbled (like me) with how to post comments for work-in-progress (WIP) review without starting review (e.g. leaving in work-in-progress state), Gerrit version 2.16. Here's counter-intuitive answer:
Press "START REVIEW" button - don't afraid, it will not start review immediately (at least on above mentioned version)
Press "SAVE" (greyish! not quite noticeable) in opened window in left bottom corner
UPDATE
In newer version I got 3.2.3 - it's been improved, the button is not greyish and looks normal and in the right bottom corner together with other buttons: | CANCEL | SAVE | SEND AND START REVIEW |
And since I am not able to add a comment :
When you want to add comments to a specific revision(Patch Set),
switch to that revision and then click on reply. This "Patch Sets" option is found on the upper right corner next to "Download".
Had to learn the Hard Way today. :-/
At least on Qt's Gerrit system:
After saving the comment draft, yse the keyboard shortcut 'r' to publish a "review" which publishes the comment.