Pull Request Permission - tfs

I have question on ADS GIT Pull request permissions Is there any way to prevent others from being able to change the status your pull request? like being able to publish your draft request, setting the complete status, abandoning etc?

Is there any way to prevent others from being able to change the status your pull request?
Sorry for any inconvenience.
Now, Azure devops service/server doesn't provide a feature to meet this requirement.
To protect the Pull Request, you could add reviewers for the target branch to prevent set the complete status directly.
On the other hand, we could set creator's target branch or repo contribute permission to Deny, you need to add specific user to target Branch security page. This not applied to all the creators all the PRs. Just a specific PR and specific user:
But none of these settings apply to abandon. For this option, you could add your request for this feature on our UserVoice site (https://developercommunity.visualstudio.com/content/idea/post.html?space=21 ), which is our main forum for product suggestions. Thank you for helping us build a better Azure DevOps.
Hope this helps.

Related

Deny pull requests into specific branch in TFS

I need to deny creating pull requests into specific branch for a certain group of users.
They are already set as a group in TFS, that group has been set "Deny" permission for "Contribute" to that specific branch - however its members are still able to create pull requests.
Am I doing something wrong?
Users with "Contribute" permission in a branch can push new commits to the branch and lock the branch. This permission doesn't control creating pull requests.
There is no permission to control creating pull requests on branch level, you can only control creating pull requests on Repo level, check the following screenshot:
You can only use branch policy to protect your Git branch, but deny creating pull requests into specific branch is not an option.

Restrict comment resolution in TFS to author only

It is possible to set branch policy to require comment resolution before pull request can be completed. However, it seems that anyone - not just the comment author - is able to set comment status to "Resolved" and therefore complete the pull request effectively circumventing the policy.
Is there a way to restrict that and configure the system so that only comment author is able to set it's status to "Resolved"?

Default reviewers in TFS

Our company is using Team Foundation Server 2015. Is it possible to add one or several persons automatically as reviewers to every pull request? As required default reviewers?
Yes, you can add default reviewers to pull requests quite easily.
If you configure your branch policy you can have different reviewers occur for different code paths. If you want to add default reviewers to all pull requests for that code path you can specify "/*" in the path box. They will then be added to every pull request.

What is the intended pull request rejection workflow in TFS/Team Services?

my team and I are using Team Services with Visual Studio 2015. I understand the concept of a pull request, but the rejection and correction process is very blur.
MSDN falls short of covering this part on the main page regarding the topic: https://msdn.microsoft.com/en-us/library/vs/alm/code/git/pull-requests
Basically, when you reject a pull request, what's expected of the person that created it? Should he modify his branch and issue a new different request? or bring changes to his branch in a way that will make it appear under the current request? In the latter case, how?
Thanks
More detailed description is placed here: Conduct a Git pull request on Visual Studio Online
Make changes on the source branch
To act on the feedback, the requestor revises the code on their dev
machine and pushes the changes so that reviewers can see them.
So the requestor need to update his code and push the changes into source branch. The code in the pull request will be updated automatically after new change is pushed.

Bitbucket new webhook not working

Bitbucket has improves its Webhooks functionality. We won't be able to create POST or Pull Request POST in Services, instead in Webhooks.
So I have tried to create POST request to Slack using new Webhook, but it doesn't work. Clicked on View requests, I got 500 error on the request. While with the same URL, it works in Services.
I don' know what I did wrong. Bitbucket documentation doesn't help. Can someone please help me?
I'm experiencing the same problem, and it appears to be a known issue with the integration (from the perspective of Slack).
As documented on slack.com:
This integration only supports the Repository push trigger at this
time, so make sure it is selected. Press Save when you're done.
I'm not sure where to find a public link to this document, but you can find it if you go to add the bitbucket integration. And the documentation on slack appears to be up to date with the new bitbucket webhooks.
Hopefully one of the parties fixes it soon.
Update:
The integration appears to have started working in the last couple of days. At least for us with PR create/update/comment?approve/merge.
Maybe Graham is talking about this here. You maybe need to change your IP-whitelist to connect to your server.
131.103.20.160/27 165.254.145.0/26 104.192.143.0/24.
I never used Posthooks. I m myself struggeling with the webhook configuration.
Not sure if this is related to your issue, but I'm putting it here as it might help others, there's currently an open issue related to non-standard ports that has similar symptoms:
https://bitbucket.org/site/master/issue/11514/webhook-fails-when-using-an-alternative
Do you have any IP limits on what IPs can post to that end target? The new web hooks may be using different IP addresses than the old services.

Resources