Sqflite gives stack Error when trying to insert data - dart

Question

I am just trying to save a user to my database. Following is my user model class
class User {
int _id;
String _userId;
String _mobileNumber;
User([this._userId, this._mobileNumber]);
User.withId(this._id, this._userId, this._mobileNumber);
int get id => _id;
String get userId => _userId;
String get mobileNumber => _mobileNumber;
set userId(String newUserId) {
this.userId = newUserId;
}
set mobileNumber(String newMobileNumber) {
this.mobileNumber = newMobileNumber;
}
Map<String, dynamic> toMap() {
var map = Map<String, dynamic>();
if (id != null) {
map["id"] = _id;
}
map["userId"] = _userId;
map["mobileNumber"] = _mobileNumber;
return map;
}
User.fromMapObject(Map<String, dynamic> map) {
this._id = map["id"];
this._mobileNumber = map["userId"];
this._userId = map["mobileNumber"];
}
}
Here is my repository class
class UserRepository {
static UserRepository _userRepository;
static Database _database;
String userTable = "user";
String colId = "id";
String colUserId = "userId";
String colMobileNumber = "mobileNumber";
String databaseName = "dice.db";
UserRepository._createInstance();
factory UserRepository() {
if (_userRepository == null) {
_userRepository = UserRepository._createInstance();
}
return _userRepository;
}
Future<Database> get database async {
if (_database == null) {
_database = await initializeDatabase();
}
return _database;
}
Future<Database> initializeDatabase() async {
Directory directory = await getApplicationDocumentsDirectory();
String path = directory.path + databaseName;
var userDatabase =
await openDatabase(path, version: 1, onCreate: _createDb);
return userDatabase;
}
void _createDb(Database db, int newversion) async {
await db.execute(
"CREATE TABLE $userTable($colId INTEGER PRIMARY KEY AUTOINCREMENT,$colUserId TEXT, $colMobileNumber TEXT)");
}
Future<List<Map<String, dynamic>>> getUserMapList() async {
Database db = await this.database;
return await db.query(userTable);
}
Future<int> insertUser(User user) async {
Database db = await this.database;
return await db.insert(userTable, user.toMap());
}
Future<int> updateNote(User user) async {
var db = await this.database;
return await db.update(userTable, user.toMap(),
where: "$colId = ?", whereArgs: [user.id]);
}
Future<List<User>> getUserList() async {
var userMapList = await getUserMapList();
List<User> userList = List<User>();
//We have only one user so i am only getting user at 0th position
userList.add(User.fromMapObject(userMapList[0]));
return userList;
}
}
var userRepository = UserRepository();
Now in my main class on button's click i am writing following code to save the user
User user = User();
user.mobileNumber = mobileData.data.mobile.toString();
user.userId = mobileData.data.userid.toString();
userRepository.insertUser(user).then((result) {
if (result != 0) {
print("Successfully saved to database");
} else {
print("Error saving to database");
}
});
Following is the error when i click the button
[ERROR:flutter/shell/common/shell.cc(184)] Dart Error: Unhandled exception:
E/flutter (23914): Stack Overflow
E/flutter (23914): #0 User.mobileNumber= (package:dice_clutter/repository/User.dart:20:3)
E/flutter (23914): #1 User.mobileNumber= (package:dice_clutter/repository/User.dart:21:10)
RootZone.runUnary (dart:async/zone.dart:1379:54)
E/flutter (23914): #19311 _FutureListener.handleValue (dart:async/future_impl.dart:129:18)
E/flutter (23914): #19312 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:642:45)
E/flutter (23914): #19313 Future._propagateToListeners (dart:async/future_impl.dart:671:32)
E/flutter (23914): #19314 Future._complete (dart:async/future_impl.dart:476:7)
E/flutter (23914): #19315 _SyncCompleter.complete (dart:async/future_impl.dart:51:12)
E/flutter (23914): #19316 _AsyncAwaitCompleter.complete (dart:async/runtime/libasync_patch.dart:28:18)
E/flutter (23914): #19317 _completeOnAsyncReturn (dart:async/runtime/libasync_patch.d
I am creating only one reference of my repository class.
Any help would be appreciated.

Answer 1

You have a stackoverflow because you are using the name of your setter
Change this:
set userId(String newUserId) {
this.userId = newUserId;
}
set mobileNumber(String newMobileNumber) {
this.mobileNumber = newMobileNumber;
}
To this:
set userId(String newUserId) {
_userId = newUserId;
}
set mobileNumber(String newMobileNumber) {
_mobileNumber = newMobileNumber;
}

Answer 2

Looks like the issue is caused by this setter:
set mobileNumber(String newMobileNumber) {
this.mobileNumber = newMobileNumber;
}
Setting this.mobileNumber will cause the setter to be run so calling inside a setter method will cause an infinite loop and a Stack Overflow exception.
To fix it, set the private variable:
set mobileNumber(String newMobileNumber) {
_mobileNumber = newMobileNumber;
}
You should do the same on your userId setter as this has the same problem.