Invalid NSError Instance - firebase-realtime-database

Question

I am getting a weird message in the console after I run this code:
func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {
let pickUp = sortedPickUps[indexPath.item]
let alert = UIAlertController(title: "Delete", message: "Permanently delete your order?", preferredStyle: .alert)
let yes = UIAlertAction(title: "Yes", style: .destructive) { (actio) in
DispatchQueue.main.async {
self.pickUpController.delete(pickUp: pickUp)
self.pickUpController.deleteFirebasePickUp(pickUp: pickUp, completion: { (error) in
if let error = error {
NSLog("Error deleting pick up \(error)")
}
})
self.sortedPickUps = self.pickUpController.pickUps.sorted(by: { $0.timestamp > $1.timestamp })
self.collectionView.reloadData()
}
self.sendNotification()
}
let no = UIAlertAction(title: "No", style: .default) { (action) in }
alert.addAction(yes)
alert.addAction(no)
present(alert, animated: true, completion: nil)
}
The URLSession in the deleteFirebasePickUp looks like this
URLSession.shared.dataTask(with: request) { (data, _, error) in
if let error = error {
NSLog("Error deleting entry from server: \(error)")
DispatchQueue.main.async {
completion(error)
}
return
}
DispatchQueue.main.async {
guard let index = self.pickUps.index(of: pickUp) else {
NSLog("Something happened to the entry")
completion(NSError())
return
}
self.pickUps.remove(at: index)
completion(nil)
}
}.resume()
The app doesn't crash, and in fact does what it's supposed to do - removes the pickUp from the device and from the database. The error is error = (Error?) domain: nil - code:0
The debugger says
Something happened to the entry 2018-10-13 14:14:37.608435-0700 chute[36293:4218837] -[NSError init] called; this results in an invalid NSError instance. It will raise an exception in a future release. Please call errorWithDomain:code:userInfo: or initWithDomain:code:userInfo:. This message shown only once.
Any ideas?

Answer 1

Reread the debugger's message:
[NSError init] called; this results in an invalid NSError instance.
If you reread your second code block
DispatchQueue.main.async {
guard let index = self.pickUps.index(of: pickUp) else {
NSLog("Something happened to the entry")
completion(NSError()) // THIS LINE
return
}
self.pickUps.remove(at: index)
completion(nil)
}
The NSError() constructor corresponds to [NSError init], which is deprecated. You should use the init(domain:code:userInfo:) initializer instead: https://developer.apple.com/documentation/foundation/nserror/1417063-init