make pop up view disappear - ios

Question

I have button, when I click that button, a view pops up.
testingButton.addTarget(self, action: #selector(popupTable), for: .touchUpInside)
#objc func popupTable(){
self.opaqueView = self.setUpPopView()
mainView.addSubview(opaqueView)
print("button clicked")
}
if the view is present, I want to click on the button again and make the view disappear.
if tinyView.isHidden == false {
tinyView.isHidden = false
self.testingButton.addTarget(self, action: #selector(removePopUp), for: .touchUpInside)
}else{
tinyView.isHidden = true
mainView.addSubview(tinyView)
}
Which it does but when I click on the button a third time (pop up view is not present) i want the pop up view to appear again but it doesn't.
show pop up
func setUpPopView () -> UIView {
tinyView.backgroundColor = UIColor(red:0.99, green:0.99, blue:0.99, alpha:1.0)
tinyView.layer.cornerRadius = 3
tinyView.layer.masksToBounds = false
tinyView.layer.shadowColor = UIColor.black.withAlphaComponent(0.4).cgColor
tinyView.layer.shadowOffset = CGSize(width: 0, height: 0)
tinyView.layer.shadowOpacity = 0.9
let post: UIButton = UIButton(frame: CGRect(x: 5, y: 10, width: 150, height: 50))
post.backgroundColor = UIColor.clear
post.setTitleColor(UIColor.black, for:UIControlState.normal)
post.setTitle("All Post", for: .normal)
post.contentHorizontalAlignment = .left
post.addTarget(self, action: #selector(removePopUp), for: .touchUpInside)
tinyView.addSubview(post)
}
remove pop up
#objc func removePopUp(_ sender: AnyObject){
self.tinyView.removeFromSuperview()
}

Answer 1

You should use one action only and check the visibility of the pop up view in the action. According to the visibility of the view you can then show or hide the pop up.
Like this:
#objc func popupAction() {
If self.popUpView.isHidden {
// Pop up view is hidden, so show the pop up view again
} else {
// Pop up view is visible, so hide the pop up view
}
}
Also change this:
if tinyView.isHidden == false
{
tinyView.isHidden = false
self.testingButton.addTarget(self, action: #selector(removePopUp), for: .touchUpInside)
}else{
tinyView.isHidden = true
mainView.addSubview(tinyView)
}
With this:
if tinyView.isHidden == false
{
tinyView.isHidden = true
tinyView.removeFromSuperview()
}else{
tinyView.isHidden = false
mainView.addSubview(tinyView)
}

Answer 2

You should not be calling removeFromSuperview. You should not be saying if. It all just adds unnecessary complications.
If your goal is to show and hide a view, just show it and hide it: toggle its hiddenness, which is a one-liner:
tinyView.isHidden = !tinyView.isHidden
That way, if it is invisible, it becomes visible, and if it is visible, it becomes invisible. In Swift 4.2, it's even simpler:
tinyView.isHidden.toggle()
That's all! You don't need know whether it's already hidden, you don't need to remove it from the superview. No if, no nothing. You just invert its hiddenness each time you want to hide or show it.