UITableViewCell tag changes after scrolling [duplicate] - ios

Question

This question already has answers here:
Swift: retrieving text from a UITextField in a custom UITableViewCell and putting it in an array
(2 answers)
Closed 5 years ago.
I am creating a form in UITableView. This form has a UILabel and UITextField in a prototype cell. Each UITextField has a unique tag.
When user clicks submit button, I want to get value from each UITextField using a tag.
Now the problem is I have 18 UITextField and when I enter values in the field and scroll the view to fill the remaining fields, after filling the data when I press submit button, the app crashes. It won't be able to find the tag of first UITextField.
I want to compare UITextFields value. But I don't want to collect all textfields value. I want to retrieve particular textfield value and compare it with other textfield value on the submit button click.
This is how my UITableView Looks
Here is my code:
func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
let cell = tableView.dequeueReusableCell(withIdentifier: "SurveyFormTableViewCell", for: indexPath) as! SurveyFormTableViewCell
var pest_code = textfield_id_value[indexPath.row].pest_code
var srno = textfield_id_value[indexPath.row].srno
var inspection_no = textfield_id_value[indexPath.row].inspection_no
cell.text_field.layer.cornerRadius = 3
cell.text_field.layer.borderWidth = 1
cell.text_field.addTarget(self, action: #selector(tableFieldDidChange(_textField:)), for: .editingChanged)
let id:Int = Int("\(srno)\(pest_code)\(inspection_no)")!
cell.text_field.tag = id
cell.label?.text = struc_array[indexPath.item].pest
cell.label?.numberOfLines = 0
cell.label?.lineBreakMode = NSLineBreakMode.byWordWrapping
cell.layer.borderWidth = 1
return cell
}
#IBAction func submit_survey_clicked(_ sender: UIButton) {
text_field = self.table_view.viewWithTag(textfield_tag1) as! UITextField
text_field2 = self.table_view.viewWithTag(textfield_tag2) as! UITextField
}

Answer 1

This isn't going to work for a couple of reasons:
1) The table view cells are reused. So you get the cell for the first item and assign it say tag 1 but then as you scroll that cell gets reused for say cell 15 (just an example) and you assign the tag the number 15. Now the SAME textfield that had the tag 1 has the tag 15.
2) You are looking on your table view for a view with the text field tag but the text field is not a sub view of the table view it belongs to the cell instead so it will never be found.
EDIT
This is a very basic example of using a data model Basic Data Model Example
(Note: this won't stay available for ever I may delete it in a week or so)
(Also Note: this is a very basic example and not in anyway the most complete method with proper validation, etc).
EDIT
If you want to make a list of the values that have been entered for each unique entry in your data list you can use a dictionary. This is an example based on the details you have supplied in the comments:
First change the textfieldId struct so that it adopts the Hashable protocol and can therefore be used as the key in your dictionary like this:
struct textfieldId: Hashable {
var srno:Int
var pest_code:Int
var inspection_no:Int
var hashValue: Int {
return srno.hashValue ^ pest_code.hashValue ^ inspection_no.hashValue
}
static func ==(lhs: textfieldId, rhs: textfieldId) -> Bool {
return lhs.srno == rhs.srno && lhs.pest_code == rhs.pest_code && lhs.inspection_no == rhs.inspection_no
}
}
Then define a dictionary to hold the details that have been entered for each of the data items like this:
var enteredValues: [textfieldId: String] = [:]
Now whenever the text entered changes you store it in the dictionary like this:
self.enteredValues[id] = textEntered // Update for your project
and to get the information back again (for example to update the cell) do this:
cell.textField.text = self.enteredValues[id] // Update for your project.
Doing this you have created a dictionary of the values that have been entered that is unique to each data item.
If you need to clear the list you can do this:
self.enteredValues.removeAll()
or create a new instance like this:
self.enteredValues = [:]

Answer 2

You must assign indexPath.row in cell forsizeitem. Like this
func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
let cell = tableView.dequeueReusableCell(withIdentifier: "SurveyFormTableViewCell", for: indexPath) as! SurveyFormTableViewCell
var pest_code = textfield_id_value[indexPath.row].pest_code
var srno = textfield_id_value[indexPath.row].srno
var inspection_no = textfield_id_value[indexPath.row].inspection_no
cell.text_field.layer.cornerRadius = 3
cell.text_field.layer.borderWidth = 1
cell.text_field.addTarget(self, action: #selector(tableFieldDidChange(_textField:)), for: .editingChanged)
let id:Int = Int("\(srno)\(pest_code)\(inspection_no)")!
cell.text_field.tag = indexPath.row
cell.label?.text = struc_array[indexPath.item].pest
cell.label?.numberOfLines = 0
cell.label?.lineBreakMode = NSLineBreakMode.byWordWrapping
cell.layer.borderWidth = 1
return cell
}