I'm writing a query in TFS that collect all the code reviews conducted in one project, I want to gather comments that have been added. In the field selections I can't find other that "closing comments", while in the code review itself it called overall comments, I'm confused, are those two the same?
They are not the same.
Closing Comments is the comment entered by the reviewer when closing the review request. Reference name=Microsoft.VSTS.CodeReview.ClosingComment. See Code review and feedback field reference for more information.
Overall Comments are the comments added by reviewers with the response while changing/fixing the code during the review.
Related
I'm subscribed to an issue in JIRA. Whenever someone comments on it, or changes a comment of his, I get an email.
Often this results in multiple consecutive emails, when people enter a comment, and then refine it multiple times.
I'd like to tell JIRA to wait after a new comment before sending me the notification mail, which should then include all modifications to it by the time.
Is this possible?
I know this question might be better off at superuser, but the jira tag here seems by far more frequented.
If I get you right, when somebody wanna edit his comment there is a tick asking if he wanna notify all the watchers about the edit with the email message or not.
So all you can do is to ask your team to leave comments with 'notify' tick disabled
You can actually disable this autosend notifications through the API from Jira, see documentation : https://confluence.atlassian.com/jira/configuring-email-notifications-185729575.html
This is not so much of a programming question as it is about the convention. What does Reply 'Done' conventionally mean as an alternative to just Reply to a comment on a code review in Gerrit?
Does it mean I agree with you and will do it or have done it locally or does it mean I have amended the change per your suggestion? Because if I amend the change and push it into the same Gerrit review, the latest file revision on which the comments are made will overwrite the previous and all the comments from before will be gone (at least that's been my experience).
The "Done" comment means that the comment has been addressed, typically by making the changes that the reviewer suggested. One normally publishes such comments after a new patch set has been pushed so that reviewers can have a new look and hopefully approve the change. Publishing the comments before the new patch set is actually available means that you'll be interrupting reviewers before there's anything new to look at.
Comments are never "gone". I don't know what you mean by that. It's perfectly okay to publish comments made on previous patch sets. Patch sets don't replace each other.
we are going to use gerrit for the source code reviewing and code repository. as we know, for each change, anyone can review it, and give the comments in specific line of source code.
My question is, is there any state of the review comments such like (new/open/closed)? or how to check previous review findings have been fixed or still open there?
Is there any life cycle of review comment? and how to measure it? I used gerrit REST API to read it, but no such information there, or I miss something?
No there isn't. It would be useful as a new patchset will hide previous comments and it is not clear which comments have been fixed and closed.
This is not currently possible. Comments don't have a state or any kind of tracking between patch sets.
Basically you have to rely on the change owner adding a "Done" comment at the same line (on the same patch set).
Also note that if there are multiple comments on the same line, it's not possible to reply to a specific one.
We recently started using Team Foundation Server 2012 and are using the code-review feature to have other developers review code changes. It seems to work great; however, as a project lead I would like to be able to see that a given changeset has been reviewed by someone else.
For example, say Developer Bob makes changes and requests a review on those changes. This generates a shelveset for the changes and creates a code-review work item for the requested review. Developer Alice reviews the changes, makes some comments, and finishes the review. Bob incorporates Alice's suggestions and checks in the changeset.
As a project lead, I search for changesets and see that Bob checked in changeset 123. If I look at this changeset, there is an associated work item for the task Bob was working on, but no indication that the changeset was reviewed by anyone else.
If I look at code-review work items, I can find the things that have been reviewed and see the comments. This is cumbersome as I have to sift through work items and find the one that happens to be related.
How can I tell from a given changeset that it was reviewed, as well as see the review comments?
Changesets can be linked to any kind of Work Item, including Code Reviews. When you request a review on a set of pending changes, they are automatically associated to the new review Work Item. When you double click on the changeset you should be able to see under Related Work Items something like this:
In this case there were 2 reviews for this changeset, the second one was automatically there when it was requested. The first one had to be manually linked, just like the Task.
If you double click on the review item, you can see all the comments.
Tip: If you want to do a review post-checkin: go to the History view --> double click on the changeset --> Actions --> Request Review.
Tip2: It is a bit annoying that you have to manually check that each changeset has a review. If lack of review is really a problem for your team, I would suggest setting up a check-in policy.
You can make queries searching for code review work items and you will find associated changesets on the field Associated Context (Changeset id or Shelveset Name)
Inside the Code Review, you can check the changeset via the link at the top of the work item view.
Of course, there is another option that is querying directly to TFS Database (Warehouse) but it's tricky and requires access to that database and knowledge on the schema.
from work item history u can check out all the change sets ....changeset was reviewed by anyone else this functionality TFS does Not provide!
may be i have lost Something but i don't see any answer regarding to change set that is was reviewed.
but you can check the change through (history , and sort the source control by date ).
good luck!
I have an blog where anyone can comment. I would like to approve the comments before they are published. I have a boolean field named "published" and I'm unsure what to do next. Can anyone point me in the right direction?
I can imagine several features :
you need to be be notified when a comment is created. If you're not expecting too much traffic, the application can notify you by email with the ActionMailer
you need an admin page where you'll see all the comments that are waiting from your approval. Use filters to ensure that only you have access to this page.
you'll certainly need to see the comments "in situ" before approving them. The blog page should display only "published" comments for average user, but for you it should display all comments, with a button to publish the ones waiting for approval.