I am dealing with an app created by some other developer. It's a complete app and has a lot of viewControllers , variables and outlets.
I keep getting the a crash after I load too many images from a server ( 200 for example ). I only get this message in the "print area" : "App terminated due to memory issue".
I use the library "SDWebImage" for loading the images. And I tried to find a memory leak using Instruments Allocations, and Leaks. I also used Memory Graph Debugger and non of them show leaks in my app.
Yet when I pop the View Controller ( DetailVC ) , it never fires the deinit method where I have put a message to print when this happens.
I have searched a lot to no vail. I have looked at these on Stackoverflow :
App Extension "Terminated due to memory issue"
App terminated due to memory issue
Through out my search I repeatedly see that response that the View Controller must be referenced by another view controller and this View Controller (DetailVC) strongly referencing the other.
I couldn't find that to be the case, although the file for the view controller is too large and I may have missed things.
It's difficult to go through the app and look for strong and weak references as the file is really huge.
is there a simple way ( or difficult for that matter ) to find the culprit and solve my problem.
Thanks
the code is huge (95000 characters) and contains sensitive information thus is not appropriate to post here. although I can post parts of it should you ask for it.
here is the code for DetailVC viewDidLoad :
import UIKit
import FTIndicator
import Cosmos
import Firebase
import MapKit
import YouTubePlayer
//MARK:- Gallery Collection Cell
class GalleryCollectionCell:UICollectionViewCell
{
#IBOutlet weak var imgViewShop: UIImageView!
override func awakeFromNib()
{
super.awakeFromNib()
}
}
//MARK:- Service Collection Cell
class ServiceCollectionCell:UICollectionViewCell
{
#IBOutlet weak var imgViewService: UIImageView!
#IBOutlet weak var lblService: UILabel!
override func awakeFromNib()
{
super.awakeFromNib()
}
}
#IBAction func btnBackAction(_ sender: Any)
{
self.navigationController?.popViewController(animated: true)
SDImageCache.shared().clearMemory()
SDImageCache.shared().clearDisk()
}
//MARK:- Detail Main Class
class DetailVC: UIViewController, UICollectionViewDataSource, UICollectionViewDelegate, UICollectionViewDelegateFlowLayout,UITableViewDataSource, UITableViewDelegate,RateFinalDelegate, PhotoDicDelegate
{
//MARK:- Outlets
#IBOutlet weak var tblViewRate: UITableView!
#IBOutlet weak var tblViewService: UITableView!
#IBOutlet weak var lblServices: UILabel!
#IBOutlet weak var collViewGallery: UICollectionView!
//#IBOutlet weak var collViewService: UICollectionView!
#IBOutlet weak var constTableViewHeight: NSLayoutConstraint!
#IBOutlet weak var constTlbViewServiceHeight: NSLayoutConstraint!
#IBOutlet weak var imgViewShop: UIImageView!
#IBOutlet weak var lblShopName: UILabel!
//#IBOutlet weak var lblShopNameDetail: UILabel!
#IBOutlet weak var btnFavourites: UIButton!
#IBOutlet weak var viewStar: CosmosView!
#IBOutlet weak var lblReviewCount: UILabel!
#IBOutlet weak var btnShopStatus: UIButton!
#IBOutlet weak var lblShopOnline: UILabel!
// #IBOutlet weak var lblDetailText: UILabel!
#IBOutlet weak var btnShopRate: UIButton!
#IBOutlet weak var lblShopAddress: UILabel!
#IBOutlet weak var lblShopWebsite: UILabel!
#IBOutlet weak var lblShopView: UILabel!
#IBOutlet weak var lblShopOpenStatus: UILabel!
//#IBOutlet weak var lblPhone1: UILabel!
#IBOutlet weak var lblShopDetail: UILabel!
// #IBOutlet weak var btnFacebook: UIButton!
// #IBOutlet weak var btnSnapchat: UIButton!
// #IBOutlet weak var btnInstagram: UIButton!
// #IBOutlet weak var btnTwitter: UIButton!
// #IBOutlet weak var btnYoutube: UIButton!
// #IBOutlet weak var btnVivo: UIButton!
// #IBOutlet weak var btnGoogle: UIButton!
#IBOutlet weak var lblSat: UILabel!
#IBOutlet weak var lblSun: UILabel!
#IBOutlet weak var lblMon: UILabel!
#IBOutlet weak var lblTues: UILabel!
#IBOutlet weak var lblWed: UILabel!
#IBOutlet weak var lblThru: UILabel!
#IBOutlet weak var lblFri: UILabel!
#IBOutlet weak var lblSatText: UILabel!
#IBOutlet weak var lblSunText: UILabel!
#IBOutlet weak var lblMonText: UILabel!
#IBOutlet weak var lblTuesText: UILabel!
#IBOutlet weak var lblWedText: UILabel!
#IBOutlet weak var lblThruText: UILabel!
#IBOutlet weak var lblFriText: UILabel!
#IBOutlet weak var lblworkingHour: UILabel!
#IBOutlet weak var lblGallery: UILabel!
#IBOutlet weak var lblReviews: UILabel!
#IBOutlet weak var btnSeeMore: UIButton!
#IBOutlet weak var btnBack: UIButton!
#IBOutlet weak var viewMain: UIView!
#IBOutlet weak var viewSuper: UIView!
#IBOutlet weak var viewService: UIView!
#IBOutlet weak var btnWebsite: UIButton!
#IBOutlet weak var btnPhone1: UIButton!
#IBOutlet weak var btnPhone2: UIButton!
#IBOutlet weak var btnPhone3: UIButton!
#IBOutlet weak var constPhone1Height: NSLayoutConstraint!
#IBOutlet weak var constPhone2Height: NSLayoutConstraint!
#IBOutlet weak var constPhone3Height: NSLayoutConstraint!
#IBOutlet weak var constPhoneViewHeight: NSLayoutConstraint!
#IBOutlet weak var constViewScrollHeight: NSLayoutConstraint!
#IBOutlet weak var scrollSocial: UIScrollView!
// #IBOutlet weak var btnSocialLink: UIButton!
#IBOutlet weak var btnGallery: UIButton!
#IBOutlet weak var constViewServiceHeight: NSLayoutConstraint!
//For Photo Class
#IBOutlet weak var tblViewHeader: UITableView!
#IBOutlet weak var switchGallery: UISwitch!
#IBOutlet weak var constTableViewGalleryHeight: NSLayoutConstraint!
var albumListArray = [AlbumListData]()
//For Video Class
#IBOutlet weak var collectionViewVideos: UICollectionView!
#IBOutlet weak var constCollViewVideoHeight: NSLayoutConstraint!
var videoDataArray = [VideoListData]()
var switchStatus = Bool()
//MARK:- Variables
let globalConstants = GlobalConstants()
var UserData = UserDataValue()
var reviewDataArray = [Review]()
var galleryDataArray = [Gallery]()
var serviceDataArray = [Service]()
var ShopId = String()
var favStatus = String()
var ShopStatus = String()
var Latitude = String()
var Longitude = String()
var strFacebook = String()
var strInstagram = String()
var NotifyId = String()
var strTwitter = String()
var strSnapchat = String()
var strYoutube = String()
var strGoogle = String()
var strVimeo = String()
var chatStatus = Bool()
var isfirstTime = Bool()
var receiverId = ""
var receiverImage = ""
var receiverName = ""
var strWebsite = ""
var shopOwnerId = ""
var ShopUnqueId = ""
var HideChatStatus = ""
var IsChatCreateScreen = ""
var strPhone1Number = String()
var strPhone2Number = String()
var strPhone3Number = String()
var RateText = Bool()
var ShopDeliveryServiceItself = Bool()
var CitySelectedId = String()
var OneToOneChatUserData : NSDictionary = [:]
var ShopString = "1159,1160,1162,1166,1167,1176,1178,1179,1180,1182,1184,1185,1186,1187,1188,1189,1190,1191,1192,1193,1194,1199,1202,1203,1206,1208,1209,1210,1214,1216,1217,1218,1224,1225,1227,1230,1232,1233,1234,1235,1236,1238,1239,1240,1242,1243,1244,1245,1246,1247,1248,1250,1252,1253,1255,1258,1259,1263,1264,1265,1266,1269,1270,1272,1275,1276,1277,1278,1279,1280,1281,1282,1283,1285,1298,1299,1302";
//MARK:- View Life Cycle
override func viewDidLoad()
{
super.viewDidLoad()
// collViewGallery.dataSource = self
// collViewGallery.delegate = self
// collViewService.dataSource = self
// collViewService.delegate = self
btnShopStatus.setTitle(" CHAT".localiz(), for: .normal)
btnSeeMore.setTitle("See More".localiz(), for: .normal)
btnShopRate.setTitle("RATE".localiz(), for: .normal)
btnGallery.setTitle("Gallery".localiz(), for: .normal)
lblworkingHour.text = "Working Hours:".localiz()
lblServices.text = "Services".localiz()
lblGallery.text = "Gallery".localiz()
lblReviews.text = "REVIEWS".localiz()
//lblDetailText.text = "DETAILS".localiz()
lblSatText.text = "Saturday".localiz()
lblSunText.text = "Sunday".localiz()
lblMonText.text = "Monday".localiz()
lblTuesText.text = "Tuesday".localiz()
lblWedText.text = "Wednesday".localiz()
lblThruText.text = "Thursday".localiz()
lblFriText.text = "Friday".localiz()
viewStar.settings.fillMode = .precise
self.navigationItem.title = globalConstants.detailText
tblViewRate.register(UINib(nibName: "RateTableVCell", bundle: nil), forCellReuseIdentifier: "RateTableVCell")
tblViewService.register(UINib(nibName: "ServiceTableCell", bundle: nil), forCellReuseIdentifier: "ServiceTableCell")
tblViewHeader.register(UINib(nibName: "SubCatHeaderTVC", bundle: nil), forCellReuseIdentifier: "SubCatHeaderTVC")
tblViewHeader.dataSource = self
tblViewHeader.delegate = self
tblViewHeader.estimatedRowHeight = 120
tblViewHeader.rowHeight = UITableViewAutomaticDimension
tblViewService.dataSource = self
tblViewService.delegate = self
tblViewService.estimatedRowHeight = 50
tblViewService.rowHeight = UITableViewAutomaticDimension
self.constTlbViewServiceHeight.constant = 20
collectionViewVideos.register(UINib(nibName: "VideoCollViewCell", bundle: nil), forCellWithReuseIdentifier: "VideoCollViewCell")
collectionViewVideos.dataSource = self
collectionViewVideos.delegate = self
collectionViewVideos.reloadData()
switchStatus = false
switchGallery.setOn(false, animated: true)
//self.constViewServiceHeight.constant = 20
tblViewRate.dataSource = self
tblViewRate.delegate = self
tblViewRate.estimatedRowHeight = 100
tblViewRate.rowHeight = UITableViewAutomaticDimension
//self.constTableViewGalleryHeight.constant = 20
self.constTableViewHeight.constant = 20
// self.tblViewHeader.isHidden = false
// self.collectionViewVideos.isHidden = true
// self.constCollectionViewHeight.constant = 30
ShopStatus = ""
self.addBackButton()
UserDefaults.standard.set(ShopId, forKey: "ShopValueId")
UserDefaults.standard.synchronize()
isfirstTime = true
viewSuper.backgroundColor = UIColor.lightGray
viewMain.isHidden = true
if LanguageManger.shared.currentLanguage == .en
{
lblServices.textAlignment = .left
btnBack.setImage(UIImage(named:"back"), for: .normal)
}
else
{
lblServices.textAlignment = .right
btnBack.setImage(UIImage(named:"ReverseBack"), for: .normal)
}
// if KAppDelegate.isUserLoggedIn()
// {
// let userDic = UserDefaults.standard.value(forKey: "UserData") as! [String:Any]
// self.UserData = UserDataValue.init(fromDictionary: userDic)
// UserId = self.UserData.id!
// UserName = self.UserData.name!
// }
if KAppDelegate.isUserLoggedIn()
{
let userDic = UserDefaults.standard.value(forKey: "UserData") as! [String:Any]
self.UserData = UserDataValue.init(fromDictionary: userDic)
CitySelectedId = self.UserData.city!
}
else
{
if UserDefaults.standard.value(forKey: "CitySelectedId") != nil
{
CitySelectedId = UserDefaults.standard.value(forKey: "CitySelectedId") as! String
}
else
{
CitySelectedId = "1"
}
}
ShopDetailAPIMethod()
}
override func viewWillAppear(_ animated: Bool)
{
self.navigationController?.navigationBar.isHidden = true
}
override func viewWillDisappear(_ animated: Bool)
{
self.IsChatCreateScreen = ""
self.navigationController?.navigationBar.isHidden = false
}
// override var preferredStatusBarStyle: UIStatusBarStyle
// {
// return .default
// }
//MARK:- Photo Dic Delegate Method
//MARK:- CreateNewChat Method
}
and this is how instantiate the DetailVC :
#objc func methodOfNotification(notification: Notification)
{
if UserDefaults.standard.value(forKey: "ShopValueId") != nil
{
let detailVC = self.storyboard?.instantiateViewController(withIdentifier: "DetailVC") as! DetailVC
detailVC.ShopId = UserDefaults.standard.value(forKey: "ShopValueId") as! String
self.navigationController?.pushViewController(detailVC, animated: true)
}
}
Here is the scenario:
I am within subCategoryVC I click on a collectionView cell, this instantiates the DetailVC. within the DetailVC I click on the seeAll button to load the images in the collection view ( this is done using SDWebImage using this method :
l
let imageStringURL = ShopDetailData.coverImage!
imgViewShop.sd_setShowActivityIndicatorView(true)
imgViewShop.sd_setIndicatorStyle(.gray)
imgViewShop.sd_setImage(with: NSURL(string:imageStringURL)! as URL, placeholderImage:UIImage(named:"noimage") , options: .refreshCached, completed: nil)
when I click on the btnBack(back button) and I pop the view controller using navigationContrller.popViewController() this is where the deinit message should be printed in the "print area" but this never happens.
furthermore when I open 2 or 3 detailVC's and push the seeAll button the app crashes and "print area" shows
"app terminated due to memory issue".
I just used Instruments to check for memory leak. there is one leak as it turns out and with these details :
leaked object = _swiftStringStorage<UInt16>
responsible library = libswiftCore.dylib
responsible frame = swift_slowAlloc
The Apps allows limited memory. I guess after 800mb , app is shut down with memory issue. This is not a true way that is downloaded 200 images for one controller but you can use with tableview with dequereuaseble and sdwebimage or kingfisher. Also you can use thumbnail images because you dont need to show 1 mb image in imageview , this is not unnecessary.
You probably have a retain-cycle. This means that some of the subviews of your ViewController has a strong reference to the ViewController itself or to another object that has the strong reference to the ViewController. When this happens, even if you pop the ViewController it won't be destroyed until the subview is destroyed, which will never be destroyed while the ViewController exists.
If this is your case, the solution would be searching for this circular reference in your subviews and put a "weak" in the variable that references the ViewController. Searching for places where you assign "self" to a variable or where you use "self" inside an enclosure could help.
In my app I currently have 9 labels on my storyboard, each showing a different value. (The values are stored in an array). As far as I know, each label has to be connected from the storyboard to the viewcontroller file separately, which makes my code look like this:
#IBOutlet weak var xValue: UILabel!
#IBOutlet weak var yValue: UILabel!
#IBOutlet weak var zValue: UILabel!
#IBOutlet weak var maxXValue: UILabel!
#IBOutlet weak var maxYValue: UILabel!
#IBOutlet weak var maxZValue: UILabel!
#IBOutlet weak var minXValue: UILabel!
#IBOutlet weak var minYValue: UILabel!
#IBOutlet weak var minZValue: UILabel!
And to set the values, I need to manually do:
xValue.text = arr[0]
yValue.text = arr[1]
...
minYValue = arr[7]
minZValue = arr[8]
Is there a way to connect multiple labels from the storyboard into an array so that I can simply do something like:
for i in 0...8 {
labelArray[i] = arr[i]
}
As rmaddy mentioned in a comment you can use an outlet collection:
#IBOutlet private var labels: [UILabel]!
Then in your storyboard labels will show up under Outlet Collections when right-clicking your ViewController, and you can link multiple labels:
You can put all the UILabel into an array, like this:
let labelArray = [xValue, yValue, zValue]
for i in 0..<labelArray.count-1{
labelArray[i] = arr[i]
}
I believe I have to clean up my code a bit, since Xcode for the first time started to freeze at "indexing" and I can't run my project. I think it's easy to do, but I don't know what way is the best. Got 36 UIImageViews...
#IBOutlet var Image1: UIImageView!
#IBOutlet var Image2: UIImageView!
#IBOutlet var Image3: UIImageView!
#IBOutlet var Image4: UIImageView!
#IBOutlet var Image5: UIImageView!
#IBOutlet var Image6: UIImageView!
#IBOutlet var Image7: UIImageView!
#IBOutlet var Image8: UIImageView!
#IBOutlet var Image9: UIImageView!
#IBOutlet var Image10: UIImageView!
#IBOutlet var Image11: UIImageView!
#IBOutlet var Image12: UIImageView!
#IBOutlet var Image13: UIImageView!
#IBOutlet var Image14: UIImageView!
#IBOutlet var Image15: UIImageView!
#IBOutlet var Image16: UIImageView!
#IBOutlet var Image17: UIImageView!
#IBOutlet var Image18: UIImageView!
#IBOutlet var Image19: UIImageView!
#IBOutlet var Image20: UIImageView!
#IBOutlet var Image21: UIImageView!
#IBOutlet var Image22: UIImageView!
#IBOutlet var Image23: UIImageView!
#IBOutlet var Image24: UIImageView!
#IBOutlet var Image25: UIImageView!
#IBOutlet var Image26: UIImageView!
#IBOutlet var Image27: UIImageView!
#IBOutlet var Image28: UIImageView!
#IBOutlet var Image29: UIImageView!
#IBOutlet var Image30: UIImageView!
#IBOutlet var Image31: UIImageView!
#IBOutlet var Image32: UIImageView!
#IBOutlet var Image33: UIImageView!
#IBOutlet var Image34: UIImageView!
#IBOutlet var Image35: UIImageView!
#IBOutlet var Image36: UIImageView!
override func viewDidLoad() {
let images = (1...6).map { UIImage(named: "Owl\($0)") }
let imageViewsArray = [Image1, Image2, Image3, Image4, Image5, Image6, Image7, Image8, Image9, Image10, Image11, Image12, Image13, Image14, Image15, Image16, Image17, Image18, Image19, Image20, Image21, Image22, Image23, Image24, Image25, Image26, Image27, Image28, Image29, Image30, Image31, Image32, Image33, Image34, Image35, Image36]
for view in imageViewsArray {
let randomIndex = Int(arc4random_uniform(UInt32(images.count)))
view.image = images[randomIndex]
}
}
Could I make an IBOutlet for all 36 images together? Or something like this? :-)
Info about the code in ViewDidLoad() here.
As #FruitAddict said, an UICollectionView may be useful, depending of what you want to display of course. But if it doesn't fit your needs, you can still use an Outlet connection instead of an outlet :
Thus you can access every labels directly from labelCollection, which is an explicit unwrapped array of UILabel.
Also, in the gif, the second label is added to the collection outlet by draging it to the already existing outlet. The outlet is not replaced (as in a regular object), but instead the new label is added to the array.
EDIT :
As #nhgrif pointed out, don't rely on the order of the objects within the outlet collection :
It's important to note that while many times the order within the outlet collection may coincidentally coincide with the order you dragged them in, Apple makes no guarantees about this and the order within the collection should not be relied upon.
You should consider this array as a set.
I would like my UIButtons to interact with each other - (With the corresponding button)
First set of buttons;
#IBOutlet var P1button1: UIButton!
#IBOutlet var P1button2: UIButton!
#IBOutlet var P1button3: UIButton!
#IBOutlet var P1button4: UIButton!
#IBOutlet var P1button5: UIButton!
#IBOutlet var P1button6: UIButton!
#IBOutlet var P1button7: UIButton!
#IBOutlet var P1button8: UIButton!
#IBOutlet var P1button9: UIButton!
Second set of buttons;
#IBOutlet var P2button1: UIButton!
#IBOutlet var P2button2: UIButton!
#IBOutlet var P2button3: UIButton!
#IBOutlet var P2button4: UIButton!
#IBOutlet var P2button5: UIButton!
#IBOutlet var P2button6: UIButton!
#IBOutlet var P2button7: UIButton!
#IBOutlet var P2button8: UIButton!
#IBOutlet var P2button9: UIButton!
In my code I apply an Image to one random P1button from an Array;
var buttons = [P1button1, P1button2, P1button3, P1button4, P1button5, P1button6, P1button7, P1button8, P1button9]
buttons.shuffleInPlace()
buttons[0].setImage(UIImage(named: "Green"), forState: .Normal)
Now, I want to know if there is a way to make the P2buttons "co-operate" with the P1buttons. Meaning that if an Image is applied to P1button1 then P2button1 is set to the same image! (and so forth for all buttons)
Example;
P2button1.setImage = UIImage(P1button1)
This obviously doesn't work but hopefully gives you a clue about what I'm trying to achieve.
One possible approach would be by subclassing UIButton. Perhaps something like this...
class TwinButton {
weak var twin: TwinButton?
}
Now, in your viewDidLoad method, link up all of the twins.
p1button1.twin = p2button1
p2button1.twin = p1button1
Now, I'd write a set of methods that have some "with twin" semantics...
extension TwinButton {
setWithTwin(title: String)
setWithTwin(backgroundImage: UIImage)
}
and those methods simply set the value on self and twin.
Can someone help me figure out why I can't fix this error in Swift using Xcode6? I'm trying to initialize all my buttons so they aren't nil and it's telling me I'm not declaring something when I thought I was. Any suggestions? The required init method line is giving me the error.
import UIKit
class ViewController: UIViewController {
#IBOutlet weak var displayLabel: UILabel!
#IBOutlet weak var buttonOne: UIButton!
#IBOutlet weak var buttonTwo: UIButton!
#IBOutlet weak var buttonThree: UIButton!
#IBOutlet weak var buttonClear: UIButton!
#IBOutlet weak var buttonFour: UIButton!
#IBOutlet weak var buttonFive: UIButton!
#IBOutlet weak var buttonSix: UIButton!
#IBOutlet weak var buttonX: UIButton!
#IBOutlet weak var buttonSeven: UIButton!
#IBOutlet weak var buttonEight: UIButton!
#IBOutlet weak var buttonNine: UIButton!
#IBOutlet weak var buttonDiv: UIButton!
#IBOutlet weak var buttonPlus: UIButton!
#IBOutlet weak var buttonZero: UIButton!
#IBOutlet weak var buttonMin: UIButton!
#IBOutlet weak var buttonEq: UIButton!
#IBOutlet weak var buttonSet: UIButton!
var userIsTyping: Bool = false
required init(coder aDecoder: NSCoder) {
displayLabel = UILabel()
buttonOne = UIButton()
buttonTwo = UIButton()
buttonThree = UIButton()
buttonFour = UIButton()
buttonFive = UIButton()
buttonSix = UIButton()
buttonSeven = UIButton()
buttonEight = UIButton()
buttonNine = UIButton()
buttonZero = UIButton()
buttonClear = UIButton()
buttonX = UIButton()
buttonPlus = UIButton()
buttonDiv = UIButton()
buttonMin = UIButton()
buttonEq = UIButton()
buttonSet = UIButton()
super.init(coder: aDecoder)
}
From Apple documentation:
An outlet is a property of an object that references another object. The reference is archived through Interface Builder. The connections between the containing object and its outlets are reestablished every time the containing object is unarchived from its nib file. The containing object holds an outlet declared as a property with the type qualifier of IBOutlet and a weak option.
So, you should not instantiate a #IBOutlet object, since they are meant to be connected to a UI object on storyboard or .nib file.
You've said that you are doing this to avoid nil pointer. When does that happen?