I have a method called calculation_of_total_cost in model Tippy
It's running into problems being called in index.html.erb via tippies views directory.
This is the error I receive: undefined method*' for nil:NilClass`
I have googled it, and now understand that it is the result of the one of the variables being nil.
How do I resolve this, i.e, how do I make the method work in index.html.erb? This is index view that I am calling it from, so I need an instance method, not class, right?
Also, addendum: this same method works fine in show.html.erb
show.html.erb
<br/><br/>
<h1 class="text-center">Your Total Cost</h1>
<br/><br />
<table class="table table-striped">
<tr>
<td>
Cost of Your Meal:
</td>
<td>
<%= humanized_money_with_symbol #tippy.cost %>
</td>
</tr>
<tr>
<td>
Tip You Picked:
</td>
<td>
<%= number_to_percentage(#tippy.tip * 100, format: "%n%", precision: 0) %>
</td>
</tr>
<tr>
<td>
The Total Cost:
</td>
<td>
<%= humanized_money_with_symbol #tippy.calculation_of_total_cost %>
</td>
</tr>
</table>
<%= link_to 'New Tippy', new_tippy_path %>
<%= link_to "Index", tippies_path %>
Here is the Tippy model:
class Tippy < ApplicationRecord
validates :tip, presence: true
validates :cost, presence: true
#monetize :tip_cents
monetize :cost_cents, :numericality => {:greater_than => 0}
TIP_CHOICES = { "10%" => ".10", "20%" => ".20", "30%" => ".30", "40%" => ".40", "50%" => ".50",
"60%" => ".60", "70%" => ".70", "80%" => ".80", "90%" => ".90" }
def calculation_of_total_cost
cost + (tip * cost)
end
end
Here is the index.html.erb file
<p id="notice"><%= notice %></p>
<h1>Tippies</h1>
<table>
<thead>
<tr>
<th>Tip</th>
<th>Cost</th>
<th>Total</th>
<th colspan="3"></th>
</tr>
</thead>
<tbody>
<% #tippies.each do |tippy| %>
<tr>
<td><%= tippy.tip %></td>
<td><%= tippy.cost %></td>
<td><%= tippy.calculation_of_total_cost %></td>
<td><%= link_to 'Show', tippy %></td>
<td><%= link_to 'Edit', edit_tippy_path(tippy) %></td>
<td><%= link_to 'Destroy', tippy, method: :delete, data: { confirm: 'Are you sure?' } %></td>
</tr>
<% end %>
</tbody>
</table>
<br>
<%= link_to 'New Tippy', new_tippy_path %>
Tippy Controller
class TippiesController < ApplicationController
#before_action :set_tippy, only: [:show, :edit, :update, :destroy]
# GET /tippies
# GET /tippies.json
def index
#tippies = Tippy.all
end
# GET /tippies/1
# GET /tippies/1.json
def show
##calculation_of_total_cost
end
# GET /tippies/new
def new
#tippy = Tippy.new
end
# GET /tippies/1/edit
def edit
end
# POST /tippies
# POST /tippies.json
def create
#tippy = Tippy.new(tippy_params)
respond_to do |format|
if #tippy.save
format.html { redirect_to #tippy, notice: 'Tippy was successfully created.' }
format.json { render :show, status: :created, location: #tippy }
else
format.html { render :new }
format.json { render json: #tippy.errors, status: :unprocessable_entity }
end
end
end
# PATCH/PUT /tippies/1
# PATCH/PUT /tippies/1.json
def update
respond_to do |format|
if #tippy.update(tippy_params)
format.html { redirect_to #tippy, notice: 'Tippy was successfully updated.' }
format.json { render :show, status: :ok, location: #tippy }
else
format.html { render :edit }
format.json { render json: #tippy.errors, status: :unprocessable_entity }
end
end
end
# DELETE /tippies/1
# DELETE /tippies/1.json
def destroy
#tippy.destroy
respond_to do |format|
format.html { redirect_to tippies_url, notice: 'Tippy was successfully destroyed.' }
format.json { head :no_content }
end
end
private
# Use callbacks to share common setup or constraints between actions.
def set_tippy
#tippy = Tippy.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.
def tippy_params
params.require(:tippy).permit(:tip, :cost)
end
end
To solve this problem you need to set a binding.pry or a breakpoint at this line of index.html.erb, so that we can understand in the loop you are executing why tippy is getting value of nil.
You need to install pry gem.
Please also share the values of #tippies and the details of the other variable in the loop that fails, because tippy=nil.
An alternative for pry is just printing the value of the variable in the log with puts tippy.calculation_of_total_cost.
Right now I am guess is that #tippies which includes all #tippy in your tippies table, could have one field that has calculation of total cost = nil. To verifiy this you should check with the debug the value of tippy and of tippy.calculation_of_total_cost in the index.html.erb view.
<% #tippies.each do |tippy| %>
<tr>
<% binding.pry %>
<td><%= tippy.tip %></td>
<td><%= tippy.cost %></td>
<td><%= tippy.calculation_of_total_cost %></td>
<td><%= link_to 'Show', tippy %></td>
<td><%= link_to 'Edit', edit_tippy_path(tippy) %></td>
<td><%= link_to 'Destroy', tippy, method: :delete, data: { confirm: 'Are you sure?' } %></td>
</tr>
<% end %>
also it is a good idea to inspect show.html.erb as there it is working.
def calculation_of_total_cost
cost + (tip * cost)
end
Related
project_site model has one attribute submission_status. i want to set that status from index#action for there corresponding row. i want on submit button click on each row to change there correspong submission_status to true. how can i do this in rails 5.
project_sites_controller.rb
def index
#project_sites = current_user.project_sites
end
def new
#project_site = current_user.project_sites.build
end
def create
#project_site = current_user.project_sites.build(project_site_params)
#users = current_user.director_id
#projects = Project.where(user_id: #users)
respond_to do |format|
if #project_site.save
format.html { redirect_to project_sites_url, notice: 'Attendance was successfully Uploaded.' }
format.json { render :show, status: :created, location: #project_site }
else
format.html { render :new }
format.json { render json: #project_site.errors, status: :unprocessable_entity }
end
end
end
def update
#users = current_user.director_id
#projects = Project.where(user_id: #users)
respond_to do |format|
if #project_site.update(project_site_params)
format.html { redirect_to project_sites_url, notice: 'Attendance was successfully updated.' }
format.json { render :show, status: :ok, location: #project_site }
else
format.html { render :edit }
format.json { render json: #project_site.errors, status: :unprocessable_entity }
end
end
end
index.html.erb
<table>
<thead>
<tr>
<th>Uploaded Date</th>
<th>Attendance File</th>
<th>Submit Attendance</th>
</tr>
</thead>
<tbody>
<% #project_sites.each do |project_site| %>
<tr>
<td><%= project_site.created_at.strftime('%d-%m-%Y') %></td>
<td><%= link_to "View Attendance", project_site.attendance.url, :class => "fi-page-export-csv" %></td>
<td>
<%= form_for ProjectSite.new do |f| %>
<%#f.hidden_field :project_site_id, value: project_site.id%>
<%=f.hidden_field :submission_status, value: true%>
<div>
<%= f.submit 'Submit', :class => 'button primary small float-right' %>
</div>
<% end %>
</tr>
<% end %>
</tbody>
</table>
add a route for an action which set status
#routes.rb
resources :project_sites do
put :set_submission_status, on: :member
end
define action which set status
#submission_status_controller.rb
def set_submission_status
#project_site = ProjectSite.find(params[:id])
#project_site.update(submission_status: true)
redirect_to project_sites_path
end
replace form_for with following link
#view
= link_to set_submission_status_project_site_path(project_site), method: :put
You have to pass the id of project_site for which you want to update the submission_status and on the controller updates the same project_site(id pass as hidden field), for this you need write **ajax** call
<table>
<thead>
<tr>
<th>Uploaded Date</th>
<th>Attendance File</th>
<th>Submit Attendance</th>
</tr>
</thead>
<tbody>
<% #project_sites.each do |project_site| %>
<tr>
<td><%= project_site.created_at.strftime('%d-%m-%Y') %></td>
<td><%= link_to "View Attendance", project_site.attendance.url, :class => "fi-page-export-csv" %></td>
<td>
<%= form_for ProjectSite.new do |f| %>
<%#f.hidden_field :project_site_id, value: project_site.id%>
<%=f.hidden_field :submission_status, value: true%>
<%= f.hidden_field :project_site_id, project_site.id%>
<div>
<%= f.submit 'Submit', :class => 'button primary small float-right' %>
</div>
<% end %>
</tr>
<% end %>
</tbody>
</table>
I'm new to ruby on rails and I'm having trouble with importing a csv file with data to db. I have been looking around but most of the similar questions on here did not solve this issue.
Problem: param is missing or the value is empty: incident_datum
I understand that this issue is caused by the action controller due to the params.require( but removing it doesn't help because the csv file just gets temporarily uploaded but no data gets extracted from it.
Here are the supporting files =>
Controller:
class IncidentDataController < ApplicationController
before_action :set_incident_datum, only: [:show, :edit, :update, :destroy]
# GET /incident_data
# GET /incident_data.json
def index
#incident_data = IncidentDatum.all
#incident_data_first_20 = IncidentDatum.first(20)
end
def import
IncidentDatum.import(params[:file])
if #IncidentDatum.save
# after import, redirect and let us know the method worked!
redirect_to root_url, notice: "Incident Data Imported!"
else
render :new
end
end
# GET /incident_data/1
# GET /incident_data/1.json
def show
#distinct_number = IncidentDatum.distinct.pluck(:number).sort
end
# GET /incident_data/new
def new
#incident_datum = IncidentDatum.new
end
# GET /incident_data/1/edit
def edit
end
# POST /incident_data
# POST /incident_data.json
def create
#incident_datum = IncidentDatum.new(incident_datum_params)
respond_to do |format|
if #incident_datum.save
format.html { redirect_to #incident_datum, notice: 'Incident datum was successfully created.' }
format.json { render :show, status: :created, location: #incident_datum }
else
format.html { render :new }
format.json { render json: #incident_datum.errors, status: :unprocessable_entity }
end
end
end
# PATCH/PUT /incident_data/1
# PATCH/PUT /incident_data/1.json
def update
respond_to do |format|
if #incident_datum.update(incident_datum_params)
format.html { redirect_to #incident_datum, notice: 'Incident datum was successfully updated.' }
format.json { render :show, status: :ok, location: #incident_datum }
else
format.html { render :edit }
format.json { render json: #incident_datum.errors, status: :unprocessable_entity }
end
end
end
# DELETE /incident_data/1
# DELETE /incident_data/1.json
def destroy
#incident_datum.destroy
respond_to do |format|
format.html { redirect_to incident_data_url, notice: 'Incident datum was successfully destroyed.' }
format.json { head :no_content }
end
end
private
# Use callbacks to share common setup or constraints between actions.
def set_incident_datum
#incident_datum = IncidentDatum.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.
def incident_datum_params
params.require(:incident_datum).permit(
:number,
:priority,
:state,
:description,
:short_description1,
:ticket_type,
:task_type,
:opened,
:closed,
:initial_contact,
:configuration_item,
:environment,
:assignment_group,
:reassignment_count,
:department,
:name,
:problem,
:short_description2)
#MG what to do with '.require(:incident_datum)' after params?
end
end
Import:
<div id="import" class="well" style="display:inline-block;width:100%">
<h3 style="margin-top:0px;">Import Data</h3>
<div id="" style="float:left; flex:1;">
<%= form_tag incident_data_path, multipart: true do %>
<%= file_field_tag :file, :style=>'width: 600px;' %>
</div>
<div style="float:right; flex:1;">
<%= submit_tag "Import CSV" %>
</div>
<% end %>
</div>
<a class="btn btn-info" href="/incident_data/">Incident Data</a>
Index.html.erb
<p id="notice"><%= notice %></p>
<h1 style="float:left;">Incident Data</h1><br />
<div class="btn btn-info" style="float:right;">
<%= link_to 'New Incident Datum', new_incident_datum_path%>
</div><br /><br /><br />
<div style="overflow-y:auto;height:600px;">
<%= flash[:notice] %> <!-- Why was this commented out? </th-->
<table class="table table-striped">
<thead>
<tr>
<th>Number</th>
<th>Priority</th>
<th>State</th>
<th>Description</th>
<th>Short description1</th> <!-- Why was this commented out? </th-->
<th>Ticket type</th>
<th>Task type</th>
<th style="display:none">Opened</th>
<th style="display:none">Closed</th>
<th style="display:none">Initial contact</th>
<th>Configuration item</th>
<th>Environment</th>
<th>Assignment group</th>
<th>Reassignment count</th>
<th>Department</th>
<th>Name</th>
<th>Problem</th>
<th>Short description2</th> <!-- Why was this commented out? </th-->
<th colspan="3"></th>
</tr>
</thead>
<!----------------------------------------------------------------------------
[] BREADCRUMS - SHOWS WHERE WE ARE IN THE PAGE
[] PAGEINATOR - GOOGLE THING THAT ALLOWS YOU TO CHOOSE BETWEEN MULTIPLE PAGES //look on main_page.html
----------------------------------------------------------------------------->
<tbody id="descList">
<% #incident_data_first_20.each do |incident_datum| %>
<tr>
<td><%= incident_datum.number %></td>
<td><%= incident_datum.priority %></td>
<td><%= incident_datum.state %></td>
<td data-toggle="modal" data-target="#descModal"><%= incident_datum.short_description1 %></td>
<td><%= incident_datum.ticket_type %></td>
<td><%= incident_datum.task_type %></td>
<td style="display:none"><%= incident_datum.opened %></td>
<td style="display:none"><%= incident_datum.closed %></td>
<td style="display:none"><%= incident_datum.initial_contact %></td>
<td><%= incident_datum.configuration_item %></td>
<td><%= incident_datum.environment %></td>
<td><%= incident_datum.assignment_group %></td>
<td><%= incident_datum.reassignment_count %></td>
<td><%= incident_datum.department %></td>
<td><%= incident_datum.name %></td>
<td><%= incident_datum.problem %></td>
<td style="display:none"><%= incident_datum.description %></td>
<td style="display:none"><%= incident_datum.short_description2 %></td>
<td><%= link_to 'Show', incident_datum %></td>
<td><%= link_to 'Edit', edit_incident_datum_path(incident_datum) %></td>
<td><%= link_to 'Destroy', incident_datum, method: :destroy, data: { confirm: 'Are you sure?' } %></td>
</tr>
<% end %>
</tbody>
</table>
</div>
<%= render partial: "modal", locals: {zone: #zone} %>
routes:
Rails.application.routes.draw do
#resources :incident_data
# INDEX
#root to: 'analysis#main_page'
# Database Tables
resources :incident_data do
collection { post :import }
end
root to: 'analysis#main_page' #MG
# ADDITIONAL PAGES
get 'analysis/main_page'
get 'analysis/new_tile'
get 'analysis/ticket_identification'
get 'analysis/detailed_view'
get 'analysis/import_data'
get 'analysis/test'
# For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
end
Console:
Processing by IncidentDataController#create as HTML
Parameters: {"utf8"=>"✓", "authenticity_token"=>"lBXX210GVPazui46U8rATpzrXCMJw8DAqb7Hc3WWK2uTU3WGojClRU7+ZKkakCjUblweOV7UpM+FiIvRSNzSng==", "file"=>#<ActionDispatch::Http::UploadedFile:0x00000002829388 #tempfile=#<Tempfile:/tmp/RackMultipart20180110-11292-jzqi2l.csv>, #original_filename="incident_datum.csv", #content_type="application/vnd.ms-excel", #headers="Content-Disposition: form-data; name=\"file\"; filename=\"incident_datum.csv\"\r\nContent-Type: application/vnd.ms-excel\r\n">, "commit"=>"Import CSV"}
Completed 400 Bad Request in 2ms (ActiveRecord: 0.0ms)
ActionController::ParameterMissing (param is missing or the value is empty: incident_datum):
app/controllers/incident_data_controller.rb:84:in `incident_datum_params'
app/controllers/incident_data_controller.rb:39:in `create'
^C- Gracefully stopping, waiting for requests to finish
=== puma shutdown: 2018-01-10 14:20:33 +0000 ===
- Goodbye!
Exiting
Thank you!
I think your problem is your Form (if you want keep rails convention), you have to create a IncidentDatum element and create a form for this element like:
<%= form_for #incident_data , multipart: true do %>
...
With this you create a form like incident_datum : { file: .... }
This format you spec in the def incident_datum_params method
params.require(:incident_datum).permit( :number , ....
Also you need to add file to permit
params.require(:incident_datum).permit( :number , :file , ....
You can see the format of your post in your console browser network tab and also in the log you post in the question:
Processing by IncidentDataController#create as HTML Parameters:
{"utf8"=>"✓",
"authenticity_token"=>"lBXX210GVPazui46U8rATpzrXCMJw8DAqb7Hc3WWK2uTU3WGojClRU7+ZKkakCjUblweOV7UpM+FiIvRSNzSng==",
"file"=>#,
#original_filename="incident_datum.csv",
#content_type="application/vnd.ms-excel",
#headers="Content-Disposition: form-data; name=\"file\";
filename=\"incident_datum.csv\"\r\nContent-Type:
application/vnd.ms-excel\r\n">, "commit"=>"Import CSV"} Completed 400
Bad Request in 2ms (ActiveRecord: 0.0ms)
You can see file direct in the params ( no inside incident_data incident_data: { fiel: .... } )
Hi guys when iam trying to pull image using image tag its giving nil is not a valid asset source ive image file in my assests , strangely this problem is only occuring when iam trying use decorator pattern else without it image is being properly displaye ,Iam fairly new to this can any of the experts shred some light what am i doing wrong ?
Thanks
require 'shake_decorator'
class ShakesController < ApplicationController
before_action :set_shake, only: [:show, :edit, :update, :destroy]
# GET /shakes
# GET /shakes.json
def index
#shakes = Shake.all
end
# GET /shakes/1
# GET /shakes/1.json
def show
end
# GET /shakes/new
def new
#shake = Shake.new
end
# GET /shakes/1/edit
def edit
end
# POST /shakes
# POST /shakes.json
def create
#shake = Shake.new()
#shake.Name=params[:shake][:Name]
#shake.Cost=params[:shake][:Cost]
#shake.Calories=params[:shake][:Calories]
# create an instance/object of a BasicCar
myShake=BasicShake.new(#shake.Cost,#shake.Calories)
#add the extra features to the new car
if params[:shake][:caramel].to_s.length > 0 then
myShake = CaramelDecorator.new(myShake)
end
if params[:shake][:pbutter].to_s.length > 0 then
myShake = PeanutbutterDecorator.new(myShake)
end
if params[:shake][:cream].to_s.length > 0 then
myShake = CreamDecorator.new(myShake)
end
#populate the cost and the description details
#shake.Cost = myShake.cost
#shake.description = myShake.details
#retrieve the instance/object of the MyLogger class
respond_to do |format|
if #shake.save
format.html { redirect_to #shake, notice: 'Shake was successfully created.' }
format.json { render :show, status: :created, location: #shake }
else
format.html { render :new }
format.json { render json: #shake.errors, status: :unprocessable_entity }
end
end
end
# DELETE /shakes/1
# DELETE /shakes/1.json
def destroy
#shake.destroy
respond_to do |format|
format.html { redirect_to shakes_url, notice: 'Shake was successfully destroyed.' }
format.json { head :no_content }
end
end
private
# Use callbacks to share common setup or constraints between actions.
def set_shake
#shake = Shake.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.
def shake_params
params.require(:shake).permit(:Name, :Cost, :Calories, :image_url)
end
end
<p id="notice"><%= notice %></p>
<h1>Shakes</h1>
<table border="2">
<thead>
<tr>
<th>Name</th>
<th>Cost</th>
<th>Calories</th>
<th>Image url</th>
<th colspan="3"></th>
</tr>
</thead>
<tbody>
<% #shakes.each do |shake| %>
<tr>
<td><%= shake.Name %></td>
<td><%= shake.Cost %></td>
<td><%= shake.Calories %></td>
<td><%= image_tag(shake.image_url, :class => 'list_image' ,:style => "height:100px") %></td>
<td><%= link_to 'Show', shake %></td>
<td><%= link_to 'Edit', edit_shake_path(shake) %></td>
<td><%= link_to 'Destroy', shake, method: :delete, data: { confirm: 'Are you sure?' } %></td>
</tr>
<% end %>
</tbody>
</table>
<br>
<%= link_to 'New Shake', new_shake_path %>
I generated a scaffold called rounds. Here is what my JapasController looks like:
class JapasController < ApplicationController
before_action :set_japa, only: [:show, :edit, :update, :destroy]
before_action :correct_user, only: [:edit, :update, :destroy]
before_action :authenticate_user!, except: [:index, :show]
def index
#japas = Japa.all
#users = User.all
end
def show
end
def new
#japa = current_user.japas.build
end
def edit
end
def create
#japa = current_user.japas.build(japa_params)
respond_to do |format|
if #japa.save
format.html { redirect_to #japa, notice: 'Japa was successfully created.' }
format.json { render :show, status: :created, location: #japa }
else
format.html { render :new }
format.json { render json: #japa.errors, status: :unprocessable_entity }
end
end
end
def update
respond_to do |format|
if #japa.update(japa_params)
format.html { redirect_to #japa, notice: 'Japa was successfully updated.' }
format.json { render :show, status: :ok, location: #japa }
else
format.html { render :edit }
format.json { render json: #japa.errors, status: :unprocessable_entity }
end
end
end
def destroy
#japa.destroy
respond_to do |format|
format.html { redirect_to japas_url, notice: 'Japa was successfully destroyed.' }
format.json { head :no_content }
end
end
private
# Use callbacks to share common setup or constraints between actions.
def set_japa
#japa = Japa.find(params[:id])
end
def correct_user
#japa = current_user.japas.find_by(id: params[:id])
redirect_to japas_path, notice: "Not authorized to edit this japacount" if #japa.nil?
end
# Never trust parameters from the scary internet, only allow the white list through.
def japa_params
params.require(:japa).permit(:rounds, :comment, :user_id)
end
end
Japa Model:
class Japa < ActiveRecord::Base
belongs_to :user
end
User Model:
class User < ActiveRecord::Base
devise :database_authenticatable, :registerable,
:recoverable, :rememberable, :trackable, :validatable
has_many :japas
end
Here is my index template for Japas:
<p id="notice"><%= notice %></p>
<center>
<h1>Listing Japa</h1>
<table class = 'table table-hover' style = 'width:700px;'>
<thead>
<tr>
<th>Time</th>
<th>Rounds</th>
<th>Goal</th>
<th colspan="3"></th>
</tr>
</thead>
<tbody>
<% #users.each do |user| %>
<tr>
<td><%= user.japas.created_at %></td>
<td><%= user.japas.rounds %></td>
<td> / 16 </td>
<td><%= link_to 'Show', japa %></td>
<% if japa.user == current_user %>
<td><%= link_to 'Edit', edit_japa_path(japa) %></td>
<td><%= link_to 'Destroy', japa, method: :delete, data: { confirm: 'Are you sure?' } %></td>
<%end%>
</tr>
<tr>
<td>Total Sum</td>
</tr>
<% end %>
</tbody>
</table>
</center>
<br>
<% if user_signed_in? %>
<%= link_to 'New Japa', new_japa_path %>
<%end%>
Here is my error message when I load: http://localhost:3000/japas.
NoMethodError in Japas#index
Showing /Users/vvd/Desktop/japacounter/app/views/japas/index.html.erb where line #20 raised:
undefined method `created_at' for #<User:0x007f981a4536e8>
Extracted source (around line #20):
<% #users.each do |user| %>
<tr>
<td><%= user.japas.created_at %></td>
<td><%= user.japas.rounds %></td>
<td> / 16 </td>
This is a picture of the error page I am receiving:
Based on your requirements on comments you can try this on.
You have to change your controller action as following for getting japas for the current_user
def index
#japas = Japa.where(user_id: current_user.id)
end
And in view iterate with #japas, as following
<% #japas.each do |japa| %>
<tr>
<td><%= japa.created_at %></td>
<td><%= japa.rounds %></td>
</tr>
<% end %>
You can not call an attribute/method like created_at with an active record associations collection. User has many Japa, so you can re-write you view as following in error area with rest of your code. Just iterate within user.japas.
<% #users.each do |user| %>
<% user.japas.each do |japa| %>
<tr>
<td><%= japa.created_at %></td>
<td><%= japa.rounds %></td>
</tr>
<% end %>
<% end %>
While I was working trying to code my views, I noticed that my code that was previously rendering on the index view is now only showing the first two lines of code on my local server, and I don't understand why.
Here is my index.html.erb code:
<h1>All Bookmarks</h1>
<%= link_to 'Create a New Bookmark', new_bookmark_path %>
<table>
<thead>
<tr>
<th></th>
<th></th>
<th></th>
<th></th>
</tr>
</thead>
<div class="row">
<div class="col-md-8">
<tbody>
<% #bookmarks.each do |bookmark| %>
<div class="media">
<div class="media-body">
<h4 class="media-heading">
<tr>
<td><%= link_to bookmark.url, "http://#{bookmark.url}" %></td>
<td><%= link_to 'Show', bookmark %></td>
<td><%= link_to 'Edit', edit_bookmark_path(bookmark) %></td>
<td><%= link_to 'Destroy', bookmark, method: :delete, data: { confirm: 'Are you sure?' } %></td>
</tr>
<% end %>
</tbody>
</table>
And here is my bookmark controller code:
class BookmarksController < ApplicationController
before_action :set_bookmark, only: [:show, :edit, :update, :destroy]
def index
#bookmarks = Bookmark.all
end
def show
end
def new
#bookmark = Bookmark.new
end
def edit
end
def create
bookmark = Bookmark.where(url: params[:bookmark][:url]).first
#bookmark = bookmark.present? ? bookmark : Bookmark.new(bookmark_params)
if #bookmark.save
#bookmark.users << current_user
Rails.logger.info ">>>>>>>>>>>>> Bookmark: #{#bookmark.inspect}"
topic_names = params[:topic_names].split(' ')
topic_names.each do |topic_name|
name = topic_name.sub(/#/, '')
#bookmark.topics << Topic.find_or_create_by_name(name)
end
respond_to do |format|
format.html { redirect_to #bookmark, notice: 'Bookmark was successfully created.' }
format.json { render action: 'show', status: :created, location: #bookmark }
end
else
respond_to do |format|
format.html { render action: 'new' }
format.json { render json: #bookmark.errors, status: :unprocessable_entity }
end
end
end
def update
respond_to do |format|
if #bookmark.update(bookmark_params)
format.html { redirect_to #bookmark, notice: 'Bookmark was successfully updated.' }
format.json { head :no_content }
else
format.html { render action: 'edit' }
format.json { render json: #bookmark.errors, status: :unprocessable_entity }
end
end
end
def destroy
#bookmark.destroy
respond_to do |format|
format.html { redirect_to bookmarks_url }
format.json { head :no_content }
end
end
private
def set_bookmark
#bookmark = Bookmark.find(params[:id])
end
def bookmark_params
params.require(:bookmark).permit(:url)
end
end
Any thoughts?
It seems that your html is invalid. You are using div tags in rails loop, which is not being closed. The other thing is that non-table related html tags can be used only inside tags.
This might be the working solution.
<h1>All Bookmarks</h1>
<%= link_to 'Create a New Bookmark', new_bookmark_path %>
<table>
<thead>
<tr>
<th></th>
<th></th>
<th></th>
<th></th>
</tr>
</thead>
<tbody>
<% #bookmarks.each do |bookmark| %>
<tr>
<td><%= link_to bookmark.url, "http://#{bookmark.url}" %></td>
<td><%= link_to 'Show', bookmark %></td>
<td><%= link_to 'Edit', edit_bookmark_path(bookmark) %></td>
<td><%= link_to 'Destroy', bookmark, method: :delete, data: { confirm: 'Are you sure?' } %> </td>
</tr>
<% end %>
</tbody>
</table>
Hope that helps.