I am using the omniauth-stripe-connect gem and get the following error when authenticating users:
NoMethodError in Users::OmniauthCallbacksController#stripe_connect
undefined method `persisted?' for nil:NilClass
My Callbacks Controller Action:
def stripe_connect
#user = UserProvider.find_for_stripe_oauth(request.env["omniauth.auth"])
if #user.persisted? # here is the issue !!!
sign_in #user, :event => :authentication
redirect_to root_path
end
end
And my User Method:
def self.find_for_stripe_oauth(auth)
user = UserProvider.where(:provider => auth.provider, :uid => auth.uid).first
unless user.nil?
user.user
else
registered_user = User.where(:email => auth.info.email).first
unless registered_user.nil?
user_provider = UserProvider.new
user_provider.provider = auth.provider
user_provider.uid = auth.uid
user_provider.user_id = registered_user.id
user_provider.save!
registered_user.stripe_access_code = auth.credentials.token
registered_user.stripe_publishable_key = auth.info.stripe_publishable_key
registered_user.stripe_id = auth.extra.raw_info.stripe_user_id
registered_user.skip_confirmation!
registered_user.save!
registered_user
end
end
end
What am I doing wrong?
find_for_stripe_oauth returns nil if registered_user is not exists. In this case unless registered_user.nil? returns false and inner block is not executed.
Move out registered_user, like this:
registered_user = User.where(:email => auth.info.email).first
unless registered_user.nil?
user_provider = UserProvider.new
user_provider.provider = auth.provider
user_provider.uid = auth.uid
user_provider.user_id = registered_user.id
user_provider.save!
registered_user.stripe_access_code = auth.credentials.token
registered_user.stripe_publishable_key = auth.info.stripe_publishable_key
registered_user.stripe_id = auth.extra.raw_info.stripe_user_id
registered_user.skip_confirmation!
registered_user.save!
end
registered_user
Related
I use Omniauth and Omniauth-facebook gems and I want to click on button, if user is found, then sign him in. If not, redirect him to register page.
So far I use just classic login/register:
user.rb:
def self.from_omniauth(auth, role)
user = User.where(:provider => auth.provider, :uid => auth.uid).first
if user
return user
else
registered_user = User.where(:email => auth.info.email).first
if registered_user
registered_user.provider = auth.provider
return registered_user
else
where(provider: auth.provider, uid: auth.uid).first_or_create do |user|
if (role == "1")
user.add_role :sportsman
elsif (role == "2")
user.add_role :donor
end
user.provider = auth.provider
user.uid = auth.uid
user.email = auth.info.email
user.password = Devise.friendly_token[0,20]
end
end
end
end
omniauth_callbacks_controller.rb:
def facebook
role = cookies[:role]
# signin = cookies[:signin]
user = User.from_omniauth(request.env["omniauth.auth"], role)
if user.persisted?
flash.notice = "Signed by Facebooku"
sign_in_and_redirect user
else
flash.notice = "Error, try again."
session["devise.user_attributes"] = user.attributes
redirect_to new_user_registration_url
end
end
This code works, but if user is not registered, it will register him. But I sign roles when user register himself.
Thanks for help.
Because you are already saving the user attributes into the session with
session["devise.user_attributes"] = user.attributes
Then the following should already work:
def self.from_omniauth(auth, role)
user = User.where(:provider => auth.provider, :uid => auth.uid).first
if user
return user
else
# NOTE: because you're searching "email" and not both "email" + "provider", then I assume
# that you want users to have only one shared account between all providers (i.e. if they also sign-in in Google with the exact email as his email in Facebook)
registered_user = User.where(:email => auth.info.email).first
if registered_user
# NOTE: this line doesn't do anything because registered_user is not being "saved"
registered_user.provider = auth.provider
return registered_user
else
# build a new User object (don't save yet!)
return User.new.tap do |u|
u.provider = auth.provider
u.email = auth.info.email
u.uid = uid: auth.uid
u.password = Devise.friendly_token[0,20]
# because I assume you're using "rolify" gem, don't add the roles yet here, because I don't think you can store the "roles" into the session
# add the roles logic in whatever controller you have for user registration
end
end
end
end
Then override new_with_session in your user model. new_with_session is automatically called by Devise in registrations#new. We need to set the
user attributes that we previously stored in session inside omniauth_callbacks#facebook
class User < ApplicationRecord
def self.new_with_session(params, session)
super.tap do |user|
if user_attributes = session['devise.user_attributes']
user.assign(user_attributes)
end
end
end
end
So I used simple params to get where the user come from:
<script type="text/javascript">
document.cookie = "login=0"
</script>
This code is in views/devise/registrations/new.html.erb (and in views/devise/sessions/new.html.erb) and it is a JavaScript. It tells me if user went from login page (sessions folder - login=1) or from registration page (registrations folder - login=0). Then I use this code to determinate if user is from login page AND if he is not registered yet. If both conditions are true, then he is redirected to register page. It is so simple that I am embarrassed...
def facebook
hash = request.env["omniauth.auth"]
info = hash.info
email = info["email"]
user = User.find_by_email(email)
login = cookies[:login]
if (user == nil && login == "1")
redirect_to new_user_registration_path
else
role = cookies[:role]
user = User.from_omniauth(request.env["omniauth.auth"], role)
if user.persisted?
flash.notice = "Logged in by Facebook"
sign_in_and_redirect user
else
flash.notice = "Error, try again."
session["devise.user_attributes"] = user.attributes
redirect_to new_user_registration_url
end
end
end
Im getting this error and im not sure why. There are similar problems like this that couldnt solve my case.
could be from user = User.where(:email => auth.info.email).first
could be from where(provider: auth.provider, uid: auth.uid).first_or_create do |user|
or even on the persisted? part in the omniauth_controller
What could be the possible options or solutions to this error?? thank you!! ^^
Omniauth_controller: where persisted? error takes place at.
def facebook
puts "1111111111 yayayay"
# raise request.env["omniauth.params"].inspect
user = User.from_omniauth((request.env["omniauth.auth"]), (request.env["omniauth.params"]), (request.remote_ip))
if user.persisted?
puts "3333333 okayay"
sign_in_and_redirect #user, :event => :authentication
set_flash_message(:notice, :success, :kind => "Facebook") if is_navigational_format?
else
puts "wtf wtf wtf wtf wtf"
session["devise.facebook_data"] = request.env["omniauth.auth"]
redirect_to new_user_registration_url
end
end
User Model where i create stripe verification and facebook omniauth.
#gathering the info from social media when making an account.
def self.from_omniauth(auth, auth_params, request)
anonymous_username = "NewUser#{User.last.id + 100}"
generated_password = Devise.friendly_token[0,20]
user = User.where(:email => auth.info.email).first
puts "auth params are #{auth_params}"
puts "user type is #{auth_params["user_type"]}"
if user
return user
else
where(provider: auth.provider, uid: auth.uid).first_or_create do |user|
user.confirmed_at = Time.now
user.fullname = auth.info.name
user.provider = auth.provider
user.user_type = auth_params["user_type"]
user.uid = auth.uid
user.username = anonymous_username
user.email = auth.info.email
if auth.info.image.present?
avatar_url = process_uri(auth.info.image)
user.avatar = URI.parse(avatar_url)
end
user.password = generated_password
user.save
user
end
#reviser account creation
user = User.where(:email => auth.info.email).first
puts "before the if #{user} and #{user.user_type}"
if user.user_type == 'reviser'
puts 'this is reviser starting to create account'
require "stripe"
email = auth.info.email
begin
Stripe.api_key = ENV['STRIPE_SECRET_KEY']
account = Stripe::Account.create(
{
:country => 'US',
:managed => true,
:tos_acceptance => {
:date => Time.now.to_i,
:ip => request
},
:transfer_schedule => {
:interval => 'manual'
},
:email => email,
:legal_entity => {
:type => 'individual'
}
}
)
verification = Verification.create!(
user_id: user.id,
country: 'US',
email: email,
terms_of_service: true
)
puts "success!1: #{account.id}"
puts "success!4: #{account.keys.secret}"
puts "success!5: #{account.keys.publishable}"
verification.update_attributes account_id: account.id
rescue Stripe::InvalidRequestError => e
if e.message == "An account with this email already exists."
redirect_to stripe_path, alert: "An account with this email already exists."
else
puts "#{e.message}"
flash[:error]= e.message
end
rescue Stripe::AuthenticationError => e
redirect_to stripe_path, alert: "oops! Please let us know about this error! Please Try Again Later!"
# Authentication with Stripe's API failed
# (maybe you changed API keys recently)
rescue Stripe::APIConnectionError => e
redirect_to stripe_path, alert: "oops! Something went wrong! Please Try Again!"
# Network communication with Stripe failed
rescue Stripe::StripeError => e
redirect_to stripe_path, alert: "oops! Something went wrong! Please Try Again!"
# Display a very generic error to the user, and maybe send
# yourself an email
end
end
end
end
Your method from_omniauth is returning true because of the line user.save. Return a user at the end like:
def self.from_omniauth(auth, auth_params, request)
anonymous_username = "NewUser#{User.last.id + 100}"
generated_password = Devise.friendly_token[0,20]
user = User.where(:email => auth.info.email).first
puts "auth params are #{auth_params}"
puts "user type is #{auth_params["user_type"]}"
if user
return user
else
where(provider: auth.provider, uid: auth.uid).first_or_create do |user|
user.confirmed_at = Time.now
user.fullname = auth.info.name
user.provider = auth.provider
user.user_type = auth_params["user_type"]
user.uid = auth.uid
user.username = anonymous_username
user.email = auth.info.email
if auth.info.image.present?
avatar_url = process_uri(auth.info.image)
user.avatar = URI.parse(avatar_url)
end
user.password = generated_password
user.save
end
#reviser account creation
user = User.where(:email => auth.info.email).first
puts "before the if #{user} and #{user.user_type}"
if user.user_type == 'reviser'
puts 'this is reviser starting to create account'
require "stripe"
email = auth.info.email
begin
Stripe.api_key = ENV['STRIPE_SECRET_KEY']
account = Stripe::Account.create(
{
:country => 'US',
:managed => true,
:tos_acceptance => {
:date => Time.now.to_i,
:ip => request
},
:transfer_schedule => {
:interval => 'manual'
},
:email => email,
:legal_entity => {
:type => 'individual'
}
}
)
verification = Verification.create!(
user_id: user.id,
country: 'US',
email: email,
terms_of_service: true
)
puts "success!1: #{account.id}"
puts "success!4: #{account.keys.secret}"
puts "success!5: #{account.keys.publishable}"
verification.update_attributes account_id: account.id
rescue Stripe::InvalidRequestError => e
if e.message == "An account with this email already exists."
redirect_to stripe_path, alert: "An account with this email already exists."
else
puts "#{e.message}"
flash[:error]= e.message
end
rescue Stripe::AuthenticationError => e
redirect_to stripe_path, alert: "oops! Please let us know about this error! Please Try Again Later!"
# Authentication with Stripe's API failed
# (maybe you changed API keys recently)
rescue Stripe::APIConnectionError => e
redirect_to stripe_path, alert: "oops! Something went wrong! Please Try Again!"
# Network communication with Stripe failed
rescue Stripe::StripeError => e
redirect_to stripe_path, alert: "oops! Something went wrong! Please Try Again!"
# Display a very generic error to the user, and maybe send
# yourself an email
end
end
user
end
end
I am allowing Users to Sign Up to my Service using their Slack Account.
I integrated the Sign In with Slack via the omniauth-slack gem.
Now I've got problems accessing the email and other information.
This is how I am currently doing it:
def self.find_for_slack_oauth(auth)
user = UserProvider.where(:provider => auth.provider, :uid => auth.uid).first
unless user.nil?
user.user
else
registered_user = User.where(:email => auth.info.email).first
unless registered_user.nil?
user_provider = UserProvider.new
user_provider.provider = auth.provider
user_provider.uid = auth.uid
user_provider.user_id = registered_user.id
user_provider.save!
registered_user.name = auth.info.name if registered_user.name == nil
registered_user.avatar = auth.info.image if registered_user.avatar == nil
registered_user.slack_id = auth.extra.raw_info.user_identity if registered_user.slack_id == nil
registered_user.slack_team_id = auth.extra.raw_info.team_identity if registered_user.slack_team_id == nil
registered_user.slack_team_name = auth.info.team_name if registered_user.slack_team_name == nil
registered_user.skip_confirmation!
registered_user.save!
registered_user
else
user = User.new
user.name = auth.info.name
user.email = auth.info.email
user.avatar = auth.info.image
user.slack_id = auth.extra.raw_info.user_identity
user.slack_team_id = auth.extra.raw_info.team_identity
user.slack_team_name = auth.info.team_name
user.password = Devise.friendly_token[0,20]
user.skip_confirmation!
user.save!
user_provider = UserProvider.new
user_provider.provider = auth.provider
user_provider.uid = auth.uid
user_provider.user_id = user.id
user_provider.save!
user
end
end
end
But I get no information out of it. Devise complaints that I cannot create a User without an email which is not blank.
What is the auth hash, which contains the information?
EDIT:
I don't get any values via the Auth Hash.
Here is my initialization (devise.rb):
config.omniauth :slack, Settings.slack.id, Settings.slack.secret, scope: 'identity.basic,identity.email,identity.team,identity.avatar'
Why do I get nothing?
I noticed that I was just using the wrong scope.
Instead of:
config.omniauth :slack, Settings.slack.id, Settings.slack.secret, scope: 'identity.basic,identity.email,identity.team,identity.avatar'
I should use:
config.omniauth :slack, Settings.slack.id, Settings.slack.secret, scope: 'team:read,users:read,identify'
I hope this helps someone!
The Slack documentation isn't really helpful on this.
I am putting the finishing touches on a Rails app, and everything was working fine just yesterday, (most of it still is). But now, when I try to sign in with Facebook I get the error NoMethodError undefined method persisted? for nil:NilClass I haven't changed any code in the omniauth_callbacks_controller, or in the User Model, so I do not understand why this is happening all of the sudden.
Here's the code in omniauth_callbacks_controller
def self.provides_callback_for(provider)
class_eval %Q{
def #{provider}
#user = User.from_omniauth(env["omniauth.auth"])
if #user.persisted?
sign_in_and_redirect #user, event: :authentication
set_flash_message(:notice, :success, kind: "#{provider}".capitalize) if is_navigational_format?
else
session["devise.#{provider}_data"] = env["omniauth.auth"]
redirect_to new_user_registration_url
end
end
}
end
[:twitter, :facebook].each do |provider|
provides_callback_for provider
end
And in User.rb
def self.from_omniauth(auth)
identity = Identity.where(provider: auth.provider, uid: auth.uid).first_or_create do |identity|
if identity.user == nil
user = User.new
user.email = auth.info.email || "#{auth.uid}##{auth.provider}.generated"
user.password = Devise.friendly_token[0,20]
user.provider = auth.provider
if auth.provider == "facebook"
user.name = auth.info.name
user.username = "FacebookUser" + (1 + rand(1000)).to_s
elsif auth.provider == "twitter"
user.name = auth.info.name
user.username = auth.info.nickname
end
end
identity.user = user
end
identity.access_token = auth['credentials']['token']
identity.refresh_token = auth['credentials']['refresh_token']
identity.expires_at = auth['credentials']['expires_at']
identity.timezone = auth['info']['timezone']
identity.save
identity.user
end
I cannot figure out why it WAS working yesterday, but now it's not. Nothing has changed! I'm still accessing it from the same URL, I haven't messed with the API settings on Facebook, or in devise.rb.
the problem is that identity.user is nill. It could happen, because user not valid(not saved in db), in user model did not pass validations.
I think problem can be in user.email = auth.info.email || "#{auth.uid}##{auth.provider}.generated" - wrong email type. You can add something like puts user.errors in block wehe you created user.
Also i don't understand why you need a model - identity. Much easier add field to user model
Here is my code(it's work):
def self.from_omniauth(auth)
email = auth.info.email
user = User.find_by(email: email) if email
user ||= User.create do |user|
user.provider= auth.provider
user.uid= auth.uid
user.email = auth.info.email
user.password = Devise.friendly_token[0,20]
user.name = auth.info.name
user.email ||= "#{auth.uid}_#{auth.uid}#email.com"
end
end
I am using omniauth-facebook gem with devise to authenticate with Facebook in my rails application in my user model
def self.from_omniauth(auth)
# immediately get 60 day auth token
oauth = Koala::Facebook::OAuth.new("App Key", "App secrets" )
new_access_info = oauth.exchange_access_token_info auth.credentials.token
new_access_token = new_access_info["access_token"]
new_access_expires_at = DateTime.now + new_access_info["expires"].to_i.seconds
begin
where(auth.slice(:provider, :uid)).first_or_initialize.tap do |user|
user.provider = auth.provider
user.uid = auth.uid
user.username = auth.info.first_name
user.lastname =auth.info.last_name
user.email =auth.info.email
user.authentication_token = new_access_token
user.oauth_expires_at = new_access_expires_at
user.save!
end
rescue ActiveRecord::RecordInvalid
end
end
#interact with facebook
def facebook
#facebook ||= Koala::Facebook::API.new(authentication_token)
block_given? ? yield(#facebook) : #facebook
rescue Koala::Facebook::APIError => e
logger.info e.to_s
nil # or consider a custom null object
end
def self.new_with_session(params, session)
if session["devise.user_attributes"]
new(session["devise.user_attributes"], :without_protection=> true) do |user|
user.attributes = params
user.valid?
end
else
super
end
end
and on my omniauth_callbacks controller I have this method:
def all
user = User.from_omniauth(request.env["omniauth.auth"])
if user.persisted?
flash.notice = "Signed in!"
sign_in_and_redirect user
else
session["devise.user_attributes"] = user.attributes
redirect_to new_user_registration_url
end
end
alias_method :facebook, :all
These methods are used to authenticate user from scratch via Facebook. I need a way to connect existing users with their Facebook accounts not new ones if they registered via normal devise registration method
When an existing user is trying to sign in via Facebook the following error occurs:
A `NoMethodError` occurred in `omniauth_callbacks#facebook`:
undefined method `persisted?' for nil:NilClass
app/controllers/omniauth_callbacks_controller.rb:4:in `all'
You can find user by email first and just update provider and uid fields in case he is already exists.
So your User.from_omniauth may looks like that:
def self.from_omniauth(auth)
# immediately get 60 day auth token
oauth = Koala::Facebook::OAuth.new("", "" )
new_access_info = oauth.exchange_access_token_info auth.credentials.token
new_access_token = new_access_info["access_token"]
new_access_expires_at = DateTime.now + new_access_info["expires"].to_i.seconds
user = where(provider: auth.provider, uid: auth.uid).first
unless user
# in that case you will find existing user doesn't connected to facebook
# or create new one by email
user = where(email: auth.info.email).first_or_initialize
user.provider = auth.provider # and connect him to facebook here
user.uid = auth.uid # and here
user.username = auth.info.first_name
user.lastname = auth.info.last_name
user.authentication_token = new_access_token
user.oauth_expires_at = new_access_expires_at
# other user's data you want to update
user.save!
end
user
end
upd:
In case you faced password validation error you can override User#password_required? method to skip validation for user's signed in via Facebook.
That behavior described in following episode of RailsCasts
Just for add an updated version of the answer for rails 4 and devise 3.4.x
Like this is how an updated omniauth would look like
def self.from_omniauth(auth)
if !where(email: auth.info.email).empty?
user = where(email: auth.info.email).first
user.provider = auth.provider # and connect him to facebook here
user.uid = auth.uid # and here
user.save!
user
else
where(provider: auth.provider, uid: auth.uid).first_or_create do |user|
user.email = auth.info.email
user.password = Devise.friendly_token[0,20]
user.first_name = auth.info.name # assuming the user model has a name
user.avatar = process_uri(auth.info.image) # assuming the user model has an image
end
end
end
Just look for user by email, if there is one, just add the provider and uid, if there is not one, just create it as suggested in the documentation
You can have your from_omniauth be something like this:
def self.from_omniauth(auth)
where(auth.info.slice(:email)).first_or_create do |user|
user.email = auth.info.email
user.password = Devise.friendly_token[0,20]
user.username = auth.info.name
user.description = auth.extra.raw_info.bio
end
end
In this way, if there's an existing user with email same as the facebook account, then the first_or_create will return it and then the user can sign in (it won't be update).