So I've my app crashing everytime I try to delete the last cell of the section.
Ex., if my section has 10 rows, I can delete them without any problem but the last one throws the following error:
Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid update: invalid number of sections. The number of sections contained in the table view after the update (1) must be equal to the number of sections contained in the table view before the update (3), plus or minus the number of sections inserted or deleted (0 inserted, 0 deleted).'
I've searched around here and found some ways to fix this problem, but I tried them all and couldn't get this issue fixed, it still crashes and throws the same error.
The related parts of my code goes as it follows:
override func numberOfSections(in tableView: UITableView) -> Int {
if (main_arr.count > 0 && sub_arr.count > 0) {
self.numberOfSections = 3
} else {
self.numberOfSections = 2
}
return self.numberOfSections
}
override func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
if (section == 0) {
return 1
} else if (section == 1 && main_arr.count > 0) {
return main_arr.count
} else {
return sub_arr.count
}
}
override func tableView(_ tableView: UITableView, canEditRowAt indexPath: IndexPath) -> Bool {
return true
}
// Override to support editing the table view.
override func tableView(_ tableView: UITableView, commit editingStyle: UITableViewCellEditingStyle, forRowAt indexPath: IndexPath) {
if editingStyle == .delete {
switch indexPath.section {
case 1:
main_arr.remove(at: indexPath.row)
case 2:
sub_arr.remove(at: indexPath.row)
default:
print("default 001")
}
tableView.deleteRows(at: [indexPath], with: .fade)
} else if editingStyle == .insert {
// Create a new instance of the appropriate class, insert it into the array, and add a new row to the table view
}
}
EDIT 1
I tried to handle the global variable, responsible for the numberOfSections so when any of my arrays.count == 0 it will be decreased by 1, but it didn't solved the issue.
I do understand completely the error message, like, if I've 3 sections, and I delete the whole content of one of them, I should delete one section and delete it from the datasource as well.
The problem is that numberOfSections returns different values before and after you delete rows, but you don't delete any sections. So you should either return a constant value in numberOfSections or call deleteSections in addition to deleteRows
The main thing to remember is the following:
UITableView must always contain the same number of rows and sections as your dataSource.
You cannot just return a new value in numberOfSections or numberOfRows dataSource methods. Every change should be compensated with delete/insert rows(sections) method. And vice versa: if you delete/insert to tableView, you must return corresponding values in dataSource methods. Just as your exception message states:
The number of sections contained in the table view after the update
(1) must be equal to the number of sections contained in the table
view before the update (3), plus or minus the number of sections
inserted or deleted (0 inserted, 0 deleted).
It's because 3+0≠1. In this case you should have deleted two sections to avoid crash.
The error message is actually very helpful. It talks about sections - it expected not to change, but it found a different value after your operation.
Basically, UIKit did check the number of sections and rows before calling your code, runs your code, and then checks if the the new numbers line up with your operations. In you case, it doesn't - because you are calling deleteRows (which should decrease the row count for the given section), but your numberOfSections delegate gives a different result now. So you either want to call deleteSections or keep the sectionCount unmodified.
BTW, it is not forbidden to return 0 as the number of rows for a section - maybe this is just what you want here.
A further note: I don't think that storing the number of sections in an instance variable is a good thing here. It makes for double bookkeeping.
Related
I'm working with UITableViews for the first time and I'm having some problems.
For context, my tableView has 1-2 sections. A URLRequest is called for 5 different "usernames". For each username, it checks if it's "valid" or "invalid". If it's valid, it gets appended to the Data Source array for the first section (Section 0). If it's invalid, it gets appended to the Data Source array for the first section (Section 1). The tableView is then reloaded and displays the data correctly.
The user can tap on one of the cells in the Invalid section (Section 1) to correct the invalid name to make it valid. A URL Request is initiated again and the name should now be valid.
tableView.beginUpdates() is called.
The corresponding name is removed from the Invalid section Data Source array.
The cell is deleted. (Only if it's not the LAST cell in the Invalid section.)
If the cell is the last one in the Invalid section, the whole section is deleted.
The corrected name is appended to the Valid section Data Source array.
tableView.endUpdates() is called.
Here's what happens code-wise:
DispatchQueue.main.async {
self.tableView.beginUpdates()
users.invalid.usernames.remove(at: indexPath.row) // Removing value from Data Source
if users.invalid.usernames.count == 0 { // Section (1) Data Source contains no values.
// Deleting Section (1) because it only contains one row which needs to be deleted.
let indexSet = IndexSet(arrayLiteral: indexPath.section)
self.tableView.deleteSections(indexSet, with: .automatic)
}
else { // Section (1) Data Source still contains values, so only delete the corresponding row.
self.tableView.deleteRows(at: [indexPath], with: .automatic)
}
}
Other code is ran and then the tableView ends updates.
DispatchQueue.main.async {
self.tableView.endUpdates()
}
Now, when the error happens, it doesn't explain which line it came from but it says Requested the number of rows for section... which I can only assume is related to the tableView function: func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int
Here's my code for that:
func numberOfSections(in tableView: UITableView) -> Int {
if users.invalid.usernames.count == 0 { // If Section (1) Data Source is empty, don't show Section (1).
return 1
}
else { // Section (1) Data Source contains data, show both sections.
return 2
}
}
func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int { //Gets called once for each section that exists.
/* Since the Section (1) was deleted, this function should only be called once.
*/
if section == 0 {
return users.valid.usernames.count // Section (0) Data Source count will always be at least 1.
}
else if section == 1 { // Theoretically shouldn't even happen in this case.
return users.invalid.usernames.count // Return Section (1) Data Source count.
}
else { // Will never happen.
return 1
}
}
I'm at a loss for solving this issue. Any help is appreciated :)
When I remove an object from a list and try to add a new one in I get this error
2020-01-24 14:40:26.692343+1300 HappyDays[25416:1017241] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid update: invalid number of rows in section 0. The number of rows contained in an existing section after the update (3) must be equal to the number of rows contained in that section before the update (0), plus or minus the number of rows inserted or deleted from that section (1 inserted, 0 deleted) and plus or minus the number of rows moved into or out of that section (0 moved in, 0 moved out).'
I see other issues similar to this but I've tried implementing those solutions . (Similar issue , another similar issue)
Sections of my code:
Selecting the cell to delete if from the table
func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
activeObjectives.actives.remove(at: indexPath.row)
tableView.deleteRows(at: [indexPath], with: .left)
}
Adding a new object to the table by tapping a button
#IBAction func getGoals(_ sender: UIButton) {
let newRowIndex = activeObjectives.actives.count
activeObjectives.setRandomGoalToActive(allObjectiveList: allGoalsArray)
addActiveGoalToactiveObjectives()
let indexPath = IndexPath(row: newRowIndex, section: 0)
let indexPaths = [indexPath]
activeGoalDisplay.insertRows(at: indexPaths, with: .automatic)
}
In case it's also needed, here is my addActiveGoalToactiveObjectives function called in the above
func addActiveGoalToactiveObjectives() {
for goal in allGoalsArray.goalsList {
if goal.isActive == true && activeObjectives.actives.contains(goal) == false {
activeObjectives.actives.append(goal)
}
}
}
Thanks in advance, any help is greatly appreciated
I found the issue. I wasn't setting an object value to false when removing it from the list. Now when I remove them I set the object to inactive.
activeObjectives.actives[indexPath.row].setInactive()
activeObjectives.actives.remove(at: indexPath.row)
tableView.deleteRows(at: [indexPath], with: .left)
}```
I am building an iOS app, basically the user create an item by pressing the "+" button and then the app should put the new item in according section of the table based on the location of the item. However I got the error: Invalid update: invalid number of rows in section 1. The number of rows contained in an existing section after the update (1) must be equal to the number of rows contained in that section before the update. Here is my code, thank you
let sections = ["Bathroom", "Bedroom", "Dining Room", "Garage", "Kitchen", "Living Room"]
#IBAction func addNewItem(_ sender: UIBarButtonItem) {
/*
//Make a new index path for the 0th section, last row
let lastRow = tableView.numberOfRows(inSection: 0)
let indexPath = IndexPath(row: lastRow, section: 0)
//insert this new row into the table
tableView.insertRows(at: [indexPath], with: .automatic)*/
//Create a new item and add it to the store
let newItem = itemStore.createItem()
var Num: Int = 0
if let index = itemStore.allItems.index(of: newItem) {
switch newItem.room {
case "Bathroom":
Num = 0
print("I am in here")
case "Bedroom":
Num = 1
case "Dining Room":
Num = 2
case "Garage":
Num = 3
case "Kitchen":
Num = 4
case "Living Room":
Num = 5
default:
Num = 0
print("I am in Default")
}
let indexPath = IndexPath(row: index, section: Num)
tableView.insertRows(at: [indexPath], with: .automatic)
}
override func numberOfSections(in tableView: UITableView) -> Int {
return sections.count
}
override func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
return itemStore.allItems.count
}
override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
//create an instance of UITableViewCell, with default appearance
//let cell = UITableViewCell(style: .value, reuseIdentifier: "UITableViewCell")
//get a new or recycled cell
//if indexPath.row < itemStore.allItems.count {
let cell = tableView.dequeueReusableCell(withIdentifier: "ItemCell", for: indexPath) as! ItemCell
//Set the text on the cell with the decription of the item
//that is at the nth index of items, where n = row this cell
//will appear in on the table view
let item = itemStore.allItems[indexPath.row]
if item.name == "" {
cell.nameLabel.text = "Name"
} else {
cell.nameLabel.text = item.name
}
if item.serialNumber == nil {
cell.serialNumberLabel.text = "Serial Number"
} else {
cell.serialNumberLabel.text = item.serialNumber
}
cell.valueLabel.text = "$\(item.valueInDollars)"
cell.roomLabel.text = item.room
if item.valueInDollars < 50 {
cell.valueLabel.textColor = UIColor.green
}else if item.valueInDollars >= 50 {
cell.valueLabel.textColor = UIColor.red
}
cell.backgroundColor = UIColor.clear
return cell
}
override func tableView(_ tableView: UITableView, titleForHeaderInSection section: Int) -> String? {
let LocationName = sections[section]
return LocationName
}
thank you so much for your time!
and this is how I create item
#discardableResult func createItem() -> Item {
let newItem = Item(random: false)
allItems.append(newItem)
return newItem
}
The problem is that you should insert the item in the array first:
itemStore.allItems.append(newItem)
Also, there is a difference between sections and rows in numberOfRowsInSection(return number of rows for every section) you have a switch that returns the same number, it should be
override func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
return itemStore.allItems.count
}
Edit :
The problem is when the table loads there is 0 rows for all the sections ( itemStore.allItems.count is zero ), when you try to insert a row say at section 0 , row 0 -- the dataSource must be updated only for that section , which is not happen in your case as it's the same array that is returned for all sections , so you must either have an array of array where inner array represent number of rows so addition/deletion from it doesn't affect other ones ,,,,, or lock the insert to say section 0 like this
override func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
if (section == 0 ) {
return itemStore.allItems.count
}
return 0
}
in this edit i inserted in 2 sections 0 and 2 with no crash because i handled numberOfRowsInSection to return old numbers for old section that why to be able to insert in all sections you must have a different data source array or manage from numberOfRowsInSection , see edited demo here Homepwner
Instead of setting footer in viewDidLoad implement this method
override func tableView(_ tableView: UITableView, viewForFooterInSection section: Int) -> UIView? {
if(section == 5 ) {
let textLabel = UILabel()
textLabel.text = "No more Item"
return textLabel
}
return nil
}
There is something terribly wrong with your data source. Your numberOfRow for all sections is the same. i.e. itemStore.allItems.count. Which means you are setting the same number of rows in each section.
The main issue is, while adding a new item, you are inserting a new row in the specific section which means
new number of rows for section = previous number of rows in section +
1
However, there is no addition in the data source.
So according to the code, you have inserted a new row, but your data source has one record less since you didn't add the item there.
So I would like you do the following in order of these steps :
Add item in required data source.
inserRowInSection
Update : Remove the condition in cellForRowAtIndexPath :
if indexPath.section <= 1 and it's else block. You don't need that. If number of sections is less than 1, it won't be called. Moreover it's the else block which is getting called all the time because you already have sections in your code. So if case will never be called.
So I got the issue. In itemStore.createItem() the value for room is always Room. In the switch-case, you never have Room case. So it always falls in default case. You need to fix that.
#Jacky.S I downloads your code and try to debug it.Fist look our error properly.
reason: 'Invalid update: invalid number of rows in section 1. The number of rows contained in an existing section after the update (1) must be equal to the number of rows contained in that section before the update (0)
So It says before update, your sections has 0 rows. Now you try to update you tableview using this piece of code.
print(indexPath)
tableView.insertRows(at: [indexPath], with: .automatic)
I just added the print statement for debugging purpose and it prints [0, 0] .So you say your tableview to insert 0th row on section 0.
Now when you insert any row into tableview it calls the delegate method.Now look at the below delegate method.
override func tableView(_ tableView: UITableView, numberOfRowsInSection
section: Int) -> Int {
if section == 0{
print("0",itemStore.allItems.count)
}
if section == 1{
print("1",itemStore.allItems.count)
}
// print(itemStore.allItems)
return itemStore.allItems.count
}
In your code you just return itemStore.allItems.count.I added the above code for debugging.Now look that itemStore.allItems.count always return 1.So for first section it works perfectly because few times ago you insert a row in first section whose index is [0 = row, 0 = section].So you previously returned rows for section 0 is equal to the recently return rows for section 0.But When it comes for section 1 you previously return no row that means your section 1 has no rows in previous but in your above delegate method you also return 1 row for section 1.Which is conflicting because in previous you never update or return any rows for section 1.That's why you code crash and and say that
your number of rows contained in an existing section after the update is 1 which must be equal to the number of rows contained in that section before the update. Which is 0.
So this is the explanation for you crash.
Now, to recover from crash your allItems should be a dictionary or an array of array.
var allItems = [[Item]]()
or
var allItems = ["String":[Item]]()
guess allItems element is something like this
allItems = ["bathroom":[item1, item2, item3],"bedroom":[item1, item2, item3, item4]]
so here you have 2 section one is bathroom and another is bedroom.First section have 3 row and second one have 4 row and in you tableview delegate method you have to return 3 for section 0 and 4 for section 1
My app has crashed multiple times while implementing a swipe to delete feature.
reason: 'Invalid update: invalid number of rows in section 0.
The number of rows contained in an existing section after the update
(1) must be equal to the number of rows contained in that section
before the update (1), plus or minus the number of rows inserted or
deleted from that section (0 inserted, 1 deleted) and plus or minus the
number of rows moved into or out of that section (0 moved in, 0 moved
out).'
I read somewhere that this has to do with rows not being decremented by 1 at numberOfRowsInSection so I created a var deleted :Bool? to change whenever a data / row is deleted. Now, I just swipe and delete once and my app crashes after another attempt.
Here are the codes related to this:
var myFavs : [MyFavourites]?
var deleted :Bool?
override func tableView(tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
// #warning Incomplete implementation, return the number of rows
if deleted == true {
return myFavs!.count - 1
} else {
return (myFavs?.count)!
}
}
// Override to support editing the table view.
override func tableView(tableView: UITableView, commitEditingStyle editingStyle: UITableViewCellEditingStyle, forRowAtIndexPath indexPath: NSIndexPath) {
if editingStyle == .Delete {
tableView.beginUpdates()
//Delete from CD.
let appDel: AppDelegate = UIApplication.sharedApplication().delegate as! AppDelegate
let context: NSManagedObjectContext = appDel.managedObjectContext
let myFavo = myFavs![indexPath.row]
context.deleteObject(myFavo as MyFavourites)
do {
try context.save()
} catch _ {
}
// Delete the row from the data source
tableView.deleteRowsAtIndexPaths([indexPath], withRowAnimation: .Fade)
deleted = true
tableView.endUpdates()
tableView.reloadData()
}
}
[Edit]
My Data source var myFavs : [MyFavourites]? is a generated NSManagedObject subclass from CoreData. I forgot to mention that it deletes successfully from coreData when I restart the App from Simulator.
Here's my Data Source code if necessary.
extension MyFavourites {
#NSManaged var id: String?
}
What am I doing wrong ?
Is there any way to delete the last row of a particular section in a UITableView without deleting that entire section? I would like to be able to remove the last row from a section but keep that section's header visible, as it indicates that the sections exists but has no data.
I've found multiple prior answers on StackOverflow, but their solutions all seem to be that you have to delete the section if you want to delete the last row of a section, e.g., How to delete the last row of a section?
Well, your problem is related how UITableViewDataSource protocol works, if there isn't any content in the section, the section shouldn't be displayed.
But what you can do about it?
There is a simple way, in your dataSource numberOfRowsInSection you can do an if, that condition will verify if your dataSource count is equal to zero and return 1 instead, like this:
func tableView(tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
var numberOfRows = 0
switch section{
case 0:
numberOfRows = firstSectionArray.count()
case 1:
numberOfRows = secondSectionArray.count()
default:
()
}
if numberOfRows == 0 {
numberOfRows = 1
}
return numberOfRows
}
And in the cellForRowAtIndexPath:
func tableView(tableView: UITableView, cellForRowAtIndexPath indexPath: NSIndexPath) -> UITableViewCell {
var numberOfRowsForThisSection = 0
switch indexPath.section{
case 0:
numberOfRowsForThisSection = firstSectionArray.count()
case 1:
numberOfRowsForThisSection = secondSectionArray.count()
default:
()
}
if numberOfRowsForThisSection == 0 {
return tableView.dequeueReusableCellWithIdentifier("blankCell") as! UITableViewCell
}
// Do the default implementation
// .
// .
// .
}
"Oh, but now there is a white cell in the middle of the tableView"
Ok, let's break that:
func tableView(tableView: UITableView, heightForRowAtIndexPath indexPath: NSIndexPath) -> CGFloat {
var numberOfRowsForThisSection = 0
switch indexPath.section{
case 0:
numberOfRowsForThisSection = firstSectionArray.count()
case 1:
numberOfRowsForThisSection = secondSectionArray.count()
default:
()
}
if numberOfRowsForThisSection == 0 {
return 0.0
}
}
...and it turns out that my error was elsewhere. In this case, I was accidentally trying to delete index path (1, 2147483647). This error resulted because I was assuming that the array I was using for that section's data contained the object I wanted to delete. Since it didn't, [array indexOfObject:object] equaled 2147483647. Oddly enough, the error produced was Invalid number of sections rather than Invalid number of rows in section.