What does this error mean and how exactly can we fix it because the example tonemelody program works fine? - token

Question

enter code here
#include "Pitches.h"
// notes in the melody:
int melody[] = {
NOTE_FS4, NOTE_FS4, NOTE_D4, NOTE_B3,0, NOTE_B3,0, NOTE_E4,0, NOTE_E4,0,NOTE_E4, NOTE_GS4, NOTE_GS4 NOTE_A4, NOTE_B4,
NOTE_A4, NOTE_A4, NOTE_A4, NOTE_E4,0, NOTE_CS4,0, NOTE_FS4,0, NOTE_FS4,0, NOTE_FS4, NOTE_E4, NOTE_E4, NOTE_FS4, NOTE_E4,
NOTE_D4, NOTE_D4, NOTE_D4, NOTE_CS4, NOTE_B3,0, NOTE_B3, NOTE_B3,0, NOTE_CS4, NOTE_CS4,0, NOTE_CS4,0, NOTE_A3,0, NOTE_A3,0, NOTE_F4,0, NOTE_F4,
NOTE_F4, NOTE_E4, NOTE_D4, NOTE_D4, NOTE_D4, NOTE_CS4,0, NOTE_B3,0, NOTE_B3,0, NOTE_B3, NOTE_B3,0,0, NOTE_A4, NOTE_A4, NOTE_A4, NOTE_A4, NOTE_A4, NOTE_A4,
NOTE_A4, NOTE_G4,0, NOTE_FS4,0, NOTE_E4,0, NOTE_A4, NOTE_A4, NOTE_G4, NOTE_G4, NOTE_A4, NOTE_A4,
NOTE_E5, NOTE_FS5, NOTE_FS5, NOTE_E5, NOTE_A4, NOTE_A4, NOTE_E5, NOTE_E5, NOTE_FS5, NOTE_FS5, NOTE_E4, NOTE_F4
};
//note durations: 2 = half note, 4 = quarter note, 8 = eighth note, 12 = twelveth note, :
int noteDurations[] = {
8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8,
8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8,
12, 8, 8, 8, 4, 8, 8, 8, 8, 4, 4, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8
4, 4, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 4, 4, 4, 8, 8, 8, 8, 8, 8,
8, 8, 8, 8, 8, 8, 4, 2, 2, 2, 2, 2, 2,
12, 8, 4, 4, 2, 2, 2, 2, 2, 2, 12, 8,
};
void setup() {
// iterate over the notes of the melody:
for (int thisNote = 0; thisNote < 12; thisNote++) {
// calculate the note duration as 1 second divided by note type.
//e.g. quarter note = 1000 / 4, eighth note = 1000/8, etc.
int noteDuration = 1000 / noteDurations[thisNote];
tone(12, melody[thisNote], noteDuration);
// to distinguish the notes, set a minimum time between them.
// the note's duration + 30% seems to work well:
int pauseBetweenNotes = noteDuration * 1.30;
delay(pauseBetweenNotes);
// stop the tone playing:
noTone(12);
}
}
void loop() {
// no need to repeat the melody.
}
This is the file included for pitches
/*************************************************
* Public Constants
*************************************************/
#define NOTE_B0 31
#define NOTE_C1 33
#define NOTE_CS1 35
#define NOTE_D1 37
#define NOTE_DS1 39
#define NOTE_E1 41
#define NOTE_F1 44
#define NOTE_FS1 46
#define NOTE_G1 49
#define NOTE_GS1 52
#define NOTE_A1 55
#define NOTE_AS1 58
#define NOTE_B1 62
#define NOTE_C2 65
#define NOTE_CS2 69
#define NOTE_D2 73
#define NOTE_DS2 78
#define NOTE_E2 82
#define NOTE_F2 87
#define NOTE_FS2 93
#define NOTE_G2 98
#define NOTE_GS2 104
#define NOTE_A2 110
#define NOTE_AS2 117
#define NOTE_B2 123
#define NOTE_C3 131
#define NOTE_CS3 139
#define NOTE_D3 147
#define NOTE_DS3 156
#define NOTE_E3 165
#define NOTE_F3 175
#define NOTE_FS3 185
#define NOTE_G3 196
#define NOTE_GS3 208
#define NOTE_AS3 233
#define NOTE_B3 247
#define NOTE_C4 262
#define NOTE_CS4 277
#define NOTE_D4 294
#define NOTE_DS4 311
#define NOTE_E4 330
#define NOTE_F4 349
#define NOTE_FS4 370
#define NOTE_G4 392
#define NOTE_GS4 415
#define NOTE_A4 440
#define NOTE_AS4 466
#define NOTE_B4 494
#define NOTE_C5 523
#define NOTE_CS5 554
#define NOTE_D5 587
#define NOTE_DS5 622
#define NOTE_E5 659
#define NOTE_F5 698
#define NOTE_FS5 740
#define NOTE_G5 784
#define NOTE_GS5 831
#define NOTE_A5 880
#define NOTE_AS5 932
#define NOTE_B5 988
#define NOTE_C6 1047
#define NOTE_CS6 1109
#define NOTE_D6 1175
#define NOTE_DS6 1245
#define NOTE_E6 1319
#define NOTE_F6 1397
#define NOTE_FS6 1480
#define NOTE_G6 1568
#define NOTE_GS6 1661
#define NOTE_A6 1760
#define NOTE_AS6 1865
#define NOTE_B6 1976
#define NOTE_C7 2093
#define NOTE_CS7 2217
#define NOTE_D7 2349
#define NOTE_DS7 2489
#define NOTE_E7 2637
#define NOTE_F7 2794
#define NOTE_FS7 2960
#define NOTE_G7 3136
#define NOTE_GS7 3322
#define NOTE_A7 3520
#define NOTE_AS7 3729
#define NOTE_B7 3951
#define NOTE_C8 4186
#define NOTE_CS8 4435
#define NOTE_D8 4699
#define NOTE_DS8 4978
As part of an engineering project for school we were asked to make a program that could play a simple song. We have created the code based on the example ToneMelody for the arduino program. we get an error after all of are notes are listed that highlights red on both are music_code file and our pitches.h file. However, on our pitches.h file the error stops at #define Note_AS3 233 it says exit status 1 expected declaration before '}' token. What does this error mean and how exactly can we fix it because the example tonemelody program works fine?

Answer 1

So, there's a number of errors in your posted sketch which would stop it from compiling.
NOTE_A3 is referenced but not defined
On the very first line of the definition of int melody[], there is no comma between NOTE_GS4 and NOTE_A4
On the third line of the definition of int noteDurations[], you are missing a comma between 8 at the end of the line, and the next element
If you correct all three of these, the code should compile just fine. You should, however, receive more than just one error like you describe from the Arduino IDE. I received notably more, which allowed me to at least figure out where each problem was. If you don't see it in the Arduino error box, you should at least see it through the command line output, which will allow you to track these down in the future.