I have two models: Organization and Drawing. They have a 1:1 relationship. Drawing contains two variables: organization_id and file_path.
At signup of a new organization, I have my Rails application automatically copy a standard file for that organization to my S3 bucket. File_path in the Drawing model should include the string to the path where the file is stored.
To the organization's controller I have added a reference to the method upload_file, which I have included in the Drawing model.
Controller:
def create
#organization = Organization.new(organizationnew_params)
if #organization.save
Drawing.upload_file(#organization.id)
redirect_to root_url
end
end
Model:
def self.upload_file(id)
s3 = Aws::S3::Resource.new(
credentials: Aws::Credentials.new(ENV['S3_ACCESS_KEY'], ENV['S3_SECRET_KEY']),
region: ENV['AWS_REGION']
)
xmlfile = 'app/assets/other/graph.xml'
key = "uploads/#{id}/xml-#{id}.xml"
obj = s3.bucket('mybucketname').object(key)
obj.upload_file(xmlfile)
Conceptmap.create!(organization_id: id, xml_file: obj.public_url)
end
Question: My question concerns the correctness of xml_file: obj.public_url on the last line. Here I want to save the bucket-path of the saved file. But I wonder if this is the secure way to do this (or should this path be a hash)? How does this work with a carrierwave uploader; is it then automatically hashed? I don't want just anyone to be able to browse to the file and open it.
Related
I'm attempting to pull a single PDF file from my Amazon S3 bucket. Then I want to convert it to OCR, and then clear the bucket. This is the code basic structure.
class SyncronizeBucketJob
def perform
s3_objects = get_s3_files
create_ocr_documents(s3_objects)
remove_s3_objects(s3_objects)
end
def get_s3_files
# get list of s3 files here
end
def create_ocr_documents(s3_objects)
# for each s3 object create new OcrDocument with a file from s3
end
def remove_s3_objects(s3_objects)
# physically go and delete each s3 file
end
end
After reading through the documentation many times I've gotten to here,
def perform
s3_objects = get_s3_files
create_ocr_documents(s3_objects)
remove_s3_objects(s3_objects)
#bucket = bucket
#object_key = object_key
end
def pull_s3_files
bucket = s3_resource.bucket('')
bucket.objects.select do |obj|
# return true if obj is pdf
end
def create_ocr_documents
Courts::Utils::PdfVersionConverter.new(input_path: tmp_file_path, output_path: tmp_output_file_path).call
end
def remove_s3_objects
# physically go and delete each s3 file
object = s3_resource.bucket(bucket).object(object_key)
object.delete
end
But it's still not functioning, being a novice with rails and even more with AWS I'm at a loss as to where to proceed.
I have an attachment
class User < ApplicationRecord
has_one_attached :avatar
when I create the user and I perform on my seed
user = User.create({"name":"pedro})
file = open("#{Rails.root}/app/assets/img/user.png")
user.avatar.attach(io: file, filename: "user.png")
the avatar gets attached
However, when I try to replicate/update it on my controller:
user = User.find(params["id"])
user.avatar.purge
file = open("#{Rails.root}/app/assets/img/user.png")
user.avatar.attach(io: file, filename: "user.png")
It somehow gets attatched (if I perform a user.avatar.attached? before it returns false and true after I attach it) but the blob doesn't persist/get saved into storage. It somehow only persists with newly created objects.
I've tried looking for questions with a similar issue with no success.
I don't see anywhere that you are saving it to the database. Try user.new instead of user.create. After attaching the file save it.
user = User.new({"name":"pedro})
file = open("#{Rails.root}/app/assets/img/user.png")
user.avatar.attach(io: file, filename: "user.png")
user.save
it is good practice to add the content type
user.avatar.attach(io: file, filename: "user.png" , content_type:
'image/png')
Edit (Op comment update): you can use user.save(validate: false) to skip validations
When adding attachments such as
has_one_attached :resume_attachment
saved files end up in the top level of the S3 bucket. How can I add them to subdirectories? For example, my old paperclip configuration could categorize in directories by model name.
You can not. There is only one option possible, at that time, for has_one_attached, has_many_attached macros that is :dependent.
https://github.com/rails/rails/blob/master/activestorage/lib/active_storage/attached/macros.rb#L30
see (maybe the reason why you have downvotes, but it is about "direct" upload so...) : How to specify a prefix when uploading to S3 using activestorage's direct upload?.
The response is from the main maintainer of Active Storage.
Use a before_validation hook to set the desired key on S3 and the desired filename for the content disposition object properties on S3.
The key and filename properties on the attachment model make their way through to the ActiveStorage S3 gem and are converted into S3 key + content disposition object properties.
class MyCoolItem < ApplicationRecord
has_one_attached :preview_image
has_one_attached :download_asset
before_validation :set_correct_attachment_filenames
def preview_image_path
# This key has to be unique across all assets. Fingerprint it yourself.
"/previews/#{item_id}/your/unique/path/on/s3.jpg"
end
def download_asset_path
# This key has to be unique across all assets. Fingerprint it yourself.
"/downloads/#{item_id}/your/unique/path/on/s3.jpg"
end
def download_asset_filename
"my-friendly-filename-#{item_id}.jpg"
end
def set_correct_attachment_filenames
# Set the location on S3 for new uploads:
preview_image.key = preview_image_path if preview_image.new_record?
download_asset.key = download_asset_path if download_asset.new_record?
# Set the content disposition header of the object on S3:
download_asset.filename = download_asset_filename if download_asset.new_record?
end
end
I have an avatar for each user, and the username is always going to be unique. This is why I wanted to rename the image to reflect the username of the person uploading said picture to make for easier fetching and solve any problems with image names clashing.
However, I'm having problems accessing the username of the person in my app/uploader/avatar_uploader.rb file. I had something along the lines of this.
def filename
if original_filename
#user = User.find_by_username(params[:id])
"#{#user.username}.#{file.extension}"
end
end
I'm getting errors here that the params doesn't exist, and without that, the method username does not exist.
Overriding it to something such as "foo.jpg" does work and the file is successfully uploading, I'm just wondering how to access the username of the user uploading the file.
params[:id] is nil unless you pass it with the request or embed in the route. But I don't recommend this way, because a user can change it to pass any id.
You should get the user who`s uploading the file from the session, for example using devise
#user = current_user
or if you have stored user_id in session:
#user = User.find(session[:user_id])
EDIT
The above code works only in controllers, that is, you need to get the user in the controller and pass to your uploader method:
def filename(user)
I'm using jpegcam to allow a user to take a webcam photo to set as their profile photo. This library ends up posting the raw data to the sever which I get in my rails controller like so:
def ajax_photo_upload
# Rails.logger.info request.raw_post
#user = User.find(current_user.id)
#user.picture = File.new(request.raw_post)
This does not work and paperclip/rails fails when you try to save request.raw_post.
Errno::ENOENT (No such file or directory - ????JFIF???
I've seen solutions that make a temporary file but I'd be curious to know if there is a way to get Paperclip to automatically save the request.raw_post w/o having to make a tempfile. Any elegant ideas or solutions out there?
UGLY SOLUTION (Requires a temp file)
class ApiV1::UsersController < ApiV1::APIController
def create
File.open(upload_path, 'w:ASCII-8BIT') do |f|
f.write request.raw_post
end
current_user.photo = File.open(upload_path)
end
private
def upload_path # is used in upload and create
file_name = 'temp.jpg'
File.join(::Rails.root.to_s, 'public', 'temp', file_name)
end
end
This is ugly as it requires a temporary file to be saved on the server. Tips on how to make this happen w/o the temporary file needing to be saved? Can StringIO be used?
The problem with my previous solution was that the temp file was already closed and therefore could not be used by Paperclip anymore. The solution below works for me. It's IMO the cleanest way and (as per documentation) ensures your tempfiles are deleted after use.
Add the following method to your User model:
def set_picture(data)
temp_file = Tempfile.new(['temp', '.jpg'], :encoding => 'ascii-8bit')
begin
temp_file.write(data)
self.picture = temp_file # assumes has_attached_file :picture
ensure
temp_file.close
temp_file.unlink
end
end
Controller:
current_user.set_picture(request.raw_post)
current_user.save
Don't forget to add require 'tempfile' at the top of your User model file.