How do I test stripe and my controller effectively? - ruby-on-rails

Question

I have the following models:
subscription, user, and events
A user has_one subscription
A subscription belongs_to a user
A user has_many events
An event belongs_to a user
So far I have been able to successfully create acceptance tests using Capybara and RSpec. This allows me to 'upgrade' a users account (which adds a different role). I've also been able to do an acceptance test where the user cancels their subscription and ensure their roles are removed.
However, now I want to ensure that any of the user's open events are cancelled. This is where I'm getting stuck. Actually, I didn't even get this far because I ran in to trouble trying to even destroy a subscription.
So, I created a controller spec called subscriptions_controller_spec.rb. In this spec, there is a test to ensure the destroy action works as expected. This is failing because in my controller it goes to retrieve the customer and subscription, which doesn't exist, and returns an Stripe::InvalidRequestError.
In order to get around this, I tried to use stripe-ruby-mock to mock the stripe servers. However, I'm not sure how I'm supposed to use this in a controller spec and I got really confused. Below is my controller and my controller spec. Any advice on how I should attack this would be really appreciated.
subscriptions_controller_spec.rb
require 'rails_helper'
RSpec.describe SubscriptionsController, :type => :controller do
let(:stripe_helper) { StripeMock.create_test_helper }
before { StripeMock.start }
after { StripeMock.stop }
# ... omitted
describe 'DELETE destroy' do
before :each do
sign_in_trainer
#subscription = create(:subscription, user: subject.current_user)
plan = stripe_helper.create_plan(:id => 'Standard')
customer = Stripe::Customer.create({
email: 'johnny#appleseed.com',
source: stripe_helper.generate_card_token,
plan: 'Standard'
})
#subscription.customer_id = customer.id
#subscription.stripe_sub_id = customer.subscriptions.data.first.id
end
it 'destroys the requested subscription' do
expect {
delete :destroy, {:id => #subscription.to_param}
}.to change(Subscription, :count).by(-1)
end
# ... omitted
end
end
And subscriptions_controller.rb
class SubscriptionsController < ApplicationController
before_action :set_subscription, only: [:update, :destroy]
# ... ommitted
# DELETE /cancel-subscriptions/1
def destroy
begin
customer = Stripe::Customer.retrieve(#subscription.customer_id)
customer.subscriptions.retrieve(#subscription.stripe_sub_id).delete
rescue Stripe::CardError => e
# User's card was declined for many magnitude of reasons
redirect_to user_dashboard_path, alert: 'There was a problem cancelling your subscription' and return
rescue Stripe::APIConnectionError => e
# Stripe network issues
redirect_to user_dashboard_path, alert: 'Network issue. Please try again later' and return
rescue Stripe::APIError => e
# Stripe network issues
redirect_to user_dashboard_path, alert: 'Network issue. Please try again later' and return
rescue Stripe::InvalidRequestError => e
# This is something that we screwed up in our programming. This should literally never happen.
redirect_to user_dashboard_path, alert: 'There was a problem cancelling your subscription.' and return
rescue => e
logger.error e.message
logger.error e.backtrace.join("\n")
redirect_to user_dashboard_path, alert: 'There was a problem cancelling your subscription.' and return
end
if current_user.events
#events = current_user.events
#events.open.each do |event|
event.cancel
end
end
current_user.remove_role 'trainer'
current_user.add_role 'user'
current_user.save
#subscription.destroy
respond_to do |format|
format.html { redirect_to user_dashboard_path, notice: 'Subscription cancelled. All your open events have been cancelled.' }
format.json { head :no_content }
end
end
private
# Use callbacks to share common setup or constraints between actions.
def set_subscription
#subscription = Subscription.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.
def subscription_params
params[:subscription]
end
end

Answer 1

I think you've kind of already hit the nail on the head here, the fact that it's hard to test in a controller spec indicates that it might be a good time to consider moving the behaviour to a service class.
What i'd do is setup an integration test to use as your feedback loop, then refactor and get back to green. Once you've done that, start refactoring your service class and building on your specs from there.

Answer 2

Does simply mocking out Stripe not work eg:
require 'rails_helper'
RSpec.describe SubscriptionsController, :type => :controller do
# ... omitted
describe 'DELETE destroy' do
before :each do
sign_in_trainer
#subscription = create(:subscription, user: subject.current_user)
end
it 'destroys the requested subscription' do
# just mock stripe to pass back the customer you expect - as though it Just Works
expect(Stripe::Customer).to receive(:retreive).and_return(subscription.customer)
expect {
delete :destroy, {:id => #subscription.to_param}
}.to change(Subscription, :count).by(-1)
end
it 'does not destroy it if we got a card error' do
# likewise you can mock up what happens when an error is raised
expect(Stripe::Customer).to receive(:retreive).and_raise(Stripe::CardError)
expect {
delete :destroy, {:id => #subscription.to_param}
}.not_to change(Subscription, :count)
end
# ... omitted
end
end