How to stop count from duplicating partials in #show? - ruby-on-rails

Question

For some reason I am getting duplicates of show.html.erb. The duplicates happen to coincide with what the .count is, even if I remove .count from the show file.
users/show.html.erb
<% if #user.habits.any? %>
<h2>Habit Challenges (<%= #user.habits.count %>)</h2>
<%= render #habits %>
<% end %>
<% if #user.valuations.any? %>
<h2>Values (<%= #user.valuations.count %>)</h2>
<%= render #valuations %>
<% end %>
<% if #user.goals.any? %>
<h2>Current Goals (<%= #user.goals.unaccomplished.count %>)</h2>
<%= render #unaccomplished_goals %>
<% end %>
<% if #user.goals.any? %>
<h2>Accomplished Goals (<%= #user.goals.accomplished.count %>)</h2>
<%= render #accomplished_goals %>
<% end %>
<% if #user.quantifieds.any? %>
<h2>Stats: Monthly Average (<%= #user.quantifieds.count %>)</h2>
<%= render #averaged_quantifieds %>
<% end %>
<% if #user.quantifieds.any? %>
<h2>Stats: Instances (<%= #user.quantifieds.count %>)</h2>
<%= render #instance_quantifieds %>
<% end %>
users_controller.rb
def show
#user = User.find(params[:id])
#habits = #user.habits.all
#valuations = #user.valuations.all
#accomplished_goals = #user.goals.accomplished.all
#unaccomplished_goals = #user.goals.unaccomplished.all
#averaged_quantifieds = #user.quantifieds.averaged.all
#instance_quantifieds = #user.quantifieds.instance.all
end
As you can see by the picture if I create 3 habits, 3 tables of habits will show. If I create 4, 5, so on the same thing happens. The same goes for the rest, like with values (#valuations) 12 repetitions are being created.
habits/_habit.html.erb
<!-- Default bootstrap panel contents -->
<div id="valuations" class="panel panel-default">
<div class="panel-heading"><h4><b>HABITS</b></h4></div>
<!-- Table -->
<table>
<thead>
<tr>
<th>Level</th>
<th>Left</th>
<th>Strike</th>
<th>Trigger</th>
<th>Action</th>
<th>Target</th>
<th>Reward</th>
<th>Days</th>
</tr>
</thead>
<tbody>
<% #habits.each do |challenged| %>
<tr>
<td><%= challenged.current_level %></td>
<td>
<%= link_to edit_habit_path(challenged) do %>
<%= [params[:missed]].flatten.length %>
<% end %></td>
<td><%= challenged.trigger %></td>
<td class="category">
<b><%= raw challenged.tag_list.map { |t| link_to t.titleize, tag_path(t) }.join(', ') %></b>
</td>
<td><%= challenged.target %></td>
<td class= "committed">
<%= challenged.committed.map { |d| d.titleize[0,3] }.join ', ' %></td>
</tr>
<% end %>
</tbody>
</table>
</div>
Do you have any ideas? I'm baffled.

Answer 1

You can try this:
<h2>Habit Challenges (<%= #habits.count %>)</h2>
<%= render #habits %>
<h2>Values (<%= #valuations.count %>)</h2>
<%= render #valuations %>
<h2>Current Goals (<%= #unaccomplished_goals.count %>)</h2>
<%= render #unaccomplished_goals %>
<h2>Accomplished Goals (<%= #accomplished_goals.count %>)</h2>
<%= render #accomplished_goals %>
<h2>Stats: Monthly Average (<%= #averaged_quantifieds.count %>)</h2>
<%= render #averaged_quantifieds %>
<h2>Stats: Instances (<%= #instance_quantifieds.count %>)</h2>
<%= render #instance_quantifieds %>
Change your show action:
def show
#user = User.find(params[:id])
#habits = #user.habits
#valuations = #user.valuations
#accomplished_goals = #user.goals.accomplished
#unaccomplished_goals = #user.goals.unaccomplished
#averaged_quantifieds = #user.quantifieds.averaged
#instance_quantifieds = #user.quantifieds.instance
end
Change your partial, stop iterating over #habits again:
<tbody>
<tr>
<td><%= habit.current_level %></td>
<td><%= link_to edit_habit_path(habit) do %>
<%= [params[:missed]].flatten.length %><% end %>
</td>
<td><%= habit.trigger %></td>
<td class="category"><b><%= raw habit.tag_list.map { |t| link_to t.titleize, tag_path(t) }.join(', ') %></b></td>
<td><%= habit.target %></td>
<td class= "committed"><%= habit.committed.map { |d| d.titleize[0,3] }.join ', ' %></td>
</tr>
</tbody>
Update:
Another way around, which will only repeat tbody (as per your request).
<h2>Habit Challenges (<%= #habits.count %>)</h2>
<%= render partial: 'habit', locals: {habits: #habits} %>
Then change your habit partial:
<% habits.each do |habit| %>
<tbody>
<tr>
...
...
</tr>
</tbody>
<% end %>

Answer 2

That's the normal behavour if you render a collection of objects. A partial for each object in the collection is rendered.
Look at section 3.4.5 of the guides.rubyonrails.org on layouts and rendering...
http://guides.rubyonrails.org/layouts_and_rendering.html#using-partials
The habit partial should probably be edited to show only what you want to show per element in the collection. If it is currently showing only the information for the first element, then you may not be passing the object correctly to the partial. See section 3.4.6 in the above document.

Answer 3

Are they part of the same controller? If so, call the partial without the variable...
<% if #user.habits.any? %>
<h2>Habit Challenges (<%= #user.habits.count %>)</h2>
<%= render 'habits' %>
<% end %>
If not, call the partial with a local variable:
<% if #user.habits.any? %>
<h2>Habit Challenges (<%= #user.habits.count %>)</h2>
<%= render 'habits', :locals => {:habits => #habits} %>
<% end %>
If that's the case, you have to change the partial to stop using # based variable for #habits.