NSArray is not overwritting on viewDidAppear - ios

Question

I have a menu with two items, Login and Settings, displayed in a tableView. Login and Settings are stored in an NSArray. On ViewDidLoad I am checking if user exist in NSUserDefaults. If user exist then change the Login to Logout and vice versa. The issue is that on ViewDidLoad it only changes the name once when the application is opened after being cleared from cache. Therefore, in order to see the change after login in or login out you need to clear the application from cache and re-open it. I want the changes to apply immediately. Every time the menu button click before the menu open and viewDidAppear is accessed. I know this because I placed a break point and traced it. It does what is supposed to. But the it never changes the value of login to logout or vice versa.
MenuController.
-(void)ChangeLoginLabel {
NSUserDefaults *data = [NSUserDefaults standardUserDefaults];
NSString *User = [data objectForKey:#"User"];
if(User==nil) {
_extraMenuItems = [[NSMutableArray alloc] initWithObjects:#"Settings", #"Login", nil];
}
else {
_extraMenuItems = [[NSMutableArray alloc] initWithObjects:#"Settings", #"Logout", nil];
}
}
- (void)viewWillAppear:(BOOL)animated {
[self ChangeLoginLabel];
}
- (void)viewDidLoad
{
[super viewDidLoad];
[self ChangeLoginLabel];
}
- (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)sectionIndex
{
return self.extraMenuItems.count;
}
- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath
{
NSString *CellIdentifier = #"Formal";
UITableViewCell *cell = [self.extraTableView dequeueReusableCellWithIdentifier:CellIdentifier];
if (cell == nil) {
cell = [[UITableViewCell alloc] initWithStyle:UITableViewCellStyleSubtitle reuseIdentifier:CellIdentifier];
}
NSString *cellValue = [self.extraMenuItems objectAtIndex:indexPath.row];
cell.textLabel.lineBreakMode = NSLineBreakByWordWrapping;
cell.textLabel.numberOfLines = 0;
cell.textLabel.text = cellValue;
cell.textLabel.textColor = [UIColor blackColor];
return cell;
}
- (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath
{
if (indexPath.row == 0)
{
NSLog(#"Settings cell tapped!");
}
else if (indexPath.row == 1)
{
//closes when login view appears
[self.slidingViewController resetTopView];
NSString *LoginTextLabel = [self.extraMenuItems objectAtIndex:indexPath.row];
if([LoginTextLabel isEqualToString:#"Logout"]) {
}
else {
UIViewController * vc = [self.storyboard instantiateViewControllerWithIdentifier:#"Login"];
[self presentViewController:vc animated:YES completion:nil];
}
}
// Deselect the row
[tableView deselectRowAtIndexPath:indexPath animated:YES];
}
Logs
2014-12-12 13:06:53.290 xxx[1695:270056] _extraMenuItems: (
Settings,
Login
)
2014-12-12 13:07:04.290 xxx[1695:270056] _extraMenuItems: (
Settings,
Logout
)
How can I force the array to change the value immediately when the user logged in or logged out?

Answer 1

If I'm understanding correctly, you're trying to update the label in your table based on the change in NSUserDefaults as triggered by a login/logout from another view controller; so when you return to the MenuViewController, ChangeLoginLabel is triggered by the viewDidAppear, the extraMenuItems array is in fact set to contain the appropriate values, and you expect the labels in the table to change accordingly. But the problem is, that you're not reloading the table upon your return to the view.
So first off, I'd recommend removing [self ChangeLoginLabel]; from your viewDidLoad since it's redundant. And secondly, I'd recommend changing your ChangeLoginLabel method to include a table reload, like so:
-(void)ChangeLoginLabel {
NSUserDefaults *data = [NSUserDefaults standardUserDefaults];
NSString *User = [data objectForKey:#"User"];
if(User==nil) {
self.extraMenuItems = [[NSMutableArray alloc] initWithObjects:#"Settings", #"Login", nil];
}
else {
self.extraMenuItems = [[NSMutableArray alloc] initWithObjects:#"Settings", #"Logout", nil];
}
[self.tableView reloadData];
}
- (void)viewWillAppear:(BOOL)animated {
[self ChangeLoginLabel];
}
Or if you'd prefer just to reload the relevant row you can replace [self.tableView reloadData]; with:
NSIndexPath* indexPath = [NSIndexPath indexPathForRow:1 inSection:0];
[self.tableView reloadRowsAtIndexPaths:[NSArray arrayWithObject:indexPath] withRowAnimation:UITableViewRowAnimationNone];

Answer 2

Do you want viewWillAppear instead? viewDidAppear happens after the view already is rendered I believe.

Answer 3

call
- (void)viewWillAppear:(BOOL)animated {
[super viewWillAppear:animated];
[self ChangeLoginLabel];
}
or
- (void)viewDidAppear:(BOOL)animated {
[super viewDifAppear:animated];
[self ChangeLoginLabel];
}