undefined method `destroy' for nil:NilClass(rails) - ruby-on-rails

I get this error:
NoMethodError in CycleRoadsController#destroy
undefined method `destroy' for nil:NilClass(rails).
This is code from controller and theyt include a method 'destroy ':
respond_to do |format|
if #cycle_road.save
format.html { redirect_to #cycle_road, notice: 'Cycle road was successfully created.' }
format.json { render action: 'show', status: :created, location: #cycle_road }
else
format.html { render action: 'new' }
format.json { render json: #cycle_road.errors, status: :unprocessable_entity }
end
end
end
def update
respond_to do |format|
if #cycle_road.update(cycle_road_params)
format.html { redirect_to #cycle_road, notice: 'Cycle road was successfully updated.' }
format.json { head :no_content }
else
format.html { render action: 'edit' }
format.json { render json: #cycle_road.errors, status: :unprocessable_entity }
end
end
end
# DELETE /cycle_roads/1
# DELETE /cycle_roads/1.json
def destroy
#cycle_road.destroy
respond_to do |format|
format.html { redirect_to cycle_roads }
format.json { head :no_content }
end
end
private
# Use callbacks to share common setup or constraints between actions.
def set_cycle_road
#cycle_road = CycleRoad.find(params[:id])
end
def cycle_road_params
params.require(:cycle_road).permit(:name, :begin, :finish, :km, :description)
end
end
Anybody know, what's wrong?

Set the instance variable #cycle_road before calling destroy on it.
Currently its nil as the error clearly says undefined method 'destroy' for nil:NilClass.
As per the shared controller code, you would need to add destroy action in the before_action callback of set_cycle_road
class CycleRoadController < ApplicationController
before_action :set_cycle_road, only: [:show, :edit, :update, :destroy]
## ... ^
## Add this
end
This callback would take care of setting the #cycle_road instance variable before calling destroy action.

As the previous person mentioned it looks like #cycle_road is nil. Make sure that you have a before action:
class CycleRoadController < ApplicationController
...
before_action :set_cycle_road
...
And ensure that it runs for your destroy method. ie.
before_action :set_cycle_road, only: [:show, :edit, :update, :destroy]

Related

how can i access boolean value to other controller in rails

i have ProjectSite model and ManagerRemark model related to many to one association. my MangerRemark model has boolean value true and false i want to access that boolean value to other controller view. please help. here is my code.i want to print decision boolean value next to each project site index list how can i do that? in other controller name new_manager_controller view
project_sites_controller.rb
class ProjectSitesController < ApplicationController
before_action :authenticate_user!
before_action :is_project_site?, except: [:show]
before_action :set_project_site, only: [:show, :edit, :update, :destroy]
# GET /project_sites
# GET /project_sites.json
def index
#project_sites = ProjectSite.all.order("created_at DESC")
end
# GET /project_sites/1
# GET /project_sites/1.json
def show
#manager_remark = ManagerRemark.new
#manager_remark.project_site_id = #project_site.id
end
# GET /project_sites/new
def new
#project_site = ProjectSite.new
end
# GET /project_sites/1/edit
def edit
end
# POST /project_sites
# POST /project_sites.json
def create
#project_site = ProjectSite.new(project_site_params)
respond_to do |format|
if #project_site.save
format.html { redirect_to #project_site, notice: 'Project site was successfully created.' }
format.json { render :show, status: :created, location: #project_site }
else
format.html { render :new }
format.json { render json: #project_site.errors, status: :unprocessable_entity }
end
end
end
# PATCH/PUT /project_sites/1
# PATCH/PUT /project_sites/1.json
def update
respond_to do |format|
if #project_site.update(project_site_params)
format.html { redirect_to #project_site, notice: 'Project site was successfully updated.' }
format.json { render :show, status: :ok, location: #project_site }
else
format.html { render :edit }
format.json { render json: #project_site.errors, status: :unprocessable_entity }
end
end
end
# DELETE /project_sites/1
# DELETE /project_sites/1.json
def destroy
#project_site.destroy
respond_to do |format|
format.html { redirect_to project_sites_url, notice: 'Project site was successfully destroyed.' }
format.json { head :no_content }
end
end
private
# Use callbacks to share common setup or constraints between actions.
def set_project_site
#project_site = ProjectSite.find(params[:id])
end
# Never trust parameters frmanager_level_twoom the scary internet, only allow the white list through.
def project_site_params
params.require(:project_site).permit(:name, :date, :file)
end
def is_project_site?
redirect_to root_path unless (current_user.role=='project_site')
end
end
This is how my manage remark controller looks.
Manager_Remarks_controller.rb
class ManagerRemarksController < ApplicationController
def create
#manager_remark = ManagerRemark.new(remark_params)
#manager_remark.project_site_id = params[:project_site_id]
#manager_remark.save
redirect_to project_site_path(#manager_remark.project_site)
end
def remark_params
params.require(:manager_remark).permit(:name, :remark, :decision)
end
end

Rails/Actionmailer error trying to edit email

I'm using rails 4 and actionmailer to allow users to edit a generated email before letting it send.
When I try to load the editing page, I get this error.
Showing /var/www/rqm3/app/views/rfis/mail.html.erb where line #5 raised:
undefined method `body' for nil:NilClass
Here's line 5 for referrence.
<%= text_area_tag :email_body, #mail_message.html_part.body.raw_source,class:"tinymce", rows:40, cols:120 %>
I have #mail_message set from my controller here.
def mail
#mail_message = RfiMailer.send_rfi(current_user, #rfi)
end
Thanks to anyone that helps.
EDIT:
rfis_controller:
class RfisController < ApplicationController
before_action :set_rfi, only: [:show, :edit, :update, :destroy, :mail]
before_action :authenticate_user!
# GET /rfis
# GET /rfis.json
def index
#rfis = Rfi.all
end
# GET /rfis/1
# GET /rfis/1.json
def show
end
# GET /rfis/new
def new
#rfi = Rfi.new
end
# GET /rfis/1/edit
def edit
end
def send_rfi
end
def mail
#mail_message = RfiMailer.send_rfi(current_user)
# #mail_message = RfqMailer.placeholder_message(current_user, Rfq.last)
end
# POST /rfis
# POST /rfis.json
def create
#rfi = Rfi.new(rfi_params)
respond_to do |format|
if #rfi.save
format.html { redirect_to mail_rfi_url(#rfi), notice: 'Rfi was successfully created.' }
format.json { render :show, status: :created, location: #rfi }
else
format.html { render :new }
format.json { render json: #rfi.errors, status: :unprocessable_entity }
end
end
end
# PATCH/PUT /rfis/1
# PATCH/PUT /rfis/1.json
def update
respond_to do |format|
if #rfi.update(rfi_params)
format.html { redirect_to #rfi, notice: 'Rfi was successfully updated.' }
format.json { render :show, status: :ok, location: #rfi }
else
format.html { render :edit }
format.json { render json: #rfi.errors, status: :unprocessable_entity }
end
end
end
# DELETE /rfis/1
# DELETE /rfis/1.json
def destroy
#rfi.destroy
respond_to do |format|
format.html { redirect_to rfis_url, notice: 'Rfi was successfully destroyed.' }
format.json { head :no_content }
end
end
private
# Use callbacks to share common setup or constraints between actions.
def set_rfi
#rfi = Rfi.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.
def rfi_params
params.require(:rfi).permit(:due, :rfi_type, :parties, :reference, :svg_ref, :vendor_ref, :email_body)
end
end
rfi_mailer.rb
class RfiMailer < ApplicationMailer
default from:"test#test.com"
def send_rfi(user)
mail(to:"someemail", subject:"test")
end
end
first of all, some cleanup
before_action :set_rfi, only: [:show, :edit, :update, :destroy, :mail]
you can also write
before_action :set_rfi, except: [:index, :new]
back to topic
html_part is nil, thats why you cant use the body of it and it throws a exception.
please make sure that your email is having 2 templates, one for the text-part and one for the html-part. further details on that at the rails Doc
http://guides.rubyonrails.org/action_mailer_basics.html#mailer-views

protect urls in rails

I have some pages in a rails website that can be accessed only by user and admin,
I am hiding them from the public inside the views with user_signed_in?.
the problem is that when you copy and paste the url of the page when not logged in
you can still access them.
I imagine its something I need to add in the controller of those pages.
Any help would be great as I am still learning rails.
for example i would like to protect this controller
class DailiesController < ApplicationController
before_filter :authenticate_admin!, except: [:index, :show]
before_action :set_daily, only: [:show, :edit, :update, :destroy]
# GET /dailies
# GET /dailies.json
def index
#dailies = Daily.order("created_at desc")
end
# GET /dailies/1
# GET /dailies/1.json
def show
end
# GET /dailies/new
def new
#daily = current_admin.dailies.new
end
# GET /dailies/1/edit
def edit
#daily = current_admin.dailies.find(params[:id])
end
# POST /dailies
# POST /dailies.json
def create
#daily = current_admin.dailies.new(daily_params)
respond_to do |format|
if #daily.save
format.html { redirect_to #daily, notice: 'Post was successfully created.' }
format.json { render action: 'show', status: :created, location: #daily }
else
format.html { render action: 'new' }
format.json { render json: #daily.errors, status: :unprocessable_entity }
end
end
end
# PATCH/PUT /dailies/1
# PATCH/PUT /dailies/1.json
def update
#daily = current_admin.dailies.find(params[:id])
respond_to do |format|
if #daily.update(daily_params)
format.html { redirect_to #daily, notice: 'daily was successfully updated.' }
format.json { head :no_content }
else
format.html { render action: 'edit' }
format.json { render json: #daily.errors, status: :unprocessable_entity }
end
end
end
# DELETE /dailies/1
# DELETE /dailies/1.json
def destroy
#daily = current_admin.dailies.find(params[:id])
#daily.destroy
respond_to do |format|
format.html { redirect_to dailies_url }
format.json { head :no_content }
end
end
private
# Use callbacks to share common setup or constraints between actions.
def set_daily
#daily = Daily.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.
def daily_params
params.require(:daily).permit(:description, :image)
end
end
have you already created a method called authenticate_admin?
you can try something like this
before_action :has_access?
def has_access?
redirect_to root_path unless user_signed_in? && current_user.admin?
end

Customize rails generate scaffold

I have a problem, before the command "rails generate scaffold test name: string" generated controllers like this:
class Teste < ApplicationController
before_action :set_teste, only: [:show, :edit, :update, :destroy
# GET /testes
# GET /testes.json
def index
#testes = Teste.all
end
# GET /testes/1
# GET /testes/1.json
def show
end
# GET /testes/new
def new
#teste = Teste.new
end
# GET /testes/1/edit
def edit
end
# POST /testes
# POST /testes.json
def create
#teste = Teste.new(teste_params)
respond_to do |format|
if #teste.save
format.html { redirect_to testes_path, notice: 'Teste cadastrado.' }
format.json { render :show, status: :created, location: #teste }
else
format.html { render :new }
format.json { render json: #teste.errors, status: :unprocessable_entity }
end
end
end
# PATCH/PUT /testes/1
# PATCH/PUT /testes/1.json
def update
respond_to do |format|
if #teste.update(teste_params)
format.html { redirect_to testes_path, notice: 'Teste atualizado.' }
format.json { render :show, status: :ok, location: #teste }
else
format.html { render :edit }
format.json { render json: #teste.errors, status: :unprocessable_entity }
end
end
end
# DELETE /testes/1
# DELETE /testes/1.json
def destroy
#teste.destroy
respond_to do |format|
format.html { redirect_to testes_url, notice: 'Teste excluĂ­do.' }
format.json { head :no_content }
end
end
Do not know why, but this is now generating another format
class TestesController < ApplicationController
before_action :set_teste, only: [:show, :edit, :update, :destroy]
def index
#testes = Teste.all
respond_with(#testes)
end
def show
respond_with(#teste)
end
def new
#teste = Teste.new
respond_with(#teste)
end
def edit
end
def create
#teste = Teste.new(teste_params)
#teste.save
respond_with(#teste)
end
def update
#teste.update(teste_params)
respond_with(#teste)
end
What can it be? Why has this changed?
I would return in the previous format because my whole system is in the first format
The reason of this behavior is probably some gem.
I had same problem because latest version of Devise which is now shipped with Responders gem.
If this is your case too then quick fix is add following line to aplication.rb file:
config.app_generators.scaffold_controller :scaffold_controller
More info here:
https://github.com/rails/rails/issues/17290
https://github.com/plataformatec/responders/issues/94

NoMethodError in PostsController#create undefined method `text' for #<Post:0x007f99088407f8>

I've been having trouble getting past this error. It says that it 'text' is undefined.
class PostsController < ApplicationController
before_action :set_post, only: [:show, :edit, :update, :destroy]
def create
#post = Post.new(post_params)
respond_to do |format|
if #post.save # (this line is highlighted in the error)
format.html { redirect_to #post, notice: 'Post was successfully created.' }
format.json { render action: 'show', status: :created, location: #post }
else
format.html { render action: 'new' }
format.json { render json: #post.errors, status: :unprocessable_entity }
end
end
end
This worked fine when I had originally 'rails generate' the scaffold with title:string body:text.
I've been stuck on this problem all day. Suggestions would be awesome.
Your view is accessing the attribute text, but it should be body

Resources