I have been struggling all day to pass a user ID from a current user in my application to the sensors table when i create my new sensor
In the sensor Controller i have this code
def create
#sensor = Sensor.new(sensor_params)
respond_to do |format|
if #sensor.save
format.html { redirect_to #sensor, notice: 'Sensor was successfully created.' }
format.json { render action: 'show', status: :created, location: #sensor }
else
format.html { render action: 'new' }
format.json { render json: #sensor.errors, status: :unprocessable_entity }
end
end
end
def sensor_params
params.require(:sensor).permit(:name, :typeOfSensor, :privacy,:user_id)
end
I have used this code
#sensor = current_user.sensors.build(:current_user_id => params[:current_user_id])
But it passes only the id inside the sensor table without the rest of the attributes
How is the correct way to merge the code so that it passes all the parameters (name, typeOfSensor etc and also it passes the id of the user that created this sensor
Thanks in advance
are you sure you need the current_user_id from params? you already have the current user, using a param for that is dangerous, a user con edit your code and create a sensor for another user.
justo do
current_user.sensors.build(sensor_params)
and you are done
Merge is indeed the answer.
sensor_params.merge(current_user_id: current_user.id)
Related
I have two models, Livestock and History
a livestock has many histories and history belongs to livestock
This is the create method inside the LivestockController
# POST /livestocks
# POST /livestocks.json
def create
#livestock = Livestock.new(livestock_params.permit!)
respond_to do |format|
if #livestock.save
format.html { redirect_to #livestock }
flash[:success] = "Livestock was successfully created"
format.json { render :show, status: :created, location: #livestock }
else
format.html { render :new }
format.json { render json: #livestock.errors, status: :unprocessable_entity }
end
end
end
I wanted to create a record in the histories table with
history = History.new(livestock_id: #livestock.id, event: "Purchased", event_date: #livestock.purchase_date, image: #livestock.image)
history.save!
inside the create method
How can I do it? I can't put it in the create method because it says
Validation failed: Livestock must exist
apparently #livestock has not yet have the id attribute
Edit:
it still raises the same exception when I put it after
if #livestock.save
However I found a work around by using the session variable. Since it is redirected to the show page, I created the following inside the create method
session[:created] = "created"
And in my show method
# GET /livestocks/1
# GET /livestocks/1.json
def show
if session[:created] == "created"
history = History.new(livestock_id: params[:id], event: "Purchased", event_date: #livestock.purchase_date, image: #livestock.image)
history.save!
session.delete(:created)
end
end
Now I am wondering what are consequences if I use this approach.
Livestock record is created when you call save (and there is no validation error). So one option is to create the history inside this if condition:
if #livestock.save
Another option is to use after_create callback in the livestock model that will create a history object right after creating livestock. You have to be careful because the callback might be called when you do not need it (i.e. when importing data).
The last option is to create a separate service object that will create livestock and all other required objects. That's probably the best approach, but it will require more customized code.
Update
Please also make sure to move if/else block outside the respond_to block:
if #livestock.save
# create history object here
respond_to do |format|
format.html { redirect_to #livestock }
flash[:success] = "Livestock was successfully created"
format.json { render :show, status: :created, location: #livestock}
end
else
respond_to do |format|
format.html { render :new }
format.json { render json: #livestock.errors, status: :unprocessable_entity }
end
end
I have a column in my database that I'm trying to update in my controller. I'm trying to take the current logged in user's email and send it to the column in the model using the create method. It's not sending the email to the database though.
Here's my create method in the controller
def create
#request = Request.new(request_params)
respond_to do |format|
if #request.save
format.html { redirect_to #request, notice: 'Request was successfully created.' }
format.json { render :show, status: :created, location: #request }
#request.email = current_user.email
#request.increment!(:voteCount)
else
format.html { render :new }
format.json { render json: #request.errors, status: :unprocessable_entity }
end
end
end
I'm fairly certain the trouble lies in the line #request.email = current_user.email but Im not sure why.
The user model and the request models are different, so im trying to grab the data from one model and send it to another.
Sergio's comment helped me figure this out.
Added #request.save
I am trying to use the standard create method created for Ruby/Rails projects and simply pass in an additional form field that tells the method how many objects to create (vs just creating one object). The standard create method looks like so:
def create
#micropost = Micropost.new(micropost_params)
respond_to do |format|
if #micropost.save
format.html { redirect_to #micropost, notice: 'Micropost was successfully created.' }
format.json { render :show, status: :created, location: #micropost }
else
format.html { render :new }
format.json { render json: #micropost.errors, status: :unprocessable_entity }
end
end
end
I want to pass in an additional data (form field called number_to_create) which tells the method how many of the microposts to create. I just added a new form field like this, in addition to the other micropost form field params:
<%= text_field_tag :number_to_create %>
My question is how do I modify the create method code such that it creates N number of micropost objects vs. just one. So if I pass in 3 from the form along with the other micropost attributes, the method creates 3 identical micropost objects, not just one as it currently does.
Thanks in advance for your help on this.
You could use the param as times
#microposts = Micropost.transaction do
[].tap do |microposts|
param[:number_to_create].times do
microposts << Micropost.create(micropost_params)
end
end
end
respond_to do |format|
if #microposts.all? &:persisted?
format.html { redirect_to #micropost, notice: 'Micropost was successfully created.' }
format.json { render :show, status: :created, location: #micropost }
else
format.html { render :new }
format.json { render json: #micropost.errors, status: :unprocessable_entity }
end
end
The transaction block is to make sure that either all of them gets saved, or none of them gets saved, this way you can fix your errors and recreate them without worrying of getting any stray saved objects
We are developing a Rails app that integrates with an existing application. We are using Mule and restful interfaces to move data between the 2 applications.
We have a few code tables like Priority and Types that come from the old app to the new app. If we can use the same ID numbers for both applications, it will be easier to move data records that use those IDs for foreign-keys.
Is there a way to allow the ID to be one of the fields that gets updated via the Rails restful interface?
I would like this to work:
http://localhost:5000/types?type[id]=315&type[typecode]=test
This is the type controller for POST:
# POST /types
# POST /types.json
def create
#type = Type.new(params[:type])
respond_to do |format|
if #type.save
format.html { redirect_to #type, notice: 'Type was successfully created.' }
format.json { render json: #type, status: :created, location: #type }
format.xml { render xml: #type, status: :created, location: #type }
else
format.html { render action: "new" }
format.json { render json: #type.errors, status: :unprocessable_entity }
format.xml { render xml: #type.errors, status: :unprocessable_entity }
end
end
end
Right now, if I post that URL, it creates a new type record with typecode=test, but the id is the next available id instead of the one I gave it in the URL.
Thanks for the help!
Did you try this?
#type = Type.new(params[:type])
if params[:type][:id]
#type.id = params[:type][:id]
end
#type.save
I have a three part user signup that work with two separate models: User, and Customer Info. There's a user signup that I submit remotely, and it goes to the next part of the form. I want to be able to use the current_user variable when I submit the Customer Info row. The following code works when I test without remote, but it just doesn't even create the row at all when I do it with the remote. Is there another variable I can use in lieu of this variable? Or is there a better way of accomplishing this?
def create
#customer_info = CustomerInfo.new(params[:customer_info].merge(:user_id => current_user.id))
respond_to do |format|
if #customer_info.save
format.html { redirect_to tasks_url, notice: 'Customer info was successfully created.' }
format.json { render json: tasks_url, status: :created, location: #customer_info }
else
format.html { render action: "new" }
format.json { render json: #customer_info.errors, status: :unprocessable_entity }
end
end
end
Turns out it was a devise config situation. I wasn't allowing users to be unconfirmed for any amount of time, so "curent_user" was staying empty even after they signed up. I added config.allow_unconfirmed_access_for = 2.days and restarted the server and that worked.