Im working on a mapview but Its not showing the user location like I want and also the Pins, I dont know if the code is correct, I think it is, so I need your help.
Heres the code for showing the location with a zoom:
- (void)viewDidLoad
{
self.MapView.showsUserLocation = YES;
[[UIApplication sharedApplication] setStatusBarHidden:YES withAnimation:UIStatusBarAnimationNone];
coordinateuser.latitude = self.MapView.userLocation.coordinate.latitude;
coordinateuser.longitude = self.MapView.userLocation.coordinate.longitude;
MKCoordinateRegion region = MKCoordinateRegionMakeWithDistance(coordinateuser, 1200, 1200);
double delayInSeconds = 2.0;
dispatch_time_t popTime = dispatch_time(DISPATCH_TIME_NOW, (int64_t)(delayInSeconds * NSEC_PER_SEC));
dispatch_after(popTime, dispatch_get_main_queue(), ^(void){
[self.MapView setRegion:region animated:YES];
});
[super viewDidLoad];
}
And heres the code for displaying a MKPinAnnotationView, this is the one that I think is wrong:
- (MKAnnotationView *)mapView:(MKMapView *)mapView viewForAnnotation:(id <MKAnnotation>)annotation{
static NSString *SFAnnotationIdentifier = #"SFAnnotationIdentifier";
MKPinAnnotationView *pinView =
(MKPinAnnotationView *)[mapView dequeueReusableAnnotationViewWithIdentifier:SFAnnotationIdentifier];
if (!pinView)
{
MKAnnotationView *annotationView = [[MKAnnotationView alloc] initWithAnnotation:annotation reuseIdentifier:SFAnnotationIdentifier];
return annotationView;
}
else
{
pinView.annotation = annotation;
}
cmtlocation = CLLocationCoordinate2DMake(19.502519,-99.259779);
//UIImage *flagImage = [UIImage imageNamed:#"flag.png"];
//annotationView.image = flagImage;
[annotation setCoordinate:cmtlocation];
return pinView;
}
So I will appreciate your help! Thanks!
Actually, it's the other way around than what the other answer says:
If the dequeue returns nil, code is creating an empty MKAnnotationView.
MKAnnotationView is empty by default so the annotations (including the user location) are invisible. At the top of viewForAnnotation, check if annotation is of type MKUserLocation and return nil. For other annotations, create an MKAnnotationView if you want to use a custom image. Otherwise, create (alloc+init) an MKPinAnnotationView which automatically provides a pin image.
Additionally...
You are not even calling addAnnotation for your custom annotation. You should not be setting the annotation's coordinate in the viewForAnnotation method. Instead, you should be creating an annotation object (eg. in viewDidLoad), setting its coordinate and title and then calling addAnnotation.
Also, in viewDidLoad, you are trying to access the user location coordinates immediately after setting showsUserLocation to YES. The user location will not be available immediately. Instead, move the setRegion call to the didUpdateUserLocation delegate method (or just set userTrackingMode to MKUserTrackingModeFollow).
I think your code is wrong, as you expected: If
MKPinAnnotationView *pinView = (MKPinAnnotationView *)[mapView dequeueReusableAnnotationViewWithIdentifier:SFAnnotationIdentifier];
does not return nil, you return just another annotation view:
MKAnnotationView *annotationView = [[MKAnnotationView alloc] initWithAnnotation:annotation reuseIdentifier:SFAnnotationIdentifier];
return annotationView;
Otherwise, you try to set a property of a nil object:
pinView.annotation = annotation;
and then do something else before returning nil:
cmtlocation = CLLocationCoordinate2DMake(19.502519,-99.259779);
//UIImage *flagImage = [UIImage imageNamed:#"flag.png"];
//annotationView.image = flagImage;
[annotation setCoordinate:cmtlocation];
return pinView;
Related
After uploading a custom image for the MKPinAnnotationView, I noticed that the pin was off-centered. The pin is supposed to be on a point on the route's polyline, and in the center of an mkcircle; however, the pin seems to be to the right of the polyline and a little north of the center. I tried experimenting with the centerOffset property, but when I plug values into the property, nothing seems to change. Here is the code,
-(MKAnnotationView *)mapView:(MKMapView *)mapView viewForAnnotation:(id <MKAnnotation>)annotation{
static NSString *viewID = #"MKPinAnnotationView";
MKPinAnnotationView *annotationView = (MKPinAnnotationView*)
[self.mapView dequeueReusableAnnotationViewWithIdentifier:viewID];
if(annotationView ==nil){
annotationView = [[MKPinAnnotationView alloc]initWithAnnotation:annotation reuseIdentifier:viewID];
}
annotationView.image = [UIImage imageNamed:#"Pin.png"];
annotationView.enabled = YES;
//doesn't move the pin, still offcentered
annotationView.centerOffset = CGPointMake(0,-50);
return annotationView;
}
Just something to add, I also noticed that with the new pin image, nothing pops up when I click on the pin. Before, with the default pin, a bubble of text would appear after clicking on the pin. Since this is the case, I want to include the code for the method that makes and places the pin on the map,
-(void) createAndAddAnnotationForCoordinate : (CLLocationCoordinate2D)coordinate{
MKPointAnnotation* annotation = [[MKPointAnnotation alloc]init];
annotation.coordinate = coordinate;
annotation.title = #"This is a pin!";
[mapView addAnnotation:annotation];
}
I also tried changing the pin image to see if that would influence the positioning of the MKPinAnnotationView. Although I was able to center the pin by editing the image, it isn't centered for other polylines. Any help would be appreciated!
First, an important point is that when using a custom annotation image, it's best to use the plain MKAnnotationView class instead of its subclass MKPinAnnotationView which is designed to automatically display a standard pin image.
This is because MKPinAnnotationView includes some built-in adjustments of the annotation view's frame and centerOffset based on its own pin image. In some cases, your custom image will even be replaced on the screen with the default pin image. So even though MKPinAnnotationView has an image property, the class will not always use it as expected.
Second, set the centerOffset such that as the map is zoomed, the part of the image that "points" to the coordinate keeps pointing to the coordinate. This is because the centerOffset is in screen CGPoints and does not scale with the zoom level of the map. If the centerOffset is not set properly, the "point" of the image will start to drift from the target coordinate.
Also note you may not even need to set centerOffset since the default will put the center of the image at the coordinate which you may be ok with.
Based on the image you posted, here is the code and resulting appearance without setting centerOffset (leaving it at the default):
-(MKAnnotationView *)mapView:(MKMapView *)mapView viewForAnnotation:(id <MKAnnotation>)annotation{
static NSString *viewID = #"MKPinAnnotationView";
MKAnnotationView *annotationView = [mapView dequeueReusableAnnotationViewWithIdentifier:viewID];
if (annotationView ==nil) {
annotationView = [[MKAnnotationView alloc] initWithAnnotation:annotation reuseIdentifier:viewID];
annotationView.image = [UIImage imageNamed:#"Pin.png"];
annotationView.canShowCallout = YES;
}
else {
annotationView.annotation = annotation;
}
return annotationView;
}
(I added the red center lines to show where the target coordinate is relative to the pin image.)
Here is the code and resulting appearance with centerOffset set so that the bottom points to the coordinate:
-(MKAnnotationView *)mapView:(MKMapView *)mapView viewForAnnotation:(id <MKAnnotation>)annotation{
static NSString *viewID = #"MKPinAnnotationView";
MKAnnotationView *annotationView = [mapView dequeueReusableAnnotationViewWithIdentifier:viewID];
if (annotationView ==nil) {
annotationView = [[MKAnnotationView alloc] initWithAnnotation:annotation reuseIdentifier:viewID];
annotationView.image = [UIImage imageNamed:#"Pin.png"];
annotationView.canShowCallout = YES;
annotationView.centerOffset = CGPointMake(0,-15);
}
else {
annotationView.annotation = annotation;
}
return annotationView;
}
You have to set MKCoordinateRegion to load the map, edit your createAndAddAnnotationForCoordinate method as below
-(void) createAndAddAnnotationForCoordinate : (CLLocationCoordinate2D)coordinate{
MKCoordinateRegion viewRegion = MKCoordinateRegionMakeWithDistance(coordinate, 3000, 3000); //Set zooming level
MKCoordinateRegion adjustedRegion = [mapView regionThatFits:viewRegion]; //add location to map
[mapView setRegion:adjustedRegion animated:YES]; // create animation zooming
MKPointAnnotation* annotation = [[MKPointAnnotation alloc]init];
annotation.coordinate = coordinate;
annotation.title = #"This is a pin!";
[mapView addAnnotation:annotation];
}
I have a map on which I want to display both custom annotations with images and one default looking annotation with a red pin.
I've made my view into a map delegate in order to load the custom images, but what happens is that the default looking pin I want is not showing (since I don't load an image for it).
I'm adding a shortened version of my code below (with remarks).
How can I load an image for this pin? Is there a standard way to access the pin UIImage, or should I make the annotation somehow?
- (MKAnnotationView *)mapView:(MKMapView *)theMapView viewForAnnotation:(id <MKAnnotation>)annotation
{
static NSString *SFAnnotationIdentifier = #"SFAnnotationIdentifier";
MKPinAnnotationView *pinView =
(MKPinAnnotationView *)[self.mapView dequeueReusableAnnotationViewWithIdentifier:SFAnnotationIdentifier];
MKPointAnnotation* pointAnnotation = (MKPointAnnotation*)annotation;
if (!pinView)
{
MKAnnotationView *annotationView = [[MKAnnotationView alloc] initWithAnnotation:annotation
reuseIdentifier:SFAnnotationIdentifier];
for (id location in self.locations) {
// if this is a "special" point loaded
if () {
UIImage *image = ; // get custom image from somewhere
annotationView.image = image;
return annotationView;
}
}
// if the code made here, I want the pin to be regular
return annotationView;
}
else
{
pinView.annotation = annotation;
}
return pinView;
}
OK, solved it.
return nil;
does the trick and gives the default view.
Change
UIImage *image = ; // get custom image from somewhere
to
UIImage *image = [UIImage imageNamed:#"YourPin.png"]; // get custom image from somewhere
And maybe you need to change the offset of annotationView
annotationView.centerOffset = CGPointMake( 0, annotationView.centerOffset.y - annotationView.image.size.height/2 );
I am trying to show some pins from an array, it shows them all but they are red, and not green as i ask them to be.
Why is that ?
//run on array to get all locations
for(int k=0;k<[array count];k=k+2)
{
float targetlat=[[array objectAtIndex:k] floatValue];
float targetlongi=[[array objectAtIndex:k+1] floatValue];
CLLocationCoordinate2D location = CLLocationCoordinate2DMake(targetlat,targetlongi);
NSString *partyTitle = #"title";
MKPinAnnotationView *partyPin = [self returnPointView:location andTitle:partyTitle andColor:MKPinAnnotationColorGreen];
[self.mapView addAnnotation:partyPin.annotation];
}
//function callback is working but its red, and it takes so much time to load
-(MKPinAnnotationView*) returnPointView: (CLLocationCoordinate2D) location andTitle: (NSString*) title andColor: (int) color
{
MKCoordinateRegion region = self.mapView.region;
region.center = location;
region.span.longitudeDelta /= 5.0;
region.span.latitudeDelta /= 5.0;
[self.mapView setRegion:region];
MKPointAnnotation *resultPin = [[MKPointAnnotation alloc] init];
MKPinAnnotationView *result = [[MKPinAnnotationView alloc] initWithAnnotation:resultPin reuseIdentifier:Nil];
[resultPin setCoordinate:location];
resultPin.title = title;
result.pinColor = color;
return result;
}
Regarding the main issue that the pins are red instead of green:
The code creates an MKPinAnnotationView but this view is never given to the map view.
To make the map view use annotation views that you create, you must implement the viewForAnnotation delegate method and return them from there.
Otherwise, the map view has no knowledge of annotation views that you create.
If you don't implement viewForAnnotation, the map view creates a default red pin view.
Regarding the second issue that "it takes so much time to load":
The most likely reason for this is that you are calling setRegion each time you add an annotation.
If you are adding, say, 500 annotations, the map view is setting the region 500 times.
Please note that it is not necessary to call setRegion simply to add an annotation (regardless of the currently-visible region). The annotation's coordinate does not have to be "visible" to add an annotation there.
What you want to do inside the for loop is simply construct a region that includes all the annotations and then call setRegion (or setVisibleRect) once and after all the annotations are added (after the for loop). Constructing an MKMapRect and calling setVisibleMapRect is easier than constructing an MKCoordinateRegion in order to call setRegion.
In iOS 7, this is even simpler: Just call showAnnotations (no manual construction necessary).
Example:
//Initialize the MKMapRect (region) we want to show to null...
MKMapRect showMapRect = MKMapRectNull;
for(int k=0;k<[array count];k=k+2)
{
float targetlat=[[array objectAtIndex:k] floatValue];
float targetlongi=[[array objectAtIndex:k+1] floatValue];
CLLocationCoordinate2D location = CLLocationCoordinate2DMake(targetlat,targetlongi);
NSString *partyTitle = #"title";
//Here, don't create the annotation view.
//Just create the annotation...
MKPointAnnotation *resultPin = [[MKPointAnnotation alloc] init];
[resultPin setCoordinate:location];
resultPin.title = partyTitle;
[self.mapView addAnnotation:resultPin];
//Add this annotation's coordinate
//to the MKMapRect we want to show...
MKMapPoint annMapPoint = MKMapPointForCoordinate(location);
MKMapRect annMapRect = MKMapRectMake(annMapPoint.x, annMapPoint.y, 0, 0);
showMapRect = MKMapRectUnion(showMapRect, annMapRect);
}
mapView.visibleMapRect = showMapRect;
//In iOS 7, instead of constructing MKMapRect manually,
//we could just call showAnnotations...
//[mapView showAnnotations:mapView.annotations animated:YES];
//Implement the viewForAnnotation delegate method...
-(MKAnnotationView *)mapView:(MKMapView *)mapView viewForAnnotation:(id<MKAnnotation>)annotation
{
//if annotation is the user location,
//return nil so map view shows default view for it (blue dot)...
if ([annotation isKindOfClass:[MKUserLocation class]])
{
return nil;
}
static NSString *reuseId = #"pin";
MKPinAnnotationView *pav = (MKPinAnnotationView *)[mapView dequeueReusableAnnotationViewWithIdentifier:reuseId];
if (pav == nil)
{
pav = [[MKPinAnnotationView alloc] initWithAnnotation:annotation reuseIdentifier:reuseId];
pav.canShowCallout = YES;
pav.animatesDrop = YES;
pav.pinColor = MKPinAnnotationColorGreen;
}
else
{
pav.annotation = annotation;
}
return pav;
}
I am making an App in xCode with an MKMapView and MKAnnotations. If you make more than two annotations the extra waypoints colors (PinAnnotations) should be changed to purple.
Therefore I need something like a tag, IndexPath or ID from the annotation to identify the MKAnnotation in the MKAnnotation functions. I used this line of code:
- (MKAnnotationView *)mapView:(MKMapView *)mapView viewForAnnotation:(id<MKAnnotation>)annotation
{
MKPinAnnotationView *pinView = nil;
if (annotation != mkMap.userLocation)
{
static NSString *defaultPinID = #"aPin";
pinView = (MKPinAnnotationView *)[mkMap dequeueReusableAnnotationViewWithIdentifier:defaultPinID];
if (pinView == nil)
{
pinView = [[MKPinAnnotationView alloc] initWithAnnotation:annotation reuseIdentifier:defaultPinID];
pinView.canShowCallout = YES;
pinView.tag = mapView.annotations.count; // tag is not available for annotation in this function
}
}
pinView.canShowCallout = YES;
pinView.animatesDrop = YES;
pinView.draggable = YES;
if ([annotation isKindOfClass:[MKUserLocation class]])
return pinView;
NSLog(#"Annotation-Index: %d", [mapView.annotations indexOfObject:annotation]);
NSLog(#"MapView.annotations.count = %d", mapView.annotations.count);
if (1 == [mapView.annotations indexOfObject:annotation])
pinView.pinColor = MKPinAnnotationColorGreen;
else if (1 < [mapView.annotations indexOfObject:annotation])
{
pinView.pinColor = MKPinAnnotationColorRed;
// checkes for extra waypoints
if (2 < mapView.annotations.count)
{
for (int i = 2; i > mapView.annotations.count; i++)
{
MKPinAnnotationView *aView = [mapView.annotations objectAtIndex:i];
aView.pinColor = MKPinAnnotationColorPurple;
[mapView removeAnnotation:mapView.annotations[i]];
NSMutableArray *a = [[NSMutableArray alloc] init];
[a replaceObjectAtIndex:i withObject:aView];
[mapView addAnnotations:a];
}
}
}
return pinView;
}
I already google this question and found a number of solutions like I did
int AnnotationIndex = [mapView.annotations indexOfObject:annotation];
but the the output of this function (Annotation-Index) strikes my mind. Sometimes everything is fine but and the Annotation-Index has the right value but most of the time the values seems to be generated randomly and the scale goes from 0 up to 10 also if the MapView.annotations.count is just 3!
Best regards and thanks!
The recommended way of handling this is to make your own class that implements the MKAnnotation protocol and has a property that you can check during viewForAnnotations to see what colour to use. The annotations array from MKMapView is not guaranteed to be in the order in which you add annotations to the map. You may add annoy, annoy and then annoy but you may get back [anno2, anno3, anno1]. That's just the way it is and you can't change that. So, you could keep your own array of annotations that won't get rearranged. Or use the extra property idea if that will suit.
One thing you should not do is add more annotations during the viewForAnnotation function, that's really messed up.
I'm having great trouble figuring out what I'm doing wrong here...
I am adding annotations to my mapview through loops, but the annotation image is completely random every time... when I NSLog the order, it's random - i'm not sure if that is the problem.
- (MKAnnotationView *)mapView:(MKMapView *)mapView1 viewForAnnotation:(id<MKAnnotation>)annotation {
if ([annotation isKindOfClass:[MKUserLocation class]])
return nil;
if ([[annotation subtitle] isEqual:#"Bar"]) {
MKAnnotationView *view = nil;
view = [self.mapView dequeueReusableAnnotationViewWithIdentifier:#"myAnnotationIdentifier"];
if (!view) {
// Could not reuse a view ...
// Creating a new annotation view
view = [[MKAnnotationView alloc] initWithAnnotation:annotation reuseIdentifier:#"myAnnotationIdentifier"];
view.enabled = YES;
view.canShowCallout = YES;
view.rightCalloutAccessoryView = [UIButton buttonWithType:UIButtonTypeDetailDisclosure];
view.image = [UIImage imageNamed:#"beer.png"];
}
return view;
}
else if ([[annotation subtitle] isEqual:#"Club"]) {
MKAnnotationView *view = nil;
view = [self.mapView dequeueReusableAnnotationViewWithIdentifier:#"myAnnotationIdentifier"];
if (!view) {
// Could not reuse a view ...
// Creating a new annotation view
view = [[MKAnnotationView alloc] initWithAnnotation:annotation reuseIdentifier:#"myAnnotationIdentifier"];
view.enabled = YES;
view.canShowCallout = YES;
view.rightCalloutAccessoryView = [UIButton buttonWithType:UIButtonTypeDetailDisclosure];
view.image = [UIImage imageNamed:#"clubs.png"];
}
return view;
}
}
the view.image is totally random... either clubs.png or beer.png..
How do I make it correctly?
this is how I add the annotations:
- (void)barLoop {
for (int i = 0; i<barArray.count; i++) {
int index = [[barArray objectAtIndex:i]intValue];
NSString *lati = [[[self.usersLocationArray objectAtIndex:index]
valueForKeyPath:#"items.Latitude"]componentsJoinedByString:#""];
NSString *longi = [[[self.usersLocationArray objectAtIndex:index]
valueForKeyPath:#"items.Longitude"]componentsJoinedByString:#""];
NSString *barNavn = [[[self.usersLocationArray objectAtIndex:index] valueForKeyPath:#"items.Navn"]componentsJoinedByString:#""];
float latitude = [lati floatValue];
float longitude = [longi floatValue];
MKCoordinateRegion region = { {0.0, 0.0} , {0.0, 0.0} };
region.center.latitude = latitude;
region.center.longitude = longitude;
region.span.longitudeDelta = 0.20f;
region.span.latitudeDelta = 0.20f;
[mapView setRegion:region animated:NO];
CLLocationCoordinate2D location;
location.latitude = latitude;
location.longitude = longitude;
Annotation *ann = [[Annotation alloc]initWithPosition:location];
ann.title = barNavn;
ann.subtitle = #"Bar";
[self.mapView addAnnotation:ann];
}
}
thanks in advance :)
You have two types of annotations, but you are only setting the image when the annotation is originally created. Thus, if an annotation for a bar scrolls off the map view and another annotation for a club scrolls on, it might reuse the bar's annotation view for the club.
There are two ways of fixing this:
Use different reuseIdentifier parameters for each of the two types of annotation views; or
Set/reset the annotation view's image regardless of whether your call to dequeueReusableAnnotationViewWithIdentifier succeeded in returning a value or not.
Unrelated, but your viewForAnnotation method should:
You might want to use isEqualToString instead of isEqual when checking for #"Bar" vs #"Club".
Make sure to return nil if neither of those if clauses return true (this should never happen, but nonetheless you have a potential path in this routine in which you neglect to return any value). I would guess that this would have been brought to your attention if you ran the code through the static analyzer ("Analyze" on Xcode's "Product" menu).
A more subtle observation, but I'd probably not rely upon the annotation's subtitle for determining which annotation view to employ, but rather either
have two annotation subclasses, one for bars and one for clubs; or
have a custom property in your existing Annotation class that indicates whether it's a bar or club (and I'd probably use an enum for that).
At some future date, you might want to use the callout's subtitle for something other than "Bar" vs "Club" (e.g., maybe the address of the bar/club?), and the current model seems to conflate a UI attribute (i.e. what shows up in the callout) with a state property (i.e. a variable that controls which annotation view type to use). Not a big deal, but just an suggestion.