def new
#host = Host.find(params[:id])
#lastreview = Review.where("user_id = ? AND host_id = ?", current_user[:id], #host.id)
if #lastreview == nil
#review = Review.new
else
redirect_to #host, notice: "You already posted a review for this host!"
end
end
For some reason it is not returning nil even though their are no reviews? Am I misunderstanding the usage?
where returns an array - if there are no reviews in your table that match your conditions, the array that it returns will be empty, but it will never be nil.
Try this instead:
if #lastreview.empty?
#review = Review.new
else
redirect_to #host, notice: "You already posted a review for this host!"
end
If you don't actually need the last records, you can use exists?:
Returns true if a record exists in the table that matches the id or conditions given, or false otherwise.
This should work (Rails can handle the _id suffixes if everything is set up correctly):
def new
#host = Host.find(params[:id])
if Review.exists?(user: current_user, host: #host)
#review = Review.new
else
redirect_to #host, notice: "You already posted a review for this host!"
end
end
Related
Hi I'm coding coupon system rails 5.2.3 .
But I have a problem. If coupon code is entered before payment, discount is applied. But I can't update the total price if the product is deleted from the cart.
Order Model: Every update calculating price
def subtotal
price = order_items.includes(:product).collect { |oi| oi.valid? ? (oi.quantity * oi.unit_price) : 0 }.sum
end
Coupon Controller
def check_coupon_code
if #coupon = Coupon.find_by(code: params[:code])
coupın = Coupon.find_by(code: params[:code])
#order = current_order
if #coupon[:redemption_limit] > 0 and #coupon[:active] === true
#order.total_amount = current_order.subtotal - coupın.amount
#order.update(order_param)
Coupon.transaction do
Coupon.where(code: params[:code]).each do |coupon|
coupon.redemption_limit = coupon.redemption_limit - 1
coupon.save
end
end
#order.update(code_apply)
redirect_to "/cart"
flash[:notice] = 'Coupon Code Applied!'
else
redirect_to "/cart"
flash[:danger] = 'Coupon Code Invalid!'
end
else
redirect_to "/cart"
flash[:danger] = 'Coupon Code Invalid!'
end
end
Order Item Controller
def update
#order = current_order
#order_item = #order.order_items.find(params[:id])
#order_item.update_attributes(order_item_params)
#order_items = #order.order_items
end
def destroy
#order = current_order
#order_item = #order.order_items.find(params[:id])
#order_item.destroy
#order_items = #order.order_items
end
Based on our discussion in the comments, I'm assuming order_items have coupon_id as a field which is either empty(if no coupon code is applied), or contains the id of the code applied to order_items.
Now, updating the price of the order as per deletion could be done using a before_destroy callback in order_item model. You could do something as follows:
# order_item.rb
before_destroy :update_order_price
private
def update_order_price
# Your logic to recalculate the order price
end
NOTE: Calling another model's methods from a callback on one model can be a bit difficult to maintain in the long term. In that case, you could use an event driven mechanism in case this app becomes really large
I wanted to use #reload.status = boolean (true or false) but i could not get the boolean to be save into the database.
Also, i had been doing this all the time but it doesn't work now.
def return
ret = ActiveMerchant::Billing::Integrations::Ipay88::Notification.new(request.raw_post)
if ret.success?
#reload = Reload.find(ret.item_id)
#reload.status = true
#reload.save
redirect_to new_reload_path, notice: "Success"
else
#reload = Reload.find(ret.item_id)
#reload.status = false
redirect_to new_reload_path, notice: 'Reload unsuccessful'
end
end
I forgot to add #reload.save for the 'false' statement. (just like you see in "ret.success?" method call)
I'm creating a simple upvote/downvote system similar to reddit's, where users can upvote/downvote something and change their minds if need be.
I have a page that makes an AJAX call to the 'create' action of my controller. The controller has no problem creating the record and returning the proper js.erb. However, I'd like to see if an existing post exists, and if so, I'd like to destroy it. My controller looks like this:
def create
#vote = GameVote.new
#vote.game_id = params[:game_id]
#vote.vote = params[:vote]
#vote.user_id = session[:user_id]
existing_vote = GameVote.where(whatever)
respond_to do |format|
if #vote.save
format.js
end
end
end
It just seems to ignore the middle query, preventing me from destroying it if it exists before attempting to save the new entry. Any ideas?
It seems more natural to update the existing GameVote (if one exists) instead of pair delete+create.
To do so just replace:
#vote = GameVote.new
#vote.game_id = params[:game_id]
#vote.vote = params[:vote]
#vote.user_id = session[:user_id]
existing_vote = GameVote.where(whatever)
with:
#vote = GameVote.where(game_id: params[:game_id], user_id: session[:user_id]).first_or_initialize
#vote.vote = params[:vote]
Try :
#vote = GameVote.find_or_create_by_game_id_and_user_id(params[:game_id], session[:user_id])
OR
#vote = GameVote.find_or_create(:game_id => params[:game_id], :user_id => session[:user_id])
#vote.vote = params[:vote]
so I have this big method in my application for newsletter distribution. Method is for updating rayons and I need to assign a user to rayon. I have relation n:n through table colporteur_in_rayons which has attributes since_date and until_date.
I am a junior programmer and I know this code is pretty dummy :)
I appreciate every suggestion.
def update
rayon = Rayon.find(params[:id])
if rayon.update_attributes(params[:rayon])
if params[:user_id] != ""
unless rayon.users.empty?
unless rayon.users.last.id.eql?(params[:user_id])
rayon.colporteur_in_rayons.last.update_attributes(:until_date => Time.now)
Rayon.assign_user(rayon.id,params[:user_id])
flash[:success] = "Rayon #{rayon.name} has been succesuly assigned to #{rayon.actual_user.name}."
return redirect_to rayons_path
end
else
Rayon.assign_user(rayon.id,params[:user_id])
flash[:success] = "Rayon #{rayon.name} has been successfully assigned to #{rayon.actual_user.name}."
return redirect_to rayons_path
end
end
flash[:success] = "Rayon has been successfully updated."
return redirect_to rayons_path
else
flash[:error] = "Rayon has not been updated."
return redirect_to :back
end
end
def update
rayon = Rayon.find(params[:id])
unless rayon.update_attributes(params[:rayon])
flash[:error] = "Rayon not updated."
return redirect_to :back
end
puid = params[:user_id]
empty = rayon.users.empty?
if puid == "" or (not empty and rayon.users.last.id.eql?(puid))
msg = "Rayon updated.",
else
msg = "Rayon #{rayon.name} assigned to #{rayon.actual_user.name}.",
rayon.colporteur_in_rayons.last.update_attributes(
:until_date => Time.now) unless empty
Rayon.assign_user(rayon.id, puid)
end
flash[:success] = msg[msg_i]
return redirect_to rayons_path
end
there was a some double code. So remove that. But also, there is some business code in the controller, which should not be there. So i should refactor the controller code as follows:
def update
rayon = Rayon.find(params[:id])
if rayon.update_attributes(params[:rayon])
if params[:user_id] != ""
rayon.handle_update_user(params[:user_id]
flash[:success] = "Rayon #{rayon.name} has been succesuly assigned to #{rayon.actual_user.name}."
else
flash[:success] = "Rayon has been successfully updated."
end
return redirect_to rayons_path
else
flash[:error] = "Rayon has not been updated."
return redirect_to :back
end
end
The controller method now clearly deals with the actions that need to be taken, and sets a flash method accordingly if needed.
In the Rayon model you write the code what needs to be done when an update is done by a user:
class Rayon
def handle_update_user(user_id)
if (!users.empty? && users.last.id.eql?(params[:user_id]))
# do nothing!
else
colporteur_in_rayons.last.update_attributes(:until_date => Time.now) unless users.empty?
Rayon.assign_user(rayon.id,params[:user_id])
end
end
end
This clearly seperates the concerns. A rayon should know what happens when a user updates it (the name of the function could be improved to what you actually want it to mean, as that is not entirely clear to me).
It could be shorter, but i like to write explicitely that nothing needs to be done if the last user is the same as the current. Otherwise, actions need to be taken. If i understood correctly.
Here's my take at it. I put a bunch of comments inline describing why I changed what I did.
def update
rayon = Rayon.find(params[:id])
if rayon.update_attributes(params[:rayon])
user_id = params[:user_id] # using same value a couple times
# if-else strongly preferred over unless-else...
# so replace `unless foo.empty?` with `if foo.length > 0`
if user_id.length > 0 # then string != ""
# `if A && B` more readable than `unless X || Y` in my opinion
if rayon.users.length > 0 && rayon.users.last.id != user_id
rayon.colporteur_in_rayons.last.update_attributes(:until_date => Time.now)
end
# same line in if-else; pull outside
Rayon.assign_user(rayon.id, user_id)
flash[:success] = "Rayon #{rayon.name} has been successfully assigned to #{rayon.actual_user.name}."
else
flash[:success] = "Rayon has been successfully updated."
end
# all branches in here return this value, pull outside
return redirect_to rayons_path
else
flash[:error] = "Rayon has not been updated."
return redirect_to :back
end
end
The largest issue I noticed with your code is that you had a lot of duplication in your first if-block. All the branches in the true section reached return redirect_to rayons_path, so that got pulled to the end of the block. You had the same flash[:success] = ... twice, so that got pulled out as well.
if-else is much more readable than unless-else, so try to avoid using the latter. I'm not a fan of one unless immediately nested inside another, so I changed that to a compound if-statement.
One of the primary idioms in Rails is DRY (Don't Repeat Yourself), so try to identify spots where you do have repetitive code.
(Also note that I haven't tested this refactoring -- I'm pretty sure that the logic is still the same, but I can't prove it.)
def update
rayon = Rayon.find(params[:id])
unless rayon.update_attributes(params[:rayon])
flash[:error] = "Rayon has not been updated."
return redirect_to :back
end
if params[:user_id].empty?
msg = "Rayon has been successfully updated."
else
if rayon.users.empty?
Rayon.assign_user(rayon.id,params[:user_id])
msg = "Rayon #{rayon.name} has been successfully assigned to #{rayon.actual_user.name}."
elsif not rayon.users.last.id.eql?(params[:user_id])
rayon.colporteur_in_rayons.last.update_attributes(:until_date => Time.now)
Rayon.assign_user(rayon.id,params[:user_id])
msg = "Rayon #{rayon.name} has been succesuly assigned to #{rayon.actual_user.name}."
end
end
flash[:success] = msg
return redirect_to rayons_path
end
Could anyone help with this problem:
Upon "create", the user is redirected to the url: model/model_id (eg post/1), instead I am redirected to models/url_encoding_object (eg posts/.%23) and there is an "406 Not Acceptable" message in the console.
Typically, upon create, the console's message is "Processing PostsController#create (for 000.0.0.0 at 2009-11-23 12:32:52) [POST]", but with this error, the message is "Processing PostsController#create to # (for 000.0.0.0 at 2009-11-23 12:32:52) [POST]"
I've seen austinfromboston's response and tried his "old fashioned but effective" solution to that similar problem, but it doesn't work for me.
Any help would be greatly appreciated
Controller Code:
# POST /groups
# POST /groups.xml
def create
#group = Group.new(params[:group])
#group.category = params[:category]
#group.user = current_user
#here we add the current user to the membership collection of the group
#membership = #group.memberships.build(params[:membership])
#membership.group = #group
#membership.user = current_user
#membership.initiator = false
#membership.membership_status_id = 2
#and here we set the current_user as the owner of the group
#group_permission = #group.group_permissions.build(params[:group_permission])
#group_permission.membership = #membership
#group_permission.group_role = GroupRole.find_by_name('Owner')
unless params[:metro_area_id].blank?
#group.metro_area = MetroArea.find(params[:metro_area_id])
#group.state = (#group.metro_area && #group.metro_area.state) ?
#group.metro_area.state : nil
#group.country = #group.metro_area.country if (#group.metro_area &&
#group.metro_area.country)
else
#group.metro_area = #group.state = #group.country = nil
end
#group.tag_list = params[:tag_list] || ''
# unless #user.is_in_group?(#group)
# #user.memberships << #group
# end
respond_to do |format|
if #group.save
flash[:notice] = :group_was_successfully_created.l
format.html { redirect_to(group_path(#group.id)) }
else
format.html {
#metro_areas, #states = setup_metro_area_choices_for(#group)
if params[:metro_area_id]
#metro_area_id = params[:metro_area_id].to_i
#state_id = params[:state_id].to_i
#country_id = params[:country_id].to_i
end
render :action => "new"
}
end
end
end
Looks like either your routes are off somewhere or your model_id parameter is not what you are expecting. Might want to check to see what that parameter is being set to.
It's also really hard to give any suggestions without seeing controller code. Can you post the method making this call?
There's a lot of superfluous code, in your controller. It still works, but you're doing a lot of things the hard way.
Your problem is this line:
format.html { redirect_to(groups_path(#group.id)) }
Which redirects to the collective groups url adding the parameter #group.id.
What it should be is
format.html { redirect_to(group_path(#group.id)) }
# POST /groups
# POST /groups.xml
def create
#group = Group.new(params[:group])
#group.category = params[:category]
#group.user = current_user
#here we add the current user to the membership collection of the group
#membership = #group.memberships.build(params[:membership])
#membership.group = #group
#membership.user = current_user
#membership.initiator = false
#membership.membership_status_id = 2
#and here we set the current_user as the owner of the group
#group_permission = #group.group_permissions.build(params[:group_permission])
#group_permission.membership = #membership
#group_permission.group_role = GroupRole.find_by_name('Owner')
unless params[:metro_area_id].blank?
#group.metro_area = MetroArea.find(params[:metro_area_id])
#group.state = (#group.metro_area && #group.metro_area.state) ? #group.metro_area.state : nil
#group.country = #group.metro_area.country if (#group.metro_area && #group.metro_area.country)
else
#group.metro_area = #group.state = #group.country = nil
end
#group.tag_list = params[:tag_list] || ''
unless #user.is_in_group?(#group)
#user.memberships << #group
end
respond_to do |format|
if #group.save
flash[:notice] = :group_was_successfully_created.l
format.html { redirect_to(groups_path(#group.id)) }
else
format.html {
#metro_areas, #states = setup_metro_area_choices_for(#group)
if params[:metro_area_id]
#metro_area_id = params[:metro_area_id].to_i
#state_id = params[:state_id].to_i
#country_id = params[:country_id].to_i
end
render :action => "new"
}
end
end
end
What is this .1 doing at the end of the line??
flash[:notice] = :group_was_successfully_created.l
I tried to run similar code in my environment and it choked on that.
It should also reference:
group_path(id)
not
groups_path(id)