Delphi - procedure return a error - delphi

Question

I'm having problems in my code but can not find the solution, already modified in various ways but no success.
Code:
private
{ Private declarations }
procedure getImgInfo(Sender: TObject; A, B: String);
And:
procedure TfMain.Button1Click(Sender: TObject);
var
i, Idx, Left, Top, Count : integer;
Graph : TGraphic;
Img : TImage;
EdPath, EdFileName : TEdit;
begin
openImg.Execute;
Left := 5;
Top := 5;
Count := 0;
Idx := 0;
for i:=0 to openImg.Files.Count-1 do
begin
try
begin
Graph := TPngImage.Create;
Graph.LoadFromFile(openImg.Files[i]);
EdPath := TEdit.Create(pImgs);
EdPath.Left := Left + 101;
EdPath.Visible := False;
EdPath.Text := ExtractFilePath(openImg.Files[i]);
EdFileName := TEdit.Create(pImgs);
EdFileName.Left := Left + 101;
EdFileName.Visible := False;
EdFileName.Text := ExtractFileName(openImg.Files[i]);
Img := TImage.Create(pImgs);
Img.Parent := pImgs;
Idx := Idx + 1;
Img.Name := 'Img_'+IntToStr(Idx);
Img.Width := 100;
Img.Height := 100;
Img.Left := Left;
Img.Proportional := True;
Left := Left + 101;
Img.Top := Top;
Img.Picture.Assign(Graph);
Img.BringToFront;
Count := Count + 1;
Img.OnClick := getImgInfo(Img, edPath.Text, edFileName.Text); //Error line
if Count = 2 then
begin
Left := 5;
Top := Top + 101;
Count := 0;
end;
end;
except on E : Exception do
ShowMessage('Error: :' + E.Message);
end;
end;
end;
Error:
[dcc32 Error] uMain.pas(74): E2010 Incompatible types: 'TNotifyEvent' and 'procedure, untyped pointer or untyped parameter'
What is wrong?
Thanks!

Answer 1

The OnClick event handler of TImage is a TNotifyEvent, so you can only assign such a procedure to it. This is a method (a procedure belonging to an object), and it takes a single parameter, Sender of type TObject. So this will work:
procedure TfMain.ImageClickHandler(Sender: TObject);
begin
// Do something
end;
...
Img.OnClick := ImageClickHandler;
You need some kind of data structure to store your data. Perhaps
type
TImageData = record
Image: TImage;
ImageTitle: string;
ImageFileName: string;
Photographer: string;
DateTaken: TDateTime;
end;
and
var
ImageData = array of TImageData;
Or, more similar to your code:
type
TImageData = record
Image: TImage;
AssociatedEditControl1,
AssociatedEditControl2: TEdit;
end;
var
ImageData = array of TImageData;
Then you set the length of ImageData to openImg.Files.Count, and use Image and AssociatedEditControl1 and AssociatedEditControl2 instead of the local variables. After all, you want to be able to access these controls easily. You could also set the Tag of the TImage to the current value of i, and then in ImageClickHandler, you can check Self.Tag to access ImageData[Self.Tag].AssociatedEditControl1, say.
(But I still think you should separate the internal data from the GUI better. You also need to fix your memory leak.)

Answer 2

Try something more like this instead:
type
PImageInfo = ^ImageInfo;
ImageInfo = record
Path: String;
FileName: String;
Img: TImage;
EdPath: TEdit;
EdFileName : TEdit;
// anything else you need...
end;
private
{ Private declarations }
Images: array of ImageInfo;
procedure ImageClicked(Sender: TObject);
procedure TfMain.Button1Click(Sender: TObject);
var
i, ImgLeft, ImgTop, Count : integer;
Graph : TGraphic;
Info: PImageInfo;
begin
if not openImg.Execute then Exit;
ImgLeft := 5;
ImgTop := 5;
Count := Length(Images);
try
SetLength(Images, Count + openImg.Files.Count);
for I := 0 to openImg.Files.Count-1 do
begin
Graph := TPngImage.Create;
try
Graph.LoadFromFile(openImg.Files[i]);
Info := #Images[Count];
Info.Path := ExtractFilePath(openImg.Files[i]);
Info.FileName := ExtractFileName(openImg.Files[i]);
Info.Img := nil;
Info.EdPath := nil;
Info.EdFileName := nil;
try
Info.EdPath := TEdit.Create(pImgs);
Info.EdPath.Left := ImgLeft + 101;
Info.EdPath.Visible := False;
Info.EdPath.Text := Path;
Info.EdFileName := TEdit.Create(pImgs);
Info.EdFileName.Left := ImgLeft + 101;
Info.EdFileName.Visible := False;
Info.EdFileName.Text := Images[Count].FileName;
Info.Img := TImage.Create(pImgs);
Info.Img.Parent := pImgs;
Info.Img.Tag := Count;
Info.Img.Name := 'Img_'+IntToStr(Count);
Info.Img.SetBounds(ImgLeft, ImgTop, 100, 100);
Info.Img.Proportional := True;
Info.Img.OnClick := ImageClicked;
Info.Img.Picture.Assign(Graph);
Info.Img.BringToFront;
except
Info.EdPath.Free;
Info.EdFileName.Free;
Info.Img.Free;
raise;
end;
finally
Graph.Free;
end;
Inc(Count);
if (Count mod 2) = 0 then
begin
ImgLeft := 5;
Inc(ImgTop, 101);
end else
Inc(ImgLeft, 101);
end;
except
on E : Exception do
begin
SetLength(Images, Count);
ShowMessage('Error: :' + E.Message);
end;
end;
end;
procedure TfMain.ImageClicked(Sender: TObject);
var
Info: PImageInfo;
begin
Info := #Images[(Sender as TImage).Tag];
// use Info as needed...
end;