I am setting up Pull Request in TFS 2015 GIT Repo. My Users are able to Create Pull Request however I am the only one that is able to Complete a pull request. I have confirmed that all the Users have Contribute to the entire repo. I am at a loss as to what is going on. Once the User Approves the PR and Clicks Complete Pull Request the Button is disabled but it never starts the Merge Process. If the User refreshes the page the Complete Pull Request Button is active again. All of this works fine for me just not any of my other users so I assume it is a permissions issue but can not find it.
In TFS, you could complete your pull request after the reviewers approve of the changes by selecting Complete in the upper right of the pull request view.
Complete button on the pull request view with its drop-down options
After you selected the complete button, it will complete the pull request now and merge the changes to the target branch.
For permissions, you just need to grant Contribute permission of target branch (Pull Request: source branch into target branch) to the corresponding user.
Double check the permission settings, if they are added in some group deny the corresponding permission. In TFS, Deny trumps Allow.
Also make sure your pull request have met all branch policy before the completion.
Pull requests can be completed if the number of required approvals is met, even if other reviewers have rejected the changes.
Related
I am trying to push code to bitbucket using jgit. Clone is working with ssh, but to push - I need to set credentials and I am getting "not authorized " error. I tried username, password, ("Private-token", access-token) and app password also
While pushing after a successful clone, ii am getting "origin not found" error also
Please advise
"Not authorized" might mean that you don't have permissions to push to the specified branch. E.g. there might be a policy to not allow to push directly into main branch. Usually developers should push to feature branches and then submit pull requests to ask for code review before merging to the main branch.
As for "origin not found" please check the remotes. The default name for remote repository is origin, but you might have it differently. Also it might be an issue with the command parameters. Please provide more details.
I have made a successful pull request but cant see the name and token icon updated. Any idea how long would it take ?
It's updated immediately on the repo, but most dapps that use the token list, such as wallets and dexes, only update the token-list every other week, so it may take a moment for the change to reflected in wallets and apps.
Some users in our client's Azure DevOps Server (on-prem) instance are unable to see the Request, Response and Event tabs when they view the history for webhooks. Other users can see the tabs.
The issue is as follows...
Under Project Settings --> Service Hooks, my client has a number of service hooks/webhooks defined.
When clicking the ellipse menu next to a Service Hook and selecting "History" it opens a modal window showing previous "runs" of the service hook in question.
On the right hand side of the modal window there are several tabs. Summary, Request, Response and Event (Screenshot attached)
Some users are unable to see the "Response", "Request" and "Event" tabs.
Some more background... The users in question cannot be placed in the "Project Collection Administrators" group due to company policy. They have been given "EditSubscription" permissions using tfssecurity.exe command line but it's still not working. I was hoping there might be a way to give them the required access using the REST API but it seems like the Azure DevOps CLI does not work with Azure DevOps Server 2019?
If anyone else has any advice I'd appreciate the help.
Thanks in advance.
Devon.
You should be able to grant a regular project user the ability to view and manage service hook subscriptions for a project.
tfssecurity /a+ /collection: https://dev.azure.com/fabrikam-fiber-inc/DefaultCollection ServiceHooks PublisherSecurity/abcdef00-abcd-0000-0000-abcdef000000 EditSubscriptions n:fabrikamfiber4#hotmail.com ALLOW
Make sure you used the command with same format and the users also have View subscriptions permission.
Take a look at What permissions do I need to set up a subscription?
Q: What are the security implications of granting Edit subscriptions
and View subscriptions permissions?
A: The user with these permissions can see all subscriptions created
in the project and the notification history for those subscriptions.
That user can then create any type of service hook subscription in
that project. If the user sets up a subscription for a resource that
they don't otherwise have permission to access, the subscription won't
get triggered.
For example: if I don't have access to work items in area path XYZ,
and I set up a subscription to the work item update events, I won't
get notifications for updates to work items in area path XYZ. However,
if another user who does have access to the work items in area path
XYZ is receiving those "work item update" events, then I could see the
notification history of that other user's events, which includes work
item data that I don't otherwise have access to.
If users are still not able to view those tabs with granting both Edit subscriptions and View subscriptions. Suggest they completely sign out the browser and clear cache. Then login in TFS web portal again. Which may do the trick.
I have a project in TFS. The last two pull requests, we got emails for "xxx has approved the code" but not the subsequent emails for "xxx marked the pull request as completed" The pull requests in question were both approved and completed. The emails do not appear to have been caught in Outlook's spam filter.
The subscription for all projects is "A pull request I created or am a reviewer on is updated"
Version: 15.117.26714.0
Is there a way to diagnose why TFS email notifications are so flaky? This isn't the first complaint I've gotten about TFS email notifications being unreliable.
Have tested TFS 2017.2 instance but could not reproduce the issue on my side. Both approved and completed E-mail sent correctly.
So the issue seems not be able to stable reproduce. For now, there is no way to trouble shoot this directly. You could check the event log in TFS sever to see if you got any error or warning info there.
To narrow down the issue, you could analysis both address the E-mail achieved and sent.
Notifications are sent to your preferred email address, which you can
change from your account preferences. Change the preferred one
and use another to see if issue still exists.
The received notifications are sent by the configured SMTP
server. Try to specify another SMTP Server and the email address
to use for sending emails.
One possibility for this issue, the action of approved and completed pull request were too closely. This may cause TFS only trigger one E-Mail. Do it slowly and try again. Based on my testing, in this case, the E-Mail are sent not in sequence, the completed came first then the approved one.
Moreover, you could also explicitly add a subscription with "A pull request I created or am a reviewer on is updated" just for the project you are working on, which may do the trick.
I have this error when I push my code to Github repository by Xcode
Before answering the question you must know:
Although everyone can make a pull request, you can't just push to a repository. ِِYou need permission.
So this happened for me because in my Xcode, I was pushing to a remote that belonged to one of the other members ie I didn't have permission to push to.
You have two options:
Ask for permission from the owner of that remote repo/fork and have them include into one of its collaborators
Or Simply push to a repo that you have permission like your own repo,
using the dropdown menu encircled below (and perhaps then make a pull request from there to that branch you wanted to push to)
I usually run into this issue when I checkout directly from a remote branch ie I do something like:
git checkout -b localFromUpstream upstream/someBranch
And then when I commit, Xcode assumes that I want to push back to upstream/someBranch. But I don't permission to push to upstream/someBranch.
HTTP code 403 means forbidden, so it is most probably incorrect credentials. So double check your username and password etc.
https://en.wikipedia.org/wiki/HTTP_403
Even you can make a pull request, but can't just push to a repository. ِِYou need permission.
Inviting collaborators to a personal repository
Ask for the username of the person you're inviting as a collaborator. If they don't have a username yet, they can sign up for GitHub.
On GitHub, navigate to the main page of the repository.
Under your repository name, click Settings.
In the left sidebar, click Collaborators.
Under "Collaborators", start typing the collaborator's username.
Select the collaborator's username from the drop-down menu.
Click Add collaborator.
The user will receive an email inviting them to the repository. Once they accept your invitation, they will have collaborator access to your repository.