VBPieChart - removeFromSuperView not working (hide chart) - ios

I'm using VBPieChart, in Objective C language. I'm showing the chart on valueChange of a segmented control, like :
- (IBAction)segmentControlAction:(UISegmentedControl *)sender
{
switch ([sender selectedSegmentIndex])
{
case 0:
[self showPieChart:NO];
_tableViewForCount.hidden = NO;
[_tableViewForCount reloadSections:[NSIndexSet indexSetWithIndex:0] withRowAnimation:UITableViewRowAnimationRight];
break;
case 1:
_tableViewForCount.hidden = YES;
[self showPieChart:YES];
break;
default:
NSLog(#"None");
break;
}
}
and the showPieChart method goes like :
- (void) showPieChart:(Boolean)visible
{
VBPieChart *chart = [[VBPieChart alloc] initWithFrame:CGRectMake(0, 0, 250, 250)];
chart.center = self.view.center;
// Setup some options:
[chart setHoleRadiusPrecent:0.3]; /* hole inside of chart */
// Prepare your data
NSMutableArray *chartValues = [[NSMutableArray alloc]initWithObjects: #{#"name":#"Apples", #"value":#50, #"color":[UIColor redColor]},
#{#"name":#"Pears", #"value":#20, #"color":[UIColor blueColor]},
#{#"name":#"Oranges", #"value":#40, #"color":[UIColor orangeColor]},
#{#"name":#"Bananas", #"value":#70, #"color":[UIColor purpleColor]}, nil
];
if (visible)
{
chart.center = self.view.center;
// Present pie chart with animation
[chart setChartValues:chartValues animation:YES duration:0.4 options:VBPieChartAnimationFan];
[self.view addSubview:chart];
}
else
{
// remove chart
[chart removeFromSuperView];
}
}
Since VBPieChart is just a custom subclass of UIView, this should work. But i'm not getting any success.
I've also tried [chart setHidden:YES]; as well as [chart setAlpha:0.0]; , but still no luck.
Any help would is appreciated. I just want to hide/remove the chart when user switched back to segment index 0.
Thanks.

VBPieChart *chart create this object on the .h file then
- (void) showPieChart:(Boolean)visible
{
if(chart == nil)
{
chart = [[VBPieChart alloc] initWithFrame:CGRectMake(0, 0, 250, 250)];
[self.view addSubview:chart];
}
chart.center = self.view.center;
// Setup some options:
[chart setHoleRadiusPrecent:0.3]; /* hole inside of chart */
// Prepare your data
NSMutableArray *chartValues = [[NSMutableArray alloc]initWithObjects: #{#"name":#"Apples", #"value":#50, #"color":[UIColor redColor]},
#{#"name":#"Pears", #"value":#20, #"color":[UIColor blueColor]},
#{#"name":#"Oranges", #"value":#40, #"color":[UIColor orangeColor]},
#{#"name":#"Bananas", #"value":#70, #"color":[UIColor purpleColor]}, nil
];
if (visible)
{
chart.center = self.view.center;
// Present pie chart with animation
[chart setChartValues:chartValues animation:YES duration:0.4 options:VBPieChartAnimationFan];
chart.alpa = 1.0
}
else
{
// remove chart
chart.alpa = 0.0
}
}

You need to create variable as below.
static VBPieChart *chart = nil
if(!chart)
chart = [[VBPieChart alloc] initWithFrame:CGRectMake(0, 0, 250, 250)];
}
if (visible)
{
chart.hidden = NO;
}
else
{
// hide chart
chart.hidden = YES;
}

Related

Switching from UIScreenEdgePanGestureRecognizer to UISegmentedControl in Objective-C

I am a new objective-c developer. The purpose of the app being developed is to switch between 3 graphs each displaying scientific data. When the user drags their finger on these graphs, the data for that point is displayed. Currently, to switch between these three graphs, the UIScreenEdgePanGestureRecognizer was used. However, since Apple has got rid of this feature in recent updates, I want to use segmented controls to switch between the three graphs. I have been able to get the segmented controls to appear, however, I have not been able to get them to actually get the graphs to switch. I have attached the relavant parts of the (ORIGINAL) viewcontroller.m below. How would I go about this? Thanks.
For reference, the names of the three graphs are ts, ph, and pv.
- (void)viewDidLoad
{
[super viewDidLoad];
/*
// Show/hide nav bar
UITapGestureRecognizer *tap = [[UITapGestureRecognizer alloc] initWithTarget:self
action:#selector(doubleTap)];
[tap setNumberOfTapsRequired:2];
[self.view addGestureRecognizer:tap];
*/
touchHasRegistered = NO;
allowQualityScrubbing = NO;
shouldFineTune = 0;
hasFineTuned = NO;
[[UIApplication sharedApplication] setStatusBarHidden:YES];
[self.navigationController setNavigationBarHidden:YES];
[self.containerView addSubview:self.chartView];
[self.view insertSubview:self.secondContainerView
aboveSubview:self.containerView];
[self.view insertSubview:self.infoView
aboveSubview:self.secondContainerView];
[self.containerView bringSubviewToFront:self.infoButton];
[self.view setBackgroundColor:[UIColor whiteColor]];
[self.chartView mas_makeConstraints:^(MASConstraintMaker *make) {
make.edges.equalTo(self.containerView);
}];
[self.infoView mas_makeConstraints:^(MASConstraintMaker *make) {
make.edges.equalTo(self.containerView);
}];
if (self.secondContainerView.superview != nil && self.chartView.image != nil) {
[self.secondContainerView mas_makeConstraints:^(MASConstraintMaker *make) {
make.left.equalTo(self.containerView).with.offset(20.0);
make.top.equalTo(self.containerView).with.offset(20.0);
make.height.equalTo([NSNumber numberWithFloat:self.secondContainerView.frame.size.height]);
make.width.equalTo([NSNumber numberWithFloat:self.secondContainerView.frame.size.width]);
}];
}
[self.secondContainerView addSubview:self.displayView];
[self chooseNewFileWithChartType:self.chartView.chart.substanceType valueType:#"ts"];
UIScreenEdgePanGestureRecognizer *rightRecog = [[UIScreenEdgePanGestureRecognizer alloc] initWithTarget:self
action:#selector(resetChart:)];
[rightRecog setEdges:UIRectEdgeRight];
[rightRecog setCancelsTouchesInView:YES];
[self.chartView addGestureRecognizer:rightRecog];
UIScreenEdgePanGestureRecognizer *leftRecog = [[UIScreenEdgePanGestureRecognizer alloc] initWithTarget:self
action:#selector(resetChart:)];
[leftRecog setEdges:UIRectEdgeLeft];
[leftRecog setCancelsTouchesInView:YES];
[self.chartView addGestureRecognizer:leftRecog];
}
- (void)viewWillAppear:(BOOL)animated
{
[super viewWillAppear:animated];
[self.view addSubview:self.popupView];
[self.popupView mas_makeConstraints:^(MASConstraintMaker *make) {
make.height.equalTo(#(self.popupView.frame.size.height));
make.width.equalTo(#(self.popupView.frame.size.width));
make.center.equalTo(self.view);
}];
/*
// Add Adjuster Views
NSSet *tags = [self tagsForAdjusterViews];
CGFloat height = self.displayView.containerViewHeight/self.displayView.numberOfRows;
for (id tag in tags) {
RUAAdjusterView *adjusterView = [[RUAAdjusterView alloc] initWithFrame:CGRectZero
tag:[(NSNumber *)tag integerValue]];
adjusterView.delegate = self;
[adjusterView setBackgroundColor:[UIColor clearColor]];
[self.secondContainerView addSubview:adjusterView];
[self.secondContainerView bringSubviewToFront:adjusterView];
[adjusterView mas_makeConstraints:^(MASConstraintMaker *make) {
make.left.equalTo(self.secondContainerView);
make.right.equalTo(self.secondContainerView);
make.top.equalTo([NSNumber numberWithFloat:(height*([(NSNumber *)tag floatValue] - 1) + self.displayView.containerViewOriginY + 2.0f)]);
make.height.equalTo([NSNumber numberWithFloat:height - 4.0f]);
}];
}
*/
}
- (NSSet *)tagsForAdjusterViews
{
return [NSSet setWithObjects:#1, #2, #6, #7, nil];
}
- (BOOL)prefersStatusBarHidden
{
return YES;
}
#pragma mark - Lazy Init
- (LocationIndicatorImageView *)chartView
{
if (!_chartView) {
_chartView = (LocationIndicatorImageView *)[[LocationIndicatorImageView alloc] initWithFrame:self.containerView.frame
image:[UIImage imageNamed:#"Water_ts_chart.png"]
sender:self];
[_chartView setChart:[RUChart chartWithChartType:#"ts"]];
}
return _chartView;
}
-(UIView *)displayView
{
if (!_displayView) {
_displayView = [[DisplayView alloc] initWithFrame:self.secondContainerView.frame];
[_displayView setDataSource:self];
}
return _displayView;
}
-(UIView *)secondContainerView
{
if (!_secondContainerView) {
CGFloat height = 343.0f;
CGFloat width = 225.0f;
_secondContainerView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, width, height)];
}
return _secondContainerView;
}
-(UIImageView *)infoView
{
if (!_infoView) {
_infoView = [[UIImageView alloc] initWithFrame:CGRectZero];
[_infoView setImage:[UIImage imageNamed:#"Legend.png"]];
[_infoView setHidden:YES];
[_infoView setUserInteractionEnabled:NO];
[_infoView setBackgroundColor:[UIColor whiteColor]];
UIView *container = [[UIView alloc] initWithFrame:CGRectMake(30, 30, 310, 310)];
UITapGestureRecognizer *ytTap = [[UITapGestureRecognizer alloc] initWithTarget:self
action:#selector(showYoutubeVideo)];
[ytTap setNumberOfTapsRequired:1];
[container setUserInteractionEnabled:YES];
[container addGestureRecognizer:ytTap];
[_infoView addSubview:container];
UIImageView *youtube = [[UIImageView alloc] initWithFrame:CGRectMake(0, 0, 60, 60)];
[youtube setImage:[UIImage imageNamed:#"youtube.png"]];
UITextView *textView1 = [[UITextView alloc] initWithFrame:CGRectMake(youtube.frame.origin.x + youtube.frame.size.width,
youtube.frame.origin.y,
250,
youtube.frame.size.height/2.0)];
UITextView *textView2 = [[UITextView alloc] initWithFrame:CGRectMake(youtube.frame.origin.x + youtube.frame.size.width,
youtube.frame.origin.y + youtube.frame.size.height/2.0,
250,
youtube.frame.size.height/2.0)];
UIFont *font = [UIFont fontWithName:#"HelveticaNeue-Light" size:16.0];
[textView1 setText:#"Learn about Thermodynamic"];
[textView1 setFont:font];
[textView1 setTextContainerInset:UIEdgeInsetsMake(11.0, 4.0, 4.0, 0.0)];
[textView1 setUserInteractionEnabled:NO];
[textView2 setText:#"Properties of Water"];
[textView2 setFont:font];
[textView2 setTextContainerInset:UIEdgeInsetsMake(0.0, 4.0, 0.0, 0.0)];
[textView2 setUserInteractionEnabled:NO];
[container addSubview:youtube];
[container addSubview:textView1];
[container addSubview:textView2];
UITapGestureRecognizer *tap = [[UITapGestureRecognizer alloc] initWithTarget:self
action:#selector(dismissInfo)];
[tap setNumberOfTapsRequired:1];
[_infoView addGestureRecognizer:tap];
}
return _infoView;
}
- (void)showYoutubeVideo
{
[[UIApplication sharedApplication] openURL:[NSURL URLWithString:#"http://www.youtube.com/watch?v=rJR-6OEw09k"]
options:#{}
completionHandler:nil];
}
- (H2O_Wagner_Pruss *)wagPruss
{
if (!_wagPruss) {
_wagPruss = [[H2O_Wagner_Pruss alloc] initEOS];
}
return _wagPruss;
}
- (NSArray *)superheatedValues
{
if (!_superheatedValues) {
_superheatedValues = [[NSArray alloc] init];
}
return _superheatedValues;
}
- (NSArray *)superheatedKeys
{
if (!_superheatedKeys) {
_superheatedKeys = [[NSArray alloc] init];
}
return _superheatedKeys;
}
- (NSArray *)chartValueTypes
{
if (!_chartValueTypes) {
_chartValueTypes = [NSArray arrayWithObjects:#"ts",#"ph",#"pv", nil];
}
return _chartValueTypes;
}
- (RUAPopupView *)popupView
{
if (!_popupView) {
_popupView = [[RUAPopupView alloc] initWithFrame:CGRectMake(0.0f, 0.0f, 200.0f, 160.0f) text:#"t-s"];
}
return _popupView;
}
- (RUASpaceController *)spaceController
{
if (!_spaceController) {
_spaceController = [[RUASpaceController alloc] init];
// NOTE: Seems like (10/8.0 and 10/9.0) and 20/30.0 felt best of ones I tried. Could use some refining.
_spaceController.numPoints = 10;
_spaceController.maxDiff = 7.0;
}
return _spaceController;
}
#pragma mark - Gesture Selectors
- (IBAction)displayInfo:(id)sender {
[self.infoView setHidden:NO];
[self.infoView setUserInteractionEnabled:YES];
}
-(void)dismissInfo
{
[self.infoView setHidden:YES];
[self.infoView setUserInteractionEnabled:NO];
}
-(void)doubleTap
{
[self.popupView showHideAnimated:YES];
/*
if (self.navigationController.isNavigationBarHidden) {
[self.navigationController setNavigationBarHidden:NO animated:YES];
[[UIApplication sharedApplication] setStatusBarHidden:NO];
} else {
[self.navigationController setNavigationBarHidden:YES animated:YES];
[[UIApplication sharedApplication] setStatusBarHidden:YES];
}
*/
}
- (void)resetChart:(UIScreenEdgePanGestureRecognizer *)recog
{
[self.popupView.layer removeAllAnimations];
if (recog.state == UIGestureRecognizerStateEnded) {
NSInteger index = [self.chartValueTypes indexOfObject:self.chartView.chart.valueType];
NSLog(#"%#, %#", self.chartValueTypes[((index+1)+3)%3], self.chartValueTypes[((index-1)+3)%3]);
NSString *type;
if (recog.edges == UIRectEdgeRight) {
type = self.chartValueTypes[((index+1)+3)%3];
} else if (recog.edges == UIRectEdgeLeft) {
type = self.chartValueTypes[((index-1)+3)%3];
}
NSString *letter1 = [type substringToIndex:1];
NSString *letter2 = [type substringFromIndex:1];
NSString *displayName = [NSString stringWithFormat:#"%#-%#",letter1.uppercaseString,letter2];
self.popupView.text = displayName;
[self.chartView resetImage:[UIImage imageNamed:[NSString stringWithFormat:#"Water_%#_chart.png",type]]];
self.chartView.chart = [RUChart chartWithChartType:type];
[self inspectInfoButtonWithChartValueType:type];
[self chooseNewFileWithChartType:self.chartView.chart.substanceType valueType:type];
[self.secondContainerView mas_remakeConstraints:^(MASConstraintMaker *make) {
make.top.equalTo(self.containerView).with.offset(20.0);
make.height.equalTo([NSNumber numberWithFloat:self.secondContainerView.frame.size.height]);
make.width.equalTo([NSNumber numberWithFloat:self.secondContainerView.frame.size.width]);
}];
if (self.chartView.chart.displayPosition == RUChartDisplayPositionLeft) {
[self.secondContainerView mas_updateConstraints:^(MASConstraintMaker *make) {
make.left.equalTo(self.containerView).with.offset(20.0);
}];
} else if (self.chartView.chart.displayPosition == RUChartDisplayPositionRight) {
[self.secondContainerView mas_updateConstraints:^(MASConstraintMaker *make) {
make.right.equalTo(self.containerView).with.offset(-20.0);
}];
}
[self.popupView showHideAnimated:YES];
if (touchHasRegistered) {
if ([self.chartView.chart.valueType isEqualToString:#"ph"]) {
if ([self.chartView pointIsWithinBoundsForPrimaryAxisValue:currentEnthalpy secondaryAxisValue:currentPressure]) {
[self.chartView moveMarkerToPrimaryAxisValue:currentEnthalpy
secondaryAxisValue:currentPressure];
} else {
[self.chartView removeMarker];
}
} else if ([self.chartView.chart.valueType isEqualToString:#"pv"]) {
if ([self.chartView pointIsWithinBoundsForPrimaryAxisValue:currentSpecVolume secondaryAxisValue:currentPressure]) {
[self.chartView moveMarkerToPrimaryAxisValue:currentSpecVolume
secondaryAxisValue:currentPressure];
} else {
[self.chartView removeMarker];
}
} else if ([self.chartView.chart.valueType isEqualToString:#"ts"]) {
if ([self.chartView pointIsWithinBoundsForPrimaryAxisValue:currentEntropy secondaryAxisValue:currentTemp]) {
[self.chartView moveMarkerToPrimaryAxisValue:currentEntropy
secondaryAxisValue:currentTemp];
} else {
[self.chartView removeMarker];
}
} else {
touchHasRegistered = NO;
[self.chartView removeMarker];
}
}
}
}
UISegmentedControl look like a lot to setup, but actually is not.
The following code just shows more detailed control in color and label positions inside the segments. If there is no further use somewhere else, there is no property needed to hold UISegmentedControl *. Call this once in -initWithFrame: or -viewDidLoad.
- (void)setupSegmentCtrl {
UISegmentedControl *segmentedCtrl = [[UISegmentedControl alloc] initWithItems:#[#"A",#"B",#"C"]];
segmentedCtrl.momentary = YES;
NSUInteger segItems = segmentedCtrl.numberOfSegments;
segmentedCtrl.frame = CGRectMake(0, 0, 60*segItems, 40);
// sorry - funny color scheme used to demonstrate
segmentedCtrl.tintColor = UIColor.orangeColor;
//segmentedCtrl.backgroundColor = UIColor.clearColor;
UIColor *dark = [UIColor colorWithWhite:0.5 alpha:0.5];
[segmentedCtrl setTitleTextAttributes:[NSDictionary dictionaryWithObjectsAndKeys:dark,NSForegroundColorAttributeName, [UIFont fontWithName:#"HelveticaNeue-Light" size:16.0],NSFontAttributeName, nil] forState:UIControlStateNormal];
[segmentedCtrl setTitleTextAttributes:[NSDictionary dictionaryWithObjectsAndKeys:UIColor.redColor, NSForegroundColorAttributeName, nil] forState:UIControlStateSelected];
[segmentedCtrl setTitleTextAttributes:[NSDictionary dictionaryWithObjectsAndKeys:UIColor.greenColor, NSForegroundColorAttributeName, nil] forState:UIControlStateHighlighted];
// you can move the segments labels about some pixels with the following..
//[segmentedCtrl setContentPositionAdjustment:UIOffsetMake(-1, -2) forSegmentType:UISegmentedControlSegmentAny barMetrics:UIBarMetricsDefault];
// manually set an active index, .. as default
[segmentedCtrl setSelectedSegmentIndex:0];
[self.view addSubview:segmentedCtrl];
// next lines work for all UIControls, setting a target and action manually.
// there are a lot UIControlEvent to choose/combine from available
[segmentedCtrl addTarget:self action:#selector(segmentSelectedAction:) forControlEvents:UIControlEventValueChanged];
}
and as defined you will want a method that takes action when you touch the segments.
-(void)segmentSelectedAction:(UISegmentedControl *)seg {
NSLog(#"selectedSegmentIndex=%d", seg.selectedSegmentIndex);
// what ever you gonna do with the seg.selectedSegmentIndex
}
and maybe good to know when using UISegmentedControl, when going in dark mode it has different color scheme for the background. So switch and test how it looks like.
If you have to change layout cause of device rotates, you will have to expose UISegmentedControl *segmentCtrl as property or class variable and change frame and so on in -layoutSubviews to your needs.
A last word to UIViews and UIGestureRecognizers. Sometime its much more practical to write your own UIView subclass and allocate that instead. Then you are able to use the following methods inside your subclass to catch touches directly.
-(void)touchesBegan:(NSSet *)touches withEvent:(UIEvent *)event {
[super touchesBegan:touches withEvent:event];
for (UITouch *touch in touches) {
NSLog(#"touchesBegan= %#",touch.description);
}
}
// and the other possible..
-(void)touchesMoved:withEvent:
-(void)touchesEnded:withEvent:
-(void)touchesCancelled:withEvent:

UIDropInteractionDelegate not being called

I have a DropAreaViewController in my app. Inside this controller I run the following code:
- (void)viewDidLoad {
[super viewDidLoad];
UIDropInteraction *interaction = [[UIDropInteraction alloc] initWithDelegate:self];
[self.view addInteraction:interaction];
}
- (BOOL)dropInteraction:(UIDropInteraction *)dropInteraction canHandleSession:(nonnull id<UIDropSession>)session {
NSLog(#"canHandleSession called");
return true;
}
- (UIDropProposal *)dropInteraction:(UIDropInteraction *)dropInteraction sessionDidUpdate:(nonnull id<UIDropSession>)session {
NSLog(#"sessionDidUpdate");
if (session.localDragSession != nil) {
NSLog(#"is localDragSession");
return [[UITableViewDropProposal alloc] initWithDropOperation:UIDropOperationMove intent:UITableViewDropIntentInsertAtDestinationIndexPath];
} else {
return [[UITableViewDropProposal alloc] initWithDropOperation:UIDropOperationCancel];
}
}
- (void)dropInteraction:(UIDropInteraction *)interaction performDrop:(id<UIDropSession>)session {
self.view.backgroundColor = [UIColor redColor];
}
Now, in another viewcontroller I add this controller:
DropAreaViewController *davc = [[DropAreaViewController alloc] init];
davc.view.frame = CGRectMake(0, 0, 100, 100);
[self.view addSubview:davc.view];
None of the drops are being registered though. I get not logs at all when I hover a drop on top of the square. Any ideas?

Can't remove subview?

This is about a web browser.
I have a custom Class that handles the webpages.
SNBrowserView
SNBrowserViewPage
SNBrowserViewPages have two objects.
WKWebView
UIImageView // Snapshot of the WKWebView
A function either sustains or recovers a page for memory management.
(Testing) Whenever a page is selected I call a recovery function.
Selection:
- (void)browserView:(SNBrowserView *)browserView didSelectPage:(SNBrowserViewPage *)page
{
if (page.sustained) {
[page recoverAnimated:NO];
}
}
Sustain:
- (void)sustain
{
_sustained = YES;
if (_webView) {
_webView = nil;
[_webView removeFromSuperview];
}
_snapshotView = [[UIImageView alloc] init];
_snapshotView.frame = CGRectMake(0.0, 0.0, self.frame.size.width, self.frame.size.height);
_snapshotView.image = _snapshot;
[self addSubview:_snapshotView];
}
Recover:
- (void)recoverAnimated:(BOOL)animated
{
_sustained = NO;
_webView = [[WKWebView alloc] init];
_webView.frame = CGRectMake(0.0, 0.0, self.frame.size.width, self.frame.size.height);
_webView.navigationDelegate = self;
_webView.UIDelegate = self;
[self addSubview:_webView];
[self sendSubviewToBack:_webView];
[self loadURL:_initialURL]; // Start loading as early as possible.
if (animated) {
[UIView animateWithDuration:0.3
animations:^{
_snapshotView.alpha = 0.0;
}
completion:^(BOOL finished){
_snapshotView = nil;
[_snapshotView removeFromSuperview];
}];
}
else {
_snapshotView = nil;
[_snapshotView removeFromSuperview];
}
}
When I try to recover a page the snapshotView is not set to nil nor is it removed from the superview.
How is that even possible?
Even this won't work:
- (void)recoverAnimated:(BOOL)animated
{
_snapshotView = nil;
[_snapshotView removeFromSuperview];
}
The snapshotView is a subview, removeFromSuperview should always work, why is there MORE to it?
I suggest you try replace all of your
_view = nil;
[_view removeFromSuperview];
with
[_view removeFromSuperview];
_view = nil;
because what you are doing is setting the _view to nil and then removing nil from superview.

Remove and add multiple image in same UIImageView

I am designing a make own pizza app. The user would add multiple toppings for example shrimp, bacon, and etc. on top of each other. So the adding image is working fine. Here is my code:
bool meatAdded;
- (void)addMeatTopping:(NSString*)meat withImage:(UIImageView*)meatImage {
if ((meatAdded =! meatAdded)) {
//crust o taqir bede be cheese BADAN
meatImage = [[UIImageView alloc]initWithFrame:_crustImage.bounds];
[meatImage setImage:[UIImage imageNamed:meat]];
[_crustImage addSubview:meatImage];
for (UIButton*button in _meatButtonsArray) {
checkMark.center = button.center;
checkMark.alpha = 1;
}
[UIView animateWithDuration:.60 delay:0 usingSpringWithDamping:.40 initialSpringVelocity:.20 options:UIViewAnimationOptionAllowUserInteraction animations:^ {
meatImage.transform = CGAffineTransformMakeScale(.5, .5);
meatImage.transform = CGAffineTransformMakeScale(1, 1); } completion:nil];
}else {
/**** THIS PART OF CODE DOESN'T WORK ! IT PRINTS LOG BUT DOESN'T CHANGE THE MEAT IMAGE AT ALL ****/
NSLog(#"Remove");
meatImage.alpha = 0;
[meatImage setImage:nil];
[meatImage removeFromSuperview];
}
}
example of calling above method:
- (IBAction)meat0:(id)sender {
[self addMeatTopping:#"topping_Bacon" withImage:beykenMeat];
}
- (IBAction)meat1:(id)sender {
[self addMeatTopping:#"Steak" withImage:steykMeat];
}
How can I create a toggle method when user select an item? The item will add to view and when taps again it should be removed from view.
SubclassImageView *imageviewG = [[SubclassImageView alloc]initWithFrame:CGRectMake(0, 0, 200, 200)];
self.crustImage = [[UIView alloc]initWithFrame:CGRectMake(50, 50, 250, 250)];
self.crustImage.backgroundColor = [UIColor redColor];
[imageviewG setImage:#"topping_Bacon"];
[self.crustImage addSubview:imageviewG];
[self.view addSubview:self.crustImage];
for(id viewInner in self.crustImage.subviews){
if([viewInner isKindOfClass:[SubclassImageView class]]){
SubclassImageView *imageSeleted = (SubclassImageView *)viewInner;
if([imageSeleted.getImageName isEqualToString:#"topping_Bacon"]){
//your logic to add or remove the imageview from super view
}else if([imageSeleted.getImageName isEqualToString:#"Steak"]){
//your logic to add or remove the imageview from super view
}
}
}

Getting memory leak in UIKit?

when I tested my App in instruments for memory leak I found nothing(running using simulator).But When I run it in a mobile and then checked, there are many leaks in UIKit objects. This happening in every view.In simulator no such leaks are showing.
Below is the screenshot of the instrument where some leakage happened.
When I moved to secondViewController from HomeView, no leaks found.If again coming back to home,these many leaks are found. So, is it mean that, I have to release/nil all the UI objects which I used in that secondView. For your information, below are the UI objects I used in secondView.
1.Two Background UIImageView
2.One TitleBar UIImageView
3.3 UIButtons(Back,left and right button for iCarousel)
4.One iCarousel view
5.UIPageController(For this I have used a third Party code SMPageControl)
6.One title label.
Note : Mine is Non-ARC code.
Did anyone faced this problem before.How can I overcome this problem,since I have this problem in every View in my App.Because of this, my App getting memory waring frequently and crashing often.
Thank you.
Below is the my implementation file of that View.
EDIT1 :
#implementation CatalogueViewController
#synthesize deptCarousel = _deptCarousel;
#synthesize carouselItems = _carouselItems;
#synthesize categorymAr = _categorymAr;
#synthesize spacePageControl = _spacePageControl;
#synthesize wrap;
- (void)dealloc {
_deptCarousel = nil;
[_categorymAr release];
_categorymAr = nil;
_deptCarousel.delegate = nil;
_deptCarousel.dataSource = nil;
[_deptCarousel release];
[_carouselItems release];
[viewGesture release];
viewGesture = nil;
[_spacePageControl release];
_spacePageControl = nil;
imgViewBG = nil;
imgViewBG2 = nil;
btnPrev = nil;
btnNext = nil;
// [self releaseObjects];
[super dealloc];
}
- ( IBAction) btnBackClicked {
[self.navigationController popViewControllerAnimated:YES];
}
- (id)initWithNibName:(NSString *)nibNameOrNil bundle:(NSBundle *)nibBundleOrNil
{
self = [super initWithNibName:nibNameOrNil bundle:nibBundleOrNil];
if (self) {
// Custom initialization
}
return self;
}
- (void)didReceiveMemoryWarning
{
// Releases the view if it doesn't have a superview.
[super didReceiveMemoryWarning];
// Release any cached data, images, etc that aren't in use.
}
#pragma mark - View lifecycle
- (void)viewDidLoad
{
[super viewDidLoad];
self.title = NSLocalizedString(#"catalogue", #"Catalogue");
// Do any additional setup after loading the view from its nib.
_deptCarousel.type = iCarouselTypeLinear;
_deptCarousel.scrollSpeed = 0.3f;
_deptCarousel.bounceDistance = 0.1f;
_deptCarousel.scrollToItemBoundary = YES;
_deptCarousel.stopAtItemBoundary = YES;
[_deptCarousel setScrollEnabled:NO];
UISwipeGestureRecognizer *swipeLeft = [[UISwipeGestureRecognizer alloc] initWithTarget:self action:#selector(swipeNext:)];
swipeLeft.direction = UISwipeGestureRecognizerDirectionLeft;
[viewGesture addGestureRecognizer:swipeLeft];
[swipeLeft release];
UISwipeGestureRecognizer *swipeRight = [[UISwipeGestureRecognizer alloc] initWithTarget:self action:#selector(swipePrev:)];
swipeRight.direction = UISwipeGestureRecognizerDirectionRight;
[viewGesture addGestureRecognizer:swipeRight];
[swipeRight release];
UITapGestureRecognizer *singleTap = [[UITapGestureRecognizer alloc] initWithTarget:self action:#selector(handleSingleTap:)];
[viewGesture addGestureRecognizer:singleTap];
[singleTap release];
_carouselItems = [[NSMutableArray alloc] initWithCapacity:1];
_categorymAr = [[NSMutableArray alloc] initWithCapacity:1];
[self addCatalogues];
_spacePageControl.numberOfPages = [_categorymAr count];
[_spacePageControl setPageIndicatorImage:[UIImage imageNamed:IS_IPAD?#"Marker1.fw.png" : #"Markeri.png"]];
[_spacePageControl setCurrentPageIndicatorImage:[UIImage imageNamed:IS_IPAD?#"Marker-Highlight.png" : #"Marker-Highlight_i.png"]];
[_spacePageControl addTarget:self action:#selector(spacePageControl:) forControlEvents:UIControlEventValueChanged];
}
- (void)spacePageControl:(SMPageControl *)sender{
[_deptCarousel scrollToItemAtIndex:sender.currentPage animated:YES];
}
- ( void ) addCatalogues {
[_categorymAr addObjectsFromArray:[[DBModel database] categoryList]];
for (int i = 0; i < [_categorymAr count]; i++) {
[_carouselItems addObject:[NSNumber numberWithInt:i]];
}
[_deptCarousel reloadData];
}
- (void)viewDidUnload{
[super viewDidUnload];
// Release any retained subviews of the main view.
// e.g. self.myOutlet = nil;
}
- (void)viewWillAppear:(BOOL)animated
{
[self phoneType];
[super viewWillAppear:animated];
if (IS_IPAD) {
UIInterfaceOrientation statusBarOrientation = [[UIApplication sharedApplication] statusBarOrientation];
[self handleOrientation:statusBarOrientation];
}
}
- (void)viewDidAppear:(BOOL)animated
{
[super viewDidAppear:animated];
}
- ( void ) phoneType{
if(!IS_IPAD){
if(IS_IPHONE5){
imgViewBG.image = [UIImage imageNamed:#"Background5_5.jpg"];
imgViewBG.center = CGPointMake(162,265);
imgViewBG2.image = [UIImage imageNamed:#"Background11_5.png"];
_spacePageControl.center = CGPointMake(160, 478);
_deptCarousel.center = CGPointMake(160, 355);
viewGesture.center = CGPointMake(160, 355);
btnPrev.center = CGPointMake(25, 355);
btnNext.center = CGPointMake(295, 355);
}
else{
imgViewBG.image = [UIImage imageNamed:#"Background5.jpg"];
imgViewBG2.image = [UIImage imageNamed:#"Background9.png"];
}
}
}
-(void)textFieldDidBeginEditing:(UITextField *)textField{
textFieldSearch.placeholder = #"";
UIButton *clearButton = [[UIButton alloc] initWithFrame:CGRectMake(0, 0, 20, 20)];
[clearButton setImage:[UIImage imageNamed:IS_IPAD?#"Btn_X_Large.fw.png":#"Btn_X.fw.png"] forState:UIControlStateNormal];
[clearButton addTarget:self action:#selector(btnClearTextField) forControlEvents:UIControlEventTouchUpInside];
[textFieldSearch setRightViewMode:UITextFieldViewModeAlways];
[textFieldSearch setRightView:clearButton];
[clearButton release];
}
-(void)textFieldDidEndEditing:(UITextField *)textField{
[textFieldSearch setRightView:nil];
if ([textFieldSearch.text isEqualToString:#""]) {
textFieldSearch.placeholder = NSLocalizedString(#"hud_search_for_a_product_here",#"");
}
}
-(IBAction)btnClearTextField{
textFieldSearch.text = #"";
}
- (NSUInteger)supportedInterfaceOrientations
{
return UIInterfaceOrientationMaskAll;
}
- (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation
{
if (IS_IPAD) {
return YES;
} else {
return (interfaceOrientation == UIInterfaceOrientationPortrait || interfaceOrientation == UIInterfaceOrientationPortraitUpsideDown);
}
}
- (void)willRotateToInterfaceOrientation:(UIInterfaceOrientation )toInterfaceOrientation duration:(NSTimeInterval)duration{
if (IS_IPAD) {
[self handleOrientation:toInterfaceOrientation];
}
}
- ( void ) handleOrientation:(UIInterfaceOrientation )toInterfaceOrientation {
if (toInterfaceOrientation == UIInterfaceOrientationPortrait || toInterfaceOrientation == UIInterfaceOrientationPortraitUpsideDown) {
imgViewBG.image = [UIImage imageNamed:#"Background_Catalogue_P.jpg"];
imgViewBG2.image = [UIImage imageNamed:#"Background_Overlay_P.fw.png"];
btnPrev.center = CGPointMake(90, 640);
btnNext.center = CGPointMake(677, 640);
textFieldSearch.frame = CGRectMake(187, 54, 418, 25);
_deptCarousel.frame = CGRectMake(235, 250, 300, 800);
_spacePageControl.center = CGPointMake(385, 920);
viewGesture.center = CGPointMake(385, 658);
}else {
imgViewBG.image = [UIImage imageNamed:#"Background_Catalogue_L.jpg"];
imgViewBG2.image = [UIImage imageNamed:#"Background_Overlay_L.fw.png"];
btnPrev.center = CGPointMake(54, 385);
btnNext.center = CGPointMake(640, 385);
textFieldSearch.frame = CGRectMake(240, 55, 567, 25);
_deptCarousel.frame = CGRectMake(50, 250, 600, 300);
_spacePageControl.center = CGPointMake(346, 660);
viewGesture.center = CGPointMake(347, 405);
}
}
- ( IBAction )btnDepartmentClicked:(id)sender {
int btnTag = [sender tag];
ProductCategoriesViewController *productView = [[ProductCategoriesViewController alloc] initWithNibName:#"ProductCategoriesView" bundle:nil];
if ( btnTag == 0 ) {
[productView setStrTitle:NSLocalizedString(#"women", #"Women")];
}else if ( btnTag == 1 ) {
[productView setStrTitle:NSLocalizedString(#"men", #"Men")];
} else {
[productView setStrTitle:NSLocalizedString(#"sports", #"Sports")];
}
[self.navigationController pushViewController:productView animated:YES];
[productView release];
}
- ( BOOL ) textFieldShouldReturn:( UITextField * )textField {
[textField resignFirstResponder];
[Flurry logEvent:#"Product searched" withParameters:[NSDictionary dictionaryWithObjectsAndKeys:textField.text,#"1", nil]];
[self productSearch:textField.text isBar:NO isQR:NO];
return YES;
}
- ( void ) productSearch:( NSString * )_searchText isBar:( BOOL )_isBar isQR:( BOOL )_isQr {
if ([_searchText isEqualToString:#""]) {
return;
}
NSMutableArray *ProductList = [[NSMutableArray alloc] init];
[ProductList addObjectsFromArray:[[DBModel database] productSearch:_searchText isBar:_isBar isQR:_isQr]];
if ( [ProductList count] == 0 ) {
UIAlertView *alert = [[UIAlertView alloc] initWithTitle:NSLocalizedString(#"product", #"")
message:NSLocalizedString(#"cannot_find_product", #"")
delegate:nil
cancelButtonTitle:NSLocalizedString(#"ok", #"")
otherButtonTitles:nil];
[alert show];
[alert release];
} else {
GeneralProductListViewController *generalProductList = [[GeneralProductListViewController alloc] initWithNibName:IS_IPAD?#"GeneralProductListView~iPad": #"GeneralProductListView" bundle:nil];
[generalProductList setMArProducts:ProductList];
[self.navigationController pushViewController:generalProductList animated:YES];
[generalProductList release];
}
[ProductList release];
}
-(IBAction) spin:(id)sender {
if([sender tag]==0)
{
[_deptCarousel scrollToItemAtIndex:[self.deptCarousel currentItemIndex]+1 animated:YES];
// [_deptCarousel scrollByNumberOfItems:1 duration:2.0];
}
else{
[_deptCarousel scrollToItemAtIndex:[self.deptCarousel currentItemIndex]-1 animated:YES];
}
}
-(void)swipeNext:(UISwipeGestureRecognizer *)recognizer{
[_deptCarousel scrollToItemAtIndex:[self.deptCarousel currentItemIndex]+1 animated:YES];
}
-(void)swipePrev:(UISwipeGestureRecognizer *)recognizer{
[_deptCarousel scrollToItemAtIndex:[self.deptCarousel currentItemIndex]-1 animated:YES];
}
-(void) handleSingleTap:(UITapGestureRecognizer *)recognizer{
if ([_categorymAr count] > 0) {
ProductCategoriesViewController *prodCatView = [[ProductCategoriesViewController alloc] initWithNibName:IS_IPAD ?
#"ProductCategoriesView~iPad" : #"ProductCategoriesView" bundle:nil];
Category *categoryObj = [_categorymAr objectAtIndex:[self.deptCarousel currentItemIndex]];
[prodCatView setStrTitle:categoryObj.categoryName];
[prodCatView setCategoryId:categoryObj.categoryId];
[Flurry logEvent:#"Category List" withParameters:[NSDictionary dictionaryWithObjectsAndKeys:categoryObj.categoryName,[NSString stringWithFormat:#"%d",categoryObj.categoryId], nil]];
[self.navigationController pushViewController:prodCatView animated:YES];
[prodCatView release];
}
}
//-(void) touchesBegan:(NSSet *)touches withEvent:(UIEvent *)event{
// pageControl.currentPage = [self.deptCarousel currentItemIndex] ;
//}
#pragma mark
#pragma mark NavigationBarViewDelegate metho
- ( void ) navigationBackClicked {
[self.navigationController popViewControllerAnimated:YES];
}
#pragma mark -
#pragma mark iCarousel methods
- (NSUInteger)numberOfItemsInCarousel:(iCarousel *)carousel
{
return [_carouselItems count];
}
- (NSUInteger)numberOfVisibleItemsInCarousel:(iCarousel *)carousel
{
//limit the number of items views loaded concurrently (for performance reasons)
return NUMBER_OF_VISIBLE_ITEMS;
}
- (UIView *)carousel:(iCarousel *)carousel viewForItemAtIndex:(NSUInteger)index
{
Category *categoryObj = [_categorymAr objectAtIndex:index];
//create a numbered view
UIView *view = nil;
NSString *imagePath = [[APP_CACHES_DIR stringByAppendingPathComponent:#"catalogues"] stringByAppendingString:[NSString stringWithFormat:#"/%d.jpg", categoryObj.categoryId]];
if (![[NSFileManager defaultManager] fileExistsAtPath:imagePath]) {
view = [[[UIImageView alloc] initWithImage:[UIImage imageNamed:IS_IPAD?#"Gallery Placeholder.png":#"Gallery Placeholder.png"]] autorelease];
} else {
view = [[[UIImageView alloc] initWithImage:[UIImage imageWithContentsOfFile:[[APP_CACHES_DIR stringByAppendingPathComponent:#"catalogues"] stringByAppendingString:[NSString stringWithFormat:#"/%d.jpg", categoryObj.categoryId]]]] autorelease];
}
if (IS_IPAD) {
view.frame = CGRectMake(0, 0, 420, 420);
} else {
view.frame = CGRectMake(0, 0, 200, 200);
}
// UILabel *label = [[[UILabel alloc] initWithFrame:CGRectMake(view.bounds.origin.x, view.bounds.origin.y+view.bounds.size.height, view.bounds.size.width, 44)] autorelease];
// label.text = categoryObj.categoryName;
// label.textColor = [UIColor blackColor];
// label.backgroundColor = [UIColor clearColor];
// label.textAlignment = UITextAlignmentCenter;
// label.font = [UIFont fontWithName:#"Helvetica-Bold" size:IS_IPAD?26:14];
// [view addSubview:label];
return view;
}
- (NSUInteger)numberOfPlaceholdersInCarousel:(iCarousel *)carousel
{
//note: placeholder views are only displayed on some carousels if wrapping is disabled
return INCLUDE_PLACEHOLDERS? 2: 0;
}
- (UIView *)carousel:(iCarousel *)carousel placeholderViewAtIndex:(NSUInteger)index
{
//create a placeholder view
UIView *view = [[[UIImageView alloc] initWithImage:[UIImage imageNamed:#""]] autorelease];
UILabel *label = [[[UILabel alloc] initWithFrame:view.bounds] autorelease];
label.text = (index == 0)? #"[": #"]";
label.backgroundColor = [UIColor clearColor];
label.textAlignment = UITextAlignmentCenter;
label.font = [label.font fontWithSize:50];
_spacePageControl.currentPage = index;
// [view addSubview:label];
return view;
}
- (CGFloat)carouselItemWidth:(iCarousel *)carousel
{
//usually this should be slightly wider than the item views
return ITEM_SPACING;
}
- (CATransform3D)carousel:(iCarousel *)_carousel transformForItemView:(UIView *)view withOffset:(CGFloat)offset
{
//implement 'flip3D' style carousel
//set opacity based on distance from camera
view.alpha = 1.0 - fminf(fmaxf(offset, 0.0), 1.0);
//do 3d transform
CATransform3D transform = CATransform3DIdentity;
transform.m34 = _deptCarousel.perspective;
transform = CATransform3DRotate(transform, M_PI / 8.0, 0, 1.0, 0);
return CATransform3DTranslate(transform, 0.0, 0.0, offset * _deptCarousel.itemWidth);
}
- (BOOL)carouselShouldWrap:(iCarousel *)carousel
{
//wrap all carousels
// return NO;
return wrap;
}
- (void)carousel:(iCarousel *)carousel didSelectItemAtIndex:(NSInteger)index {
if (index == [self.deptCarousel currentItemIndex]) {
ProductCategoriesViewController *prodCatView = [[ProductCategoriesViewController alloc] initWithNibName:IS_IPAD ?
#"ProductCategoriesView~iPad" : #"ProductCategoriesView" bundle:nil];
Category *categoryObj = [_categorymAr objectAtIndex:index];
[prodCatView setStrTitle:categoryObj.categoryName];
[prodCatView setCategoryId:categoryObj.categoryId];
[Flurry logEvent:#"Category List" withParameters:[NSDictionary dictionaryWithObjectsAndKeys:categoryObj.categoryName,[NSString stringWithFormat:#"%d",categoryObj.categoryId], nil]];
[self.navigationController pushViewController:prodCatView animated:YES];
[prodCatView release];
}
}
-(void) carouselDidScroll:(iCarousel *)carousel{
// [_deptCarousel scrollToItemAtIndex:[self.deptCarousel currentItemIndex]+3 animated:YES];
// [_deptCarousel scrollByNumberOfItems:1 duration:1];
}
- (void)carouselCurrentItemIndexUpdated:(iCarousel *)carousel{
_spacePageControl.currentPage = [self.deptCarousel currentItemIndex];
}
- ( IBAction ) myCart {
if ( [[DBModel database] isShoppingListEmpty] ) {
UIAlertView *alert = [[UIAlertView alloc] initWithTitle:NSLocalizedString(#"at_shopping_cart", #"")
message:NSLocalizedString(#"amsg_shopping_cart_empty", #"")
delegate:nil cancelButtonTitle:NSLocalizedString(#"ok", #"") otherButtonTitles:nil];
[alert show];
[alert release];
return;
}
MyCartViewController *myCartView = [[MyCartViewController alloc] initWithNibName:IS_IPAD ? #"MyCartView~iPad" : #"MyCartView" bundle:nil];
[self.navigationController pushViewController:myCartView animated:YES];
[myCartView release];
}
First, as noted before, use ARC. There is no single thing you could do that will more improve memory management.
Whether you use ARC or not, you should always use accessors to access your ivars (except in init and dealloc). As noted by #LombaX, you're setting your ivars incorrectly in viewDidLoad. Using accessors would help this.
You should run the static analyzer, which will help you find other memory mistakes.
I would suspect that you have an IBOutlet that is configured as retain and that you are not releasing in dealloc. That is the most likely cause of the leaks I'm seeing in your screenshots. ARC will generally make such problems go away automatically.
It is very possible that you have a retain loop. This generally would not show up as a leak. You should use heapshot to investigate that. Your leaks are pretty small; they may not be the actual cause of memory warnings. What you want to investigate (with the Allocations instrument) is what is actually significantly growing your memory use.
But first ARC. Then accessors. Then remove all build warnings. Then remove all Static Analyzer warnings. Then use the Allocations instrument.
Side note: the fact that it says the responsible party is "UIKit" does not mean that this is a bug in UIKit. It just means that UIKit allocated the memory that was later leaked. The cause of the leak could be elsewhere. (That said, UIKit does have several small leaks in it. In general they should not give you trouble, but you may never be able to get rid of 100% of small leaks in an iOS app.)
First:
you have a possible and visible leak, but I'm not sure if it is the same leak you have found in instruments:
These two lines are in your viewDidLoad method
_carouselItems = [[NSMutableArray alloc] initWithCapacity:1];
_categorymAr = [[NSMutableArray alloc] initWithCapacity:1];
But: viewDidLoad: is called every time the view is loaded by it's controller. If the controller purges the view (for example after a memory warning), at the second viewDidLoad your _carouselItems and _categorymAr instance variables will lost the reference to the previously created NSMutableArray, causing a leak
So, change that lines and use the syntesized setters:
self.carouselItems = [[[NSMutableArray alloc] initWithCapacity:1] autorelease];
self.categorymAr = [[[NSMutableArray alloc] initWithCapacity:1] autorelease];
the syntesized setter is configured to release the previous object before assignin a new one.
However: it's possible that you have another leak.
If you can reproduce the leak simply (if I understand, the leak appears simply moving from a VC to another), you can use the "heapshot" function of instruments.
Assuming that your leak appears moving from the first VC to the second and coming back:
open instruments with the allocations tool
go from the first VC to the second and come back.
press "mark heap" on the left. A line will appear.
go again from the first VC to the second and come back.
press "heapshot" again
do this several times (9-10)
the heapshot tool takes a "snapshot" of the living objects at the time you pushed the button and shows you only the difference.
If there are 2-3 new objects, you will see it in the list.
This is a good starting point to investigate a leak.
Look at the attached image:
Consider that you must mark the heap several time and discriminate "false positive" by looking at the object created, in my example you can se a possible leak (heapshot5, 1,66KB), but after looking at the content it's not --> it was a background task that started in that moment.
Moreover, delays of the autorelease pool and the cache of some UIKit objects can show something in the heapshot, this is why I say to try it several times.
One easy way to detect where your leaks come from is to use the Extended Detail view of the Instruments.
To do that click on "View"->"Extended detail" and a right menu with the stack trace of the "leak" will appear. There you will easily find the leaking code for each leak and if they come from your app.

Resources