Defining greater than for a iPhone 6 screen size? - ios

Question

I am using code which shows a certain xib file depending on the device, at the moment 3 xibs, one for iPhone4, one for iPhone5 and one for iPad.
Since iOS8 / iPhone 6, the app does not work on anything higher than the 5s due to the fact the xib does not know what to load;
- (IBAction)btnTapForStart:(id)sender {
fromOtherClass=YES;
if([[UIScreen mainScreen]bounds].size.height == 568)
{
PlayMusicViewController *pmvc = [[PlayMusicViewController alloc]initWithNibName:#"XibForIPhone5" bundle:[NSBundle mainBundle]];
[self.navigationController pushViewController:pmvc animated:YES];
}
else
{
PlayMusicViewController *pmvc = [[PlayMusicViewController alloc]init];
[self.navigationController pushViewController:pmvc animated:YES];
}
[appObject.audioPlayer stop];
}
If I change the value of 568 to higher it will work, but is there a way to combine it, for example, height is 568 OR iPhone6 size OR iPhone 6 plus size etc?

Answer 1

You probably should use auto-layout like Maddy says, but if you want to have code that works for specific devices, then you might want to implement this utility method. Then you can create as many xibs as you want and target them to specific devices. e.g.
if ([[Utilities deviceType] isEqualToString:#"iPhone Retina4"] || [[Utilities deviceType] isEqualToString:#"iPhone Retina35"] ) {
-- do something specific for these phones
}
I put this method in a Utilities class.
+ (NSString *)deviceType {
NSString *device = nil;
CGSize screenSize = [[UIScreen mainScreen] bounds].size;
CGFloat deviceScale = [UIScreen mainScreen].scale;
if (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPhone) {
device = #"iPhone Classic"; // Just in case it doesn't make it through the conditionals
// Classic has a resolution of 480 × 320
if( (screenSize.height == 480 || screenSize.width == 480) && deviceScale == 1.0f ) {
device = #"iPhone Classic";
// Retina has a resolution of 960 × 640
} else if( (screenSize.height == 480 || screenSize.width == 480) && deviceScale == 2.0f ) {
device = #"iPhone Retina35";
// Retina 4" has a resolution of 1136 x 640
} else if (screenSize.height == 568 || screenSize.width == 568 ) {
device = #"iPhone Retina4";
// iPhone 6 has a resolution of 1334 by 750
} else if (screenSize.height == 667 || screenSize.width == 667 ) {
device = #"iPhone 6";
// iPhone 6 Plus has an actual size of 2208 × 1242 and resolution of 1920 by 1080
// Reported size is 736 x 414
} else if (screenSize.height == 736 || screenSize.width == 736 ) {
device = #"iPhone 6 Plus";
}
} else if (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad) {
device = #"iPad Classic"; // Just in case it doesn't make it through the conditionals
if(deviceScale == 1.0f) {
device = #"iPad Classic";
} else if (deviceScale == 2.0f) {
device = #"iPad Retina";
}
}
//NSLog(#"The device is %# scale is %f and the height is %f and width is %f", device, deviceScale, screenSize.height, screenSize.width);
return device;
}

Answer 2

I did some research on enums and they are nice. They make the code a bit more readable, but mostly they allow the compiler to help you type and catch errors. Xcode will autocomplete your deviceType for you and will give you the error: Use of undeclared identifier if you try to use a value that isn’t defined. Here’s the code rewritten as an enum. I prefixed the values with LF but you should use whatever is appropriate for your project.
This is in my header file
// Devices as of Fall 2014
typedef NS_ENUM(NSInteger, LFdeviceType) {
LFDeviceTypePhoneClassic,
LFDeviceTypePhoneRetina3_5,
LFDeviceTypePhoneRetina4,
LFDeviceTypePhone6,
LFDeviceTypePhone6Plus,
LFDeviceTypePadClassic,
LFDeviceTypePadRetina,
};
And this is in my .m file.
m+ (NSInteger)deviceType {
CGSize screenSize = [[UIScreen mainScreen] bounds].size;
CGFloat deviceScale = [UIScreen mainScreen].scale;
LFdeviceType device = LFDeviceTypePhoneClassic;
if (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPhone) {
device = LFDeviceTypePhoneClassic; // Just in case it doesn't make it through the conditionals
// Classic has a resolution of 480 × 320
if( (screenSize.height == 480 || screenSize.width == 480) && deviceScale == 1.0f ) {
device = LFDeviceTypePhoneClassic;
// Retina has a resolution of 960 × 640
} else if( (screenSize.height == 480 || screenSize.width == 480) && deviceScale == 2.0f ) {
device = LFDeviceTypePhoneRetina3_5;
// Retina 4" has a resolution of 1136 x 640
} else if (screenSize.height == 568 || screenSize.width == 568 ) {
device = LFDeviceTypePhoneRetina4;
// iPhone 6 has a resolution of 1334 by 750
} else if (screenSize.height == 667 || screenSize.width == 667 ) {
device = LFDeviceTypePhone6;
// iPhone 6 Plus has an actual size of 2208 × 1242 and resolution of 1920 by 1080
// Reported size is 736 x 414
} else if (screenSize.height == 736 || screenSize.width == 736 ) {
device = LFDeviceTypePhone6Plus;
}
} else if (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad) {
device = LFDeviceTypePadClassic; // Just in case it doesn't make it through the conditionals
if(deviceScale == 1.0f) {
device = LFDeviceTypePadClassic;
} else if (deviceScale == 2.0f) {
device = LFDeviceTypePadRetina;
}
}
//NSLog(#"The device is %# scale is %f and the height is %f and width is %f", device, deviceScale, screenSize.height, screenSize.width);
return device;
}
Call it like this:
if ( ( [Utilities deviceType] == LFDeviceTypePhoneClassic
|| [Utilities deviceType] == LFDeviceTypePhoneRetina3_5) &&
numberOfFoilsOnScreen > 7 ) {
numberOfFoilsOnScreen = 7;
}