How to sucessfully call a BOOL method in an if statement? [duplicate] - ios

Question

This question already has answers here:
Return value for function inside a block
(3 answers)
Closed 8 years ago.
Updated:
I am trying to call a method from a different class and put it in an if statement saying "if the uploadPhoto method is true then display success for testing purposes" here is my updated code:
PhotoScreen *script = [[PhotoScreen alloc] init];
if ([script uploadPhoto])
{
NSLog(#"Sucess!");
}
It isn't giving me the error anymore but when I summit the photo from the uploadPhoto method, it does't log the "Success" And here is my uploadPhoto method:
- (BOOL)uploadPhoto
{
//upload the image and the title to the web service
[[API sharedInstance] commandWithParams:[NSMutableDictionary dictionaryWithObjectsAndKeys:
#"upload",#"command",
UIImageJPEGRepresentation(photo.image,70),#"file",
fldTitle.text, #"title",nil]
onCompletion:^(NSDictionary *json)
{
//completion
if (![json objectForKey:#"error"])
{
//success
[[[UIAlertView alloc]initWithTitle:#"Success!"
message:#"Your photo is uploaded"
delegate:nil cancelButtonTitle:#"Yay!"
otherButtonTitles: nil] show];
}
else
{
//error, check for expired session and if so - authorize the user
NSString* errorMsg = [json objectForKey:#"error"];
[UIAlertView error:errorMsg];
if ([#"Authorization required" compare:errorMsg]==NSOrderedSame)
{
[self performSegueWithIdentifier:#"ShowLogin" sender:nil];
}
}
}];
return YES;
}
What am I doing wrong?

Answer 1

You method needs to return a BOOL. In your method you should have the statement return YES; somewhere if the method succeeds and a return NO; if it fails. You can modify your code to the following:
PhotoScreen *script = [[PhotoScreen alloc] init];
if ([script uploadPhoto])
{
NSLog(#"Sucess!");
}
The repetitive method calls were unnecessary along with the comparison.