I the look and feel of my new form for a new Opportunity (put in some tables, css, etc...) and now my "submit" button won't work. It doesn't create a new record nor does it perform any of the validation callbacks... I was wondering if anyone could help me? Here is the output from the terminal:
Started GET
"/opportunities/new?utf8=%E2%9C%93&authenticity_token=e31DA70sbl%2B3%2FJCeoTcxCTWncLcVs6R6FvR0ZU6vSmA%3D&opportunity%5Bdepartment%5D=DHS&opportunity%5Bagency%5D=asdf&opportunity%5Bprogram_name%5D=fdas&opportunity%5Bstage%5D=Assessment&opportunity%5Bcapture_manager%5D=Sherry+Hwang&opportunity%5Bprogram_description%5D=asdfadsf&opportunity%5Bnew_or_recompete%5D=Re-Compete&opportunity%5Bincumbent%5D=Adsf&opportunity%5Bcurent_contract_vehicle%5D=fdas&opportunity%5Bnew_contract_vehicle%5D=fdas&opportunity%5Bsb_set_aside%5D=Yes&opportunity%5Bprime_or_sub%5D=Prime&opportunity%5Bnaics%5D=234&opportunity%5Brfi_date%281i%29%5D=&opportunity%5Brfi_date%282i%29%5D=&opportunity%5Brfi_date%283i%29%5D=&opportunity%5Brfi_submitted%5D=&opportunity%5Best_rfp_date%281i%29%5D=&opportunity%5Best_rfp_date%282i%29%5D=&opportunity%5Best_rfp_date%283i%29%5D=&opportunity%5Best_full_value%5D=fdsa&opportunity%5Best_workshare%5D=asdf&opportunity%5Bp_win%5D=asdf&opportunity%5Bgovwin_id%5D=adsf&commit=Create+Opportunity"
for 127.0.0.1 at 2014-07-02 10:10:16 -0400
Processing by OpportunitiesController#new as HTML
Parameters: {"utf8"=>"✓", "authenticity_token"=>"e31DA70sbl+3/JCeoTcxCTWncLcVs6R6FvR0ZU6vSmA=",
"opportunity"=>{"department"=>"DHS", "agency"=>"asdf",
"program_name"=>"fdas", "stage"=>"Assessment",
"capture_manager"=>"Sherry Hwang", "program_description"=>"asdfadsf",
"new_or_recompete"=>"Re-Compete", "incumbent"=>"Adsf",
"curent_contract_vehicle"=>"fdas", "new_contract_vehicle"=>"fdas",
"sb_set_aside"=>"Yes", "prime_or_sub"=>"Prime", "naics"=>"234",
"rfi_date(1i)"=>"", "rfi_date(2i)"=>"", "rfi_date(3i)"=>"",
"rfi_submitted"=>"", "est_rfp_date(1i)"=>"", "est_rfp_date(2i)"=>"",
"est_rfp_date(3i)"=>"", "est_full_value"=>"fdsa",
"est_workshare"=>"asdf", "p_win"=>"asdf", "govwin_id"=>"adsf"},
"commit"=>"Create Opportunity"}
User Load (0.2ms) SELECT "users".* FROM "users" WHERE "users"."id" = ? LIMIT 1 [["id", 9]]
User Load (0.2ms) SELECT "users".* FROM "users"
Rendered opportunities/_form.html.erb (7.4ms)
Rendered opportunities/new.html.erb within layouts/application (8.1ms)
Completed 200 OK in 53ms (Views: 49.9ms | ActiveRecord: 0.4ms)
And here is my Opportunity controller:
class OpportunitiesController < ApplicationController
before_action :set_opportunity, only: [:show, :edit, :update, :destroy]
before_action :authenticate
helper_method :sort_column, :sort_direction
def index
#opportunities = Opportunity.where.not(stage: 'Retired').order(sort_column + " " + sort_direction)
respond_to do |format|
format.html
format.csv {send_data #opportunities.to_csv}
#format.xls {send_data #opportunities.to_csv(col_sep: "\t")}
end
end
def show
#opportunity = Opportunity.find(params[:id])
#render json: #opportunity
end
def new
#opportunity = Opportunity.new
end
def edit
end
def create
#opportunity = Opportunity.new(opportunity_params)
#opportunity.created_by = current_user.full_name
respond_to do |format|
if #opportunity.save
#opportunity.created_by = current_user.full_name
format.html { redirect_to #opportunity, notice: 'Opportunity was successfully created.' }
format.json { render :show, status: :created, location: #opportunity }
else
format.html { render :new }
format.json { render json: #opportunity.errors, status: :unprocessable_entity }
end
end
end
def update
respond_to do |format|
if #opportunity.update(opportunity_params)
format.html { redirect_to #opportunity, notice: 'Opportunity was successfully updated.' }
format.json { render :show, status: :ok, location: #opportunity }
else
format.html { render :edit }
format.json { render json: #opportunity.errors, status: :unprocessable_entity }
end
end
end
def destroy
#opportunity.destroy
respond_to do |format|
format.html { redirect_to opportunities_url, notice: 'Opportunity was successfully destroyed.' }
format.json { head :no_content }
end
end
private
def set_opportunity
#opportunity = Opportunity.find(params[:id])
end
def opportunity_params
params.require(:opportunity).permit(:department, :created_by, :capture_manager, :stage, :agency, :program_name, :program_description, :new_or_recompete, :incumbent, :curent_contract_vehicle, :new_contract_vehicle, :sb_set_aside, :prime_or_sub, :naics, :rfi_date, :rfi_submitted, :est_rfp_date, :est_full_value, :est_workshare, :p_win, :derated_sales, :govwin_id)
end
private
def sort_column
Opportunity.column_names.include?(params[:sort]) ? params[:sort] : "department"
end
def sort_direction
%w[asc desc].include?(params[:direction]) ? params[:direction]: "asc"
end
end
My view:
<%= form_for(#opportunity) do |f| %>
<% if #opportunity.errors.any? %>
<div id="error_explanation">
<h2><%= pluralize(#opportunity.errors.count, "error") %> prohibited this opportunity from being saved:</h2>
<ul>
<% #opportunity.errors.full_messages.each do |message| %>
<li><%= message %></li>
<% end %>
</ul>
</div>
<% end %>
<table id="new_opp_form" style="width: 450px; background-color: white; border-style: none; border:1px orange;">
<tr style="background-color: white">
<td>Agency</td>
<td><%= f.text_field :agency %></td>
</tr>
<tr style="background-color: white">
<td>Program Name</td>
<td><%= f.text_field :program_name %></td>
</tr>
<tr style="background-color: white">
<td>Stage</td>
<td><%= f.select :stage, [[],['Assessment', 'Assessment'], ['Pre-Proposal', 'Pre-Proposal'], ['Proposal', 'Proposal'], ['Subitted', 'Submitted'],['Retired', 'Retired']] %></td>
</tr>
<tr style="background-color: white">
<td>Capture Manager</td>
<td><%= f.collection_select(:capture_manager, User.all, :full_name,:full_name,{:prompt => true}) %></td>
</tr>
<tr style="background-color: white">
<td>Program Description</td>
<td><%= f.text_area :program_description %></td>
</tr>
<tr style="background-color: white">
<td>New or Re-recompete</td>
<td><%= f.select :new_or_recompete, [[],['New', 'New'], ['Re-Compete', 'Re-Compete']] %></td>
</tr>
<tr style="background-color: white">
<td>Incumbent</td>
<td><%= f.text_field :incumbent %></td>
</tr>
<tr style="background-color: white">
<td>Current Contract Vehicle</td>
<td><%= f.text_field :curent_contract_vehicle %></td>
</tr>
<tr style="background-color: white">
<td>New Contract Vehicle</td>
<td><%= f.text_field :new_contract_vehicle %></td>
</tr>
<tr style="background-color: white">
<td>Small Business Set Aside?</td>
<td><%= f.select :sb_set_aside, [[],['Yes', 'Yes'], ['No', 'No']] %></td>
</tr>
<tr style="background-color: white">
<td>Prime or Sub</td>
<td><%= f.select :prime_or_sub, [[],['Prime', 'Prime'], ['Sub', 'Sub']] %></td>
</tr>
<tr style="background-color: white">
<td>NAICS</td>
<td><%= f.text_field :naics %></td>
</tr>
<tr style="background-color: white">
<td>RFI Date</td>
<td><%= f.date_select :rfi_date, {:include_blank => true, :default => nil} %></td>
</tr>
<tr style="background-color: white">
<td>RFI Submitted?</td>
<td><%= f.select :rfi_submitted, [[],['Yes', 'Yes'], ['No', 'No']] %></td>
</tr>
<tr style="background-color: white">
<td>Est. RFP Date</td>
<td><%= f.date_select :est_rfp_date, {:include_blank => true, :default => nil} %></td>
</tr>
<tr style="background-color: white">
<td>Est. Full Value</td>
<td><%= f.text_field :est_full_value%></td>
</tr>
<tr style="background-color: white">
<td>Est. Workshare (%)</td>
<td><%= f.text_field :est_workshare %></td>
</tr>
</table>
<div class="actions">
<%= f.submit %>
</div>
<% end %>
My routes file:
Rails.application.routes.draw do
resources :test_users
get 'profile/my_profile'
get "log_out" => "sessions#destroy", :as => "log_out"
get "log_in" => "sessions#new", :as => "log_in"
get "sign_up" => "users#new", :as => "sign_up"
root :to => "sessions#new"
get 'view_submitted/submitted'
get 'view_action_list/seven'
get 'show_number/thirty'
get 'show_number/sixty'
get 'show_number/year'
get 'view_retired/retired'
resources :users
resource :sessions
get 'report/report_page'
resources :opportunities do
resources :activities
resources :updates
resources :contacts
resources :links
end
First, your submit button is in your view, please post that. :)
Second, you're doing an HTTP GET with the parameters that would typically be in a POST. Have you specified your method: :get in the form for some reason accidentally?
Related
project_site model has one attribute submission_status. i want to set that status from index#action for there corresponding row. i want on submit button click on each row to change there correspong submission_status to true. how can i do this in rails 5.
project_sites_controller.rb
def index
#project_sites = current_user.project_sites
end
def new
#project_site = current_user.project_sites.build
end
def create
#project_site = current_user.project_sites.build(project_site_params)
#users = current_user.director_id
#projects = Project.where(user_id: #users)
respond_to do |format|
if #project_site.save
format.html { redirect_to project_sites_url, notice: 'Attendance was successfully Uploaded.' }
format.json { render :show, status: :created, location: #project_site }
else
format.html { render :new }
format.json { render json: #project_site.errors, status: :unprocessable_entity }
end
end
end
def update
#users = current_user.director_id
#projects = Project.where(user_id: #users)
respond_to do |format|
if #project_site.update(project_site_params)
format.html { redirect_to project_sites_url, notice: 'Attendance was successfully updated.' }
format.json { render :show, status: :ok, location: #project_site }
else
format.html { render :edit }
format.json { render json: #project_site.errors, status: :unprocessable_entity }
end
end
end
index.html.erb
<table>
<thead>
<tr>
<th>Uploaded Date</th>
<th>Attendance File</th>
<th>Submit Attendance</th>
</tr>
</thead>
<tbody>
<% #project_sites.each do |project_site| %>
<tr>
<td><%= project_site.created_at.strftime('%d-%m-%Y') %></td>
<td><%= link_to "View Attendance", project_site.attendance.url, :class => "fi-page-export-csv" %></td>
<td>
<%= form_for ProjectSite.new do |f| %>
<%#f.hidden_field :project_site_id, value: project_site.id%>
<%=f.hidden_field :submission_status, value: true%>
<div>
<%= f.submit 'Submit', :class => 'button primary small float-right' %>
</div>
<% end %>
</tr>
<% end %>
</tbody>
</table>
add a route for an action which set status
#routes.rb
resources :project_sites do
put :set_submission_status, on: :member
end
define action which set status
#submission_status_controller.rb
def set_submission_status
#project_site = ProjectSite.find(params[:id])
#project_site.update(submission_status: true)
redirect_to project_sites_path
end
replace form_for with following link
#view
= link_to set_submission_status_project_site_path(project_site), method: :put
You have to pass the id of project_site for which you want to update the submission_status and on the controller updates the same project_site(id pass as hidden field), for this you need write **ajax** call
<table>
<thead>
<tr>
<th>Uploaded Date</th>
<th>Attendance File</th>
<th>Submit Attendance</th>
</tr>
</thead>
<tbody>
<% #project_sites.each do |project_site| %>
<tr>
<td><%= project_site.created_at.strftime('%d-%m-%Y') %></td>
<td><%= link_to "View Attendance", project_site.attendance.url, :class => "fi-page-export-csv" %></td>
<td>
<%= form_for ProjectSite.new do |f| %>
<%#f.hidden_field :project_site_id, value: project_site.id%>
<%=f.hidden_field :submission_status, value: true%>
<%= f.hidden_field :project_site_id, project_site.id%>
<div>
<%= f.submit 'Submit', :class => 'button primary small float-right' %>
</div>
<% end %>
</tr>
<% end %>
</tbody>
</table>
I'm new to ruby on rails and I'm having trouble with importing a csv file with data to db. I have been looking around but most of the similar questions on here did not solve this issue.
Problem: param is missing or the value is empty: incident_datum
I understand that this issue is caused by the action controller due to the params.require( but removing it doesn't help because the csv file just gets temporarily uploaded but no data gets extracted from it.
Here are the supporting files =>
Controller:
class IncidentDataController < ApplicationController
before_action :set_incident_datum, only: [:show, :edit, :update, :destroy]
# GET /incident_data
# GET /incident_data.json
def index
#incident_data = IncidentDatum.all
#incident_data_first_20 = IncidentDatum.first(20)
end
def import
IncidentDatum.import(params[:file])
if #IncidentDatum.save
# after import, redirect and let us know the method worked!
redirect_to root_url, notice: "Incident Data Imported!"
else
render :new
end
end
# GET /incident_data/1
# GET /incident_data/1.json
def show
#distinct_number = IncidentDatum.distinct.pluck(:number).sort
end
# GET /incident_data/new
def new
#incident_datum = IncidentDatum.new
end
# GET /incident_data/1/edit
def edit
end
# POST /incident_data
# POST /incident_data.json
def create
#incident_datum = IncidentDatum.new(incident_datum_params)
respond_to do |format|
if #incident_datum.save
format.html { redirect_to #incident_datum, notice: 'Incident datum was successfully created.' }
format.json { render :show, status: :created, location: #incident_datum }
else
format.html { render :new }
format.json { render json: #incident_datum.errors, status: :unprocessable_entity }
end
end
end
# PATCH/PUT /incident_data/1
# PATCH/PUT /incident_data/1.json
def update
respond_to do |format|
if #incident_datum.update(incident_datum_params)
format.html { redirect_to #incident_datum, notice: 'Incident datum was successfully updated.' }
format.json { render :show, status: :ok, location: #incident_datum }
else
format.html { render :edit }
format.json { render json: #incident_datum.errors, status: :unprocessable_entity }
end
end
end
# DELETE /incident_data/1
# DELETE /incident_data/1.json
def destroy
#incident_datum.destroy
respond_to do |format|
format.html { redirect_to incident_data_url, notice: 'Incident datum was successfully destroyed.' }
format.json { head :no_content }
end
end
private
# Use callbacks to share common setup or constraints between actions.
def set_incident_datum
#incident_datum = IncidentDatum.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.
def incident_datum_params
params.require(:incident_datum).permit(
:number,
:priority,
:state,
:description,
:short_description1,
:ticket_type,
:task_type,
:opened,
:closed,
:initial_contact,
:configuration_item,
:environment,
:assignment_group,
:reassignment_count,
:department,
:name,
:problem,
:short_description2)
#MG what to do with '.require(:incident_datum)' after params?
end
end
Import:
<div id="import" class="well" style="display:inline-block;width:100%">
<h3 style="margin-top:0px;">Import Data</h3>
<div id="" style="float:left; flex:1;">
<%= form_tag incident_data_path, multipart: true do %>
<%= file_field_tag :file, :style=>'width: 600px;' %>
</div>
<div style="float:right; flex:1;">
<%= submit_tag "Import CSV" %>
</div>
<% end %>
</div>
<a class="btn btn-info" href="/incident_data/">Incident Data</a>
Index.html.erb
<p id="notice"><%= notice %></p>
<h1 style="float:left;">Incident Data</h1><br />
<div class="btn btn-info" style="float:right;">
<%= link_to 'New Incident Datum', new_incident_datum_path%>
</div><br /><br /><br />
<div style="overflow-y:auto;height:600px;">
<%= flash[:notice] %> <!-- Why was this commented out? </th-->
<table class="table table-striped">
<thead>
<tr>
<th>Number</th>
<th>Priority</th>
<th>State</th>
<th>Description</th>
<th>Short description1</th> <!-- Why was this commented out? </th-->
<th>Ticket type</th>
<th>Task type</th>
<th style="display:none">Opened</th>
<th style="display:none">Closed</th>
<th style="display:none">Initial contact</th>
<th>Configuration item</th>
<th>Environment</th>
<th>Assignment group</th>
<th>Reassignment count</th>
<th>Department</th>
<th>Name</th>
<th>Problem</th>
<th>Short description2</th> <!-- Why was this commented out? </th-->
<th colspan="3"></th>
</tr>
</thead>
<!----------------------------------------------------------------------------
[] BREADCRUMS - SHOWS WHERE WE ARE IN THE PAGE
[] PAGEINATOR - GOOGLE THING THAT ALLOWS YOU TO CHOOSE BETWEEN MULTIPLE PAGES //look on main_page.html
----------------------------------------------------------------------------->
<tbody id="descList">
<% #incident_data_first_20.each do |incident_datum| %>
<tr>
<td><%= incident_datum.number %></td>
<td><%= incident_datum.priority %></td>
<td><%= incident_datum.state %></td>
<td data-toggle="modal" data-target="#descModal"><%= incident_datum.short_description1 %></td>
<td><%= incident_datum.ticket_type %></td>
<td><%= incident_datum.task_type %></td>
<td style="display:none"><%= incident_datum.opened %></td>
<td style="display:none"><%= incident_datum.closed %></td>
<td style="display:none"><%= incident_datum.initial_contact %></td>
<td><%= incident_datum.configuration_item %></td>
<td><%= incident_datum.environment %></td>
<td><%= incident_datum.assignment_group %></td>
<td><%= incident_datum.reassignment_count %></td>
<td><%= incident_datum.department %></td>
<td><%= incident_datum.name %></td>
<td><%= incident_datum.problem %></td>
<td style="display:none"><%= incident_datum.description %></td>
<td style="display:none"><%= incident_datum.short_description2 %></td>
<td><%= link_to 'Show', incident_datum %></td>
<td><%= link_to 'Edit', edit_incident_datum_path(incident_datum) %></td>
<td><%= link_to 'Destroy', incident_datum, method: :destroy, data: { confirm: 'Are you sure?' } %></td>
</tr>
<% end %>
</tbody>
</table>
</div>
<%= render partial: "modal", locals: {zone: #zone} %>
routes:
Rails.application.routes.draw do
#resources :incident_data
# INDEX
#root to: 'analysis#main_page'
# Database Tables
resources :incident_data do
collection { post :import }
end
root to: 'analysis#main_page' #MG
# ADDITIONAL PAGES
get 'analysis/main_page'
get 'analysis/new_tile'
get 'analysis/ticket_identification'
get 'analysis/detailed_view'
get 'analysis/import_data'
get 'analysis/test'
# For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
end
Console:
Processing by IncidentDataController#create as HTML
Parameters: {"utf8"=>"✓", "authenticity_token"=>"lBXX210GVPazui46U8rATpzrXCMJw8DAqb7Hc3WWK2uTU3WGojClRU7+ZKkakCjUblweOV7UpM+FiIvRSNzSng==", "file"=>#<ActionDispatch::Http::UploadedFile:0x00000002829388 #tempfile=#<Tempfile:/tmp/RackMultipart20180110-11292-jzqi2l.csv>, #original_filename="incident_datum.csv", #content_type="application/vnd.ms-excel", #headers="Content-Disposition: form-data; name=\"file\"; filename=\"incident_datum.csv\"\r\nContent-Type: application/vnd.ms-excel\r\n">, "commit"=>"Import CSV"}
Completed 400 Bad Request in 2ms (ActiveRecord: 0.0ms)
ActionController::ParameterMissing (param is missing or the value is empty: incident_datum):
app/controllers/incident_data_controller.rb:84:in `incident_datum_params'
app/controllers/incident_data_controller.rb:39:in `create'
^C- Gracefully stopping, waiting for requests to finish
=== puma shutdown: 2018-01-10 14:20:33 +0000 ===
- Goodbye!
Exiting
Thank you!
I think your problem is your Form (if you want keep rails convention), you have to create a IncidentDatum element and create a form for this element like:
<%= form_for #incident_data , multipart: true do %>
...
With this you create a form like incident_datum : { file: .... }
This format you spec in the def incident_datum_params method
params.require(:incident_datum).permit( :number , ....
Also you need to add file to permit
params.require(:incident_datum).permit( :number , :file , ....
You can see the format of your post in your console browser network tab and also in the log you post in the question:
Processing by IncidentDataController#create as HTML Parameters:
{"utf8"=>"✓",
"authenticity_token"=>"lBXX210GVPazui46U8rATpzrXCMJw8DAqb7Hc3WWK2uTU3WGojClRU7+ZKkakCjUblweOV7UpM+FiIvRSNzSng==",
"file"=>#,
#original_filename="incident_datum.csv",
#content_type="application/vnd.ms-excel",
#headers="Content-Disposition: form-data; name=\"file\";
filename=\"incident_datum.csv\"\r\nContent-Type:
application/vnd.ms-excel\r\n">, "commit"=>"Import CSV"} Completed 400
Bad Request in 2ms (ActiveRecord: 0.0ms)
You can see file direct in the params ( no inside incident_data incident_data: { fiel: .... } )
I have a method called calculation_of_total_cost in model Tippy
It's running into problems being called in index.html.erb via tippies views directory.
This is the error I receive: undefined method*' for nil:NilClass`
I have googled it, and now understand that it is the result of the one of the variables being nil.
How do I resolve this, i.e, how do I make the method work in index.html.erb? This is index view that I am calling it from, so I need an instance method, not class, right?
Also, addendum: this same method works fine in show.html.erb
show.html.erb
<br/><br/>
<h1 class="text-center">Your Total Cost</h1>
<br/><br />
<table class="table table-striped">
<tr>
<td>
Cost of Your Meal:
</td>
<td>
<%= humanized_money_with_symbol #tippy.cost %>
</td>
</tr>
<tr>
<td>
Tip You Picked:
</td>
<td>
<%= number_to_percentage(#tippy.tip * 100, format: "%n%", precision: 0) %>
</td>
</tr>
<tr>
<td>
The Total Cost:
</td>
<td>
<%= humanized_money_with_symbol #tippy.calculation_of_total_cost %>
</td>
</tr>
</table>
<%= link_to 'New Tippy', new_tippy_path %>
<%= link_to "Index", tippies_path %>
Here is the Tippy model:
class Tippy < ApplicationRecord
validates :tip, presence: true
validates :cost, presence: true
#monetize :tip_cents
monetize :cost_cents, :numericality => {:greater_than => 0}
TIP_CHOICES = { "10%" => ".10", "20%" => ".20", "30%" => ".30", "40%" => ".40", "50%" => ".50",
"60%" => ".60", "70%" => ".70", "80%" => ".80", "90%" => ".90" }
def calculation_of_total_cost
cost + (tip * cost)
end
end
Here is the index.html.erb file
<p id="notice"><%= notice %></p>
<h1>Tippies</h1>
<table>
<thead>
<tr>
<th>Tip</th>
<th>Cost</th>
<th>Total</th>
<th colspan="3"></th>
</tr>
</thead>
<tbody>
<% #tippies.each do |tippy| %>
<tr>
<td><%= tippy.tip %></td>
<td><%= tippy.cost %></td>
<td><%= tippy.calculation_of_total_cost %></td>
<td><%= link_to 'Show', tippy %></td>
<td><%= link_to 'Edit', edit_tippy_path(tippy) %></td>
<td><%= link_to 'Destroy', tippy, method: :delete, data: { confirm: 'Are you sure?' } %></td>
</tr>
<% end %>
</tbody>
</table>
<br>
<%= link_to 'New Tippy', new_tippy_path %>
Tippy Controller
class TippiesController < ApplicationController
#before_action :set_tippy, only: [:show, :edit, :update, :destroy]
# GET /tippies
# GET /tippies.json
def index
#tippies = Tippy.all
end
# GET /tippies/1
# GET /tippies/1.json
def show
##calculation_of_total_cost
end
# GET /tippies/new
def new
#tippy = Tippy.new
end
# GET /tippies/1/edit
def edit
end
# POST /tippies
# POST /tippies.json
def create
#tippy = Tippy.new(tippy_params)
respond_to do |format|
if #tippy.save
format.html { redirect_to #tippy, notice: 'Tippy was successfully created.' }
format.json { render :show, status: :created, location: #tippy }
else
format.html { render :new }
format.json { render json: #tippy.errors, status: :unprocessable_entity }
end
end
end
# PATCH/PUT /tippies/1
# PATCH/PUT /tippies/1.json
def update
respond_to do |format|
if #tippy.update(tippy_params)
format.html { redirect_to #tippy, notice: 'Tippy was successfully updated.' }
format.json { render :show, status: :ok, location: #tippy }
else
format.html { render :edit }
format.json { render json: #tippy.errors, status: :unprocessable_entity }
end
end
end
# DELETE /tippies/1
# DELETE /tippies/1.json
def destroy
#tippy.destroy
respond_to do |format|
format.html { redirect_to tippies_url, notice: 'Tippy was successfully destroyed.' }
format.json { head :no_content }
end
end
private
# Use callbacks to share common setup or constraints between actions.
def set_tippy
#tippy = Tippy.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.
def tippy_params
params.require(:tippy).permit(:tip, :cost)
end
end
To solve this problem you need to set a binding.pry or a breakpoint at this line of index.html.erb, so that we can understand in the loop you are executing why tippy is getting value of nil.
You need to install pry gem.
Please also share the values of #tippies and the details of the other variable in the loop that fails, because tippy=nil.
An alternative for pry is just printing the value of the variable in the log with puts tippy.calculation_of_total_cost.
Right now I am guess is that #tippies which includes all #tippy in your tippies table, could have one field that has calculation of total cost = nil. To verifiy this you should check with the debug the value of tippy and of tippy.calculation_of_total_cost in the index.html.erb view.
<% #tippies.each do |tippy| %>
<tr>
<% binding.pry %>
<td><%= tippy.tip %></td>
<td><%= tippy.cost %></td>
<td><%= tippy.calculation_of_total_cost %></td>
<td><%= link_to 'Show', tippy %></td>
<td><%= link_to 'Edit', edit_tippy_path(tippy) %></td>
<td><%= link_to 'Destroy', tippy, method: :delete, data: { confirm: 'Are you sure?' } %></td>
</tr>
<% end %>
also it is a good idea to inspect show.html.erb as there it is working.
def calculation_of_total_cost
cost + (tip * cost)
end
Actually I would like to hide all the columns from a table in rails view, if those columns contains no data i.e., zero.
Secondly, I want to delete the respective row completely if quantity == 0.
Find the screenshot for better understanding as below;
screenshot.png
index.html.erb
<div class="col-md-10 col-md-offset-1">
<div class="table-responsive myTable">
<table class="table listing text-center">
<tr class="tr-head">
<td>DESCRIPTION</td>
<td>COLOR</td>
<td>QUANTITY</td>
<td>RETAIL PRICE</td>
<td>TOTAL AMOUNT</td>
<td>CARTON NO</td>
<td>CUSTOMER 1</td>
<td>CUSTOMER 2</td>
<td>ACTUAL QUANTITY</td>
</tr>
<% #purchases.each do |purchase| %>
<tr class="tr-<%= cycle('odd', 'even') %>">
<td class="col-2"><%= purchase.description %></td>
<td class="col-1"><%= purchase.color %></td>
<td class="col-2"><%= purchase.quantity %></td>
<td class="col-2"><%= number_with_precision(purchase.rprice, :delimiter => ",", :precision => 2) %></td>
<td class="col-2"><%= number_with_precision(purchase.tamount, :delimiter => ",", :precision => 2) %></td>
<td class="col-2"><%= purchase.cartonno %></td>
<td class="col-2"><%= purchase.cus1 %></td>
<td class="col-2"><%= purchase.cus2 %></td>
<td class="col-2"><%= tquantity = purchase.quantity - purchase.cus1 - purchase.cus2 %></td>
</tr>
<% end %>
</table>
</div>
</div>
</div>
purchases_controller.rb
class PurchasesController < ApplicationController
before_action :set_purchase, only: [:show, :edit, :update, :destroy]
# GET /Stockings
# GET /deldetails.json
def index
##purchases = Purchase.all
#purchases = Purchase.where("tquantity !=?", 0)
end
def import
Purchase.import(params[:file])
redirect_to purchases_url, notice: "Purchases imported."
end
# GET /purchases/1
# GET /purchases/1.json
def show
end
# GET /purchases/new
def new
#purchase = Purchase.new
end
# GET /purchases/1/edit
def edit
end
# POST /purchases
# POST /purchases.json
def create
#purchase = Purchase.new(purchase_params)
respond_to do |format|
if #purchase.save
format.html { redirect_to #purchase, notice: 'Purchase was successfully created.' }
format.json { render :show, status: :created, location: #purchase }
else
format.html { render :new }
format.json { render json: #purchase.errors, status: :unprocessable_entity }
end
end
end
# PATCH/PUT /purchases/1
# PATCH/PUT /purchases/1.json
def update
respond_to do |format|
if #purchase.update(purchase_params)
format.html { redirect_to #purchase, notice: 'Purchase was successfully updated.' }
format.json { render :show, status: :ok, location: #purchase }
else
format.html { render :edit }
format.json { render json: #purchase.errors, status: :unprocessable_entity }
end
end
end
# DELETE /purchases/1
# DELETE /purchases/1.json
def destroy
#purchase.destroy
respond_to do |format|
format.html { redirect_to purchases_url, notice: 'Purchase was successfully destroyed.' }
format.json { head :no_content }
end
end
private
# Use callbacks to share common setup or constraints between actions.
def set_purchase
#purchase = Purchase.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.
def purchase_params
params.require(:purchase).permit(:season, :category, :articleno, :description, :color, :quantity, :rprice, :tamount, :cartonno, :cus1, :cus2, :tquantity )
end
end
purchase.rb
class Purchase < ActiveRecord::Base
def self.import(file)
CSV.foreach(file.path, headers: true) do |row|
Purchase.create! row.to_hash
end
end
end
Do I need to go for if else or ternary operator for checking the for the columns if it is empty or not ?
Any suggestions are most welcome.
Thank you in advance.
you can add a condition in your view.
<% unless #purchases.collect{|p| p.cus2}.uniq == [0] %>
<td>CUSTOMER 2</td>
<% end %>
and
<% #purchases.each do |purchase| %>
<% unless purchase.quantity == 0 %>
<tr class="tr-<%= cycle('odd', 'even') %>">
<td class="col-2"><%= purchase.description %></td>
<td class="col-1"><%= purchase.color %></td>
<td class="col-2"><%= purchase.quantity %></td>
<td class="col-2"><%= number_with_precision(purchase.rprice, :delimiter => ",", :precision => 2) %></td>
<td class="col-2"><%= number_with_precision(purchase.tamount, :delimiter => ",", :precision => 2) %></td>
<td class="col-2"><%= purchase.cartonno %></td>
<td class="col-2"><%= purchase.cus1 %></td>
<% unless #purchases.collect{|p| p.cus2}.uniq == [0] %>
<td class="col-2"><%= purchase.cus2 %></td>
<% end %>
<td class="col-2"><%= tquantity = purchase.quantity - purchase.cus1 - purchase.cus2 %></td>
</tr>
<% end %>
<% end %>
and to remove row with 0 quantity the best thing is do not select those records having 0 quantity with in query.
#purchases = Purchase.where("quantity !=?", 0)
or alternatively I also have updated the view code which is less recommended.
I have understand your problem. But why are you taking those records inside the instance varible #purchases.
You should write a query or scope like so that will exclude the record which have the values zero inside the column.
Lets have a example like as below...
Class Purchase < ActiveRecord::Base
scope :exclude_zero_value_customers, -> { where('cus1 <> ? && cus2 <> ?', 0,0) }
end
Or you can hide it directly from the view as well, But in that case if you have thousands of records then also it will go one time with that loop as bwlow...
<% #purchases.each do |purchase| %>
<% if !purchase.cus1.zero? && !purchase.cus2.zero? %>
<tr class="tr-<%= cycle('odd', 'even') %>">
<td class="col-2"><%= purchase.description %></td>
<td class="col-1"><%= purchase.color %></td>
<td class="col-2"><%= purchase.quantity %></td>
<td class="col-2"><%= number_with_precision(purchase.rprice, :delimiter => ",", :precision => 2) %></td>
<td class="col-2"><%= number_with_precision(purchase.tamount, :delimiter => ",", :precision => 2) %></td>
<td class="col-2"><%= purchase.cartonno %></td>
<td class="col-2"><%= purchase.cus1 %></td>
<td class="col-2"><%= purchase.cus2 %></td>
<td class="col-2"><%= tquantity = purchase.quantity - purchase.cus1 - purchase.cus2 %></td>
</tr>
<% end %>
<% end %>
Hello i am a new in ROR and i have a problem with routing. My route is that
http://localhost:3000/keys/pass.9 and i want to be like http://localhost:3000/keys/9/pass
Look my routes :
resources :keys , only: [:new, :show, :create, :edit, :update, :index] do
collection do
delete 'destroy_multiple'
get 'pass'
end
end
the controller:
class KeysController < ApplicationController
def pass
Key.find(params[:id]).update_attribute(:passwrod,SecureRandom.urlsafe_base64 )
respond_to do |format|
format.html { redirect_to books_path }
format.json { head :no_content }
flash[:success] = "Profile updated"
end
end
and the view:
<div class="center hero-unit">
<h1>Listing keys</h1>
<%= form_tag destroy_multiple_keys_path, method: :delete do %>
<table>
<thead>
<tr>
<th></th>
<th>Url</th>
<th>Username</th>
<th>Passwrod</th>
<th>Category</th>
</tr>
</thead>
<tbody>
<div>
<% for key in #keys %>
<% if key.book.name == #book %>
<tr>
<td><%= check_box_tag "key_ids[]", key.id %></td>
<td><%=key.url %></td>
<td><%=key.username %></td>
<td><%=key.passwrod %></td>
<td><%=key.category %></td>
<td><%= link_to 'Edit',edit_key_path(key) %></td>
<td> <%= link_to 'Change password', pass_keys_path(key) %> </td>
</tr>
<% end %>
<% end %>
<tr>
<td> <input type="button" value="check all" onclick="$(this.form).getInputs('checkbox').each(function (elem) {elem.checked = true;});" /> </td>
</tr>
</div>
<%= submit_tag "Delete selected" %>
<% end %>
<%= link_to 'New Key', new_key_path %>
<%= link_to 'Back', books_path %>
</div>
and i get that error now :
Couldn't find Key without an ID
Change the routes as
resources :keys , only: [:new, :show, :create, :edit, :update, :index] do
collection do
delete 'destroy_multiple'
end
member do
get 'pass'
end
end