Next not looping in vb.net - asp.net-mvc

Question

I have create a function:
Public Shared Function appid()
Dim appidQ = From v In db_apps.app_users
Where v.NT_id = System.Environment.UserName
Select v
For Each v In appidQ
Return Convert.ToInt32(v.app_id)
Next v
Return appid()
End Function
I am trying to return EVERY app_id for a user a place it in a viewdata (just for testing I will eventually be placing this info in a cookie.) Now this should be returning 2 records, as I currently have 2 records that meet the criteria of the query specified in appidQ. Upon debugging appidQ is indeed returning both records. However when I step into a little further the "For Each" doesn't loop so although appidQ is returning 2 records the function is only returning the first record. Any help would be greatly appreciated.
UPDATE
Obviously the Return appid() cause it to exit the loop here is my new code:
Public Shared Function appid()
Dim appidQ = From v In db_apps.app_users
Where v.NT_id = System.Environment.UserName
Select v
For Each v In appidQ
Dim var = v.app_id
Next v
Return appid()
End Function
But it still doesn't do what I need it to. I need it to return the results of
For Each v In appidQ
Dim var = v.app_id
Next v

Answer 1

As already noticed the return statement should be moved after the loop to get all the results.
Public Shared Function appid() As List(Of Int32)
Dim appidQ = From v In db_apps.app_users
Where v.NT_id = System.Environment.UserName
Select v
Dim result As New List(Of Int32)
For Each v In appidQ
result.Add(Convert.ToInt32(v.app_id))
Next v
Return result
End Function
EDIT
It seems from your comment that what you need is a String representation of the list. And when you try the ToString() extension, it returns the name of the object (ex: System.Collections.Generic.List1[System.Int32] So I don't know if there is a more efficient way, but this should work:
Public Shared Function appid() As String
Dim appidQ = From v In db_apps.app_users
Where v.NT_id = System.Environment.UserName
Select v
'Create a String representation
Dim stringList As New System.Text.StringBuilder
Dim counter As Integer = 0
For Each v In appidQ
stringList.Append(v.app_id.ToString())
'Separator
If Not counter = appidQ.Count - 1 Then
stringList.Append("; ")
End If
counter += 1
Next
Return stringList.ToString
End Function

Answer 2

You've got a Return statement in your loop.
Return is at the function level, so your loop (and function) will be exited after first passage in the loop.
You should do somtething like that (I'm not a VB guy).
Public Shared Function appid()
Return (From v In db_apps.app_users
Where v.NT_id = System.Environment.UserName
Select v).ToList()
.Select(Function(p) Convert.ToInt32(p.app_id)).ToList()
End Function
Then in your view, if you're using a ViewData, something like that.
For Each id As Int32 In CType(ViewData("foo"), List(Of Int32)
...
Next

Answer 3

Inside the loop, you Return, so you exit the function altogether (and the loop in particular).
If you do not Return, you will not exit the function, so you will have a chance to continue looping.

Answer 4

You REALLY should have Option Strict On. Since we have no idea what the data type of app_id is, and you have Option Strict Off, we can't tell what exactly we are supposed to be returning.
Try this:
Public Shared Function appid()
Return (From v In db_apps.app_users
Where v.NT_id = System.Environment.UserName
Select v.app_id).ToList()
End Function
It would be better if it were strongly-typed, but this should give you the result you want.
EDIT: If you need to convert to Int32, try this:
Public Shared Function appid()
Return (From v In db_apps.app_users
Where v.NT_id = System.Environment.UserName
Select v).ToList()
.Select(Function(p) Convert.ToInt32(p.app_id)).ToList()
End Function