Improving ruby code - ruby-on-rails

Question

people said to me that I have an wrong code at this point. The main idea of this method is to create 1 event if user pressed once, and a row of events if user pressed daily or weekly. Everything works well, but code is so bulky.
def create
#event = Event.new(event_params
#event.start_time = DateTime.parse(params[:start_time], "%Y-%m-%d %H:%i")
#event.end_time = DateTime.parse(params[:end_time], "%Y-%m-%d %H:%i")
#event.user_id = current_user.id
#event.update_attributes(:repeat_id => #event.id) if #event.save
respond_to do |format|
if #event.save
format.html { redirect_to persons_profile_path }
else
format.html { render :new }
format.json { render json: #event.errors, status: :unprocessable_entity }
end
interval = 60 if #event.repeat =='daily'
interval = 20 if #event.repeat =='weekly'
#creating row of events
if #event.repeat != 'once'
(1..interval).each do |i|
#event = Event.new(event_params)
#event.start_time = DateTime.parse(params[:start_time], "%Y-%m-%d %H:%i")
#event.end_time = DateTime.parse(params[:end_time], "%Y-%m-%d %H:%i")
#event.user_id = current_user.id
if #event.repeat =='daily'
#event.start_time = DateTime.parse(#event.start_time.to_s) + i.day
#event.end_time = DateTime.parse(#event.end_time.to_s) + i.day
end
if #event.repeat =='weekly'
#event.start_time = DateTime.parse(#event.start_time.to_s) + i.week
#event.end_time = DateTime.parse(#event.end_time.to_s) + i.week
end
#event.update_attributes(:repeat_id => k) if #event.save
#event.save
end
end
I can't find another solutions. Any ideas? Dont pay attention on parse methods on date, its needed to JS.

Answer 1

I think the issue is that you are using the controllers to do too much work and it's hard to read. Typically controllers look like:
def create
#client = Client.new(params[:client])
if #client.save
redirect_to #client
else
render "new"
end
end
Take a moment and think about your data. You create events. You want your events to appear in a row if the create button is pressed daily or weekly. So we are thinking about how to display it, that's a css/html issue, not something relating to controllers.
The reason people are saying your code as wrong is because you are doing something very atypical. If you submitted this code for school or a project you would get a low score because you are making everyone else work hard to understand your work, instead of following the same basic style that everyone was trained in.